{"id":18075,"url":"https://patchwork.libcamera.org/api/1.1/patches/18075/?format=json","web_url":"https://patchwork.libcamera.org/patch/18075/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221228223003.2265712-20-paul.elder@ideasonboard.com>","date":"2022-12-28T22:30:03","name":"[libcamera-devel,v10,19/19] lc-compliance: Add test to ensure MinimumRequests is valid","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"db207137974cc7ba3e080c1a17cc7c9395403239","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18075/mbox/","series":[{"id":3691,"url":"https://patchwork.libcamera.org/api/1.1/series/3691/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3691","date":"2022-12-28T22:29:44","name":"lc-compliance: Add test to queue more requests than hardware depth","version":10,"mbox":"https://patchwork.libcamera.org/series/3691/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18075/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18075/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74EE3C3291\n\tfor ;\n\tWed, 28 Dec 2022 22:30:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21F43625CC;\n\tWed, 28 Dec 2022 23:30:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5644A62609\n\tfor ;\n\tWed, 28 Dec 2022 23:30:42 +0100 (CET)","from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad8a:9000:1bf9:855b:22de:3645])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCBB0109;\n\tWed, 28 Dec 2022 23:30:40 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672266646;\n\tbh=Qmri63OtuQVbg9dIGqC4smNcZ7MRbgtnjv3mdBBOxek=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=U+dU2JTWpBLkvz6ZAGGkiWSQ0pdnrH/vBuN5XUlPGovymbSwAqAwW4cWlDNdv3jOG\n\tMDp4cvnUeXzGnStmp5ZXSYsm/4sgVdWKuwFdUk/iSJtgRzFG1rsSSfeJTs3wzbDgNU\n\t4FPkfuGLfgYA4cw/KCS67zsovD2C4jg8ITl08uNMRgq0Ele/iTpAUa5QhRTN8bbRWf\n\tB1Gexhdsx2xrP7GOmWBBYztS4Sq5wYuWeogWbcost0HNBS61MojetBX6XWmZnQAKkm\n\t8KMfidFZ3HP0jiHKqWbHRw5prLagt5NyzbWmqMIXVepffytRU+6lTsUHc/UPQWdKFq\n\tmNBj0vI7dwPIQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1672266642;\n\tbh=Qmri63OtuQVbg9dIGqC4smNcZ7MRbgtnjv3mdBBOxek=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qmzwQy+1HwBlXf3FZQi3CHPmW/NTLE15lpSKJRTYCCulM7aKz0sBWqRUfq7vzsLmw\n\tYswQPPW8/Z8RJmBCwvGxZPEsk5uZBKi6kd4Dk+guHBxhi8jbCmIbPXzLsCB198YZwe\n\tR8QSDd0Fjq0GWd4OyBHesJohoLjMXGiMDJU2M5lo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qmzwQy+1\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 28 Dec 2022 16:30:03 -0600","Message-Id":"<20221228223003.2265712-20-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20221228223003.2265712-1-paul.elder@ideasonboard.com>","References":"<20221228223003.2265712-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v10 19/19] lc-compliance: Add test to\n\tensure MinimumRequests is valid","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Nícolas F. R. A. Prado \n\nAdd a test in lc-compliance to check that the MinimumRequests property\nis set and valid, that is, greater than 0.\n\nSigned-off-by: Nícolas F. R. A. Prado \nReviewed-by: Paul Elder \nSigned-off-by: Paul Elder \nReviewed-by: Umang Jain \n\n---\nNo change in v10\n\nChanges in v9:\n- rebased\n\nChanges in v8:\n- Moved RequiredProperties test to property_test.cpp\n- Moved CameraTests to new test_base.{cpp,h} files\n\nChanges in v7:\n- New\n---\n src/apps/lc-compliance/meson.build | 1 +\n src/apps/lc-compliance/property_test.cpp | 24 ++++++++++++++++++++++++\n src/apps/lc-compliance/test_base.cpp | 10 ++++++++++\n src/apps/lc-compliance/test_base.h | 7 +++++++\n 4 files changed, 42 insertions(+)\n create mode 100644 src/apps/lc-compliance/property_test.cpp","diff":"diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\nindex fae290bb..a10a3cc2 100644\n--- a/src/apps/lc-compliance/meson.build\n+++ b/src/apps/lc-compliance/meson.build\n@@ -14,6 +14,7 @@ lc_compliance_sources = files([\n 'capture_test.cpp',\n 'environment.cpp',\n 'main.cpp',\n+ 'property_test.cpp',\n 'simple_capture.cpp',\n 'test_base.cpp',\n ])\ndiff --git a/src/apps/lc-compliance/property_test.cpp b/src/apps/lc-compliance/property_test.cpp\nnew file mode 100644\nindex 00000000..6a0951b2\n--- /dev/null\n+++ b/src/apps/lc-compliance/property_test.cpp\n@@ -0,0 +1,24 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2021, Collabora Ltd.\n+ *\n+ * property_test.cpp - Test camera properties\n+ */\n+\n+#include \n+\n+#include \n+\n+#include \"test_base.h\"\n+\n+using namespace libcamera;\n+\n+TEST_F(CameraTests, RequiredProperties)\n+{\n+\tconst ControlList &properties = camera_->properties();\n+\n+\tusing namespace properties;\n+\n+\tEXPECT_GT(properties.get(MinimumRequests), 0)\n+\t\t<< \"Camera should have a positive value for MinimumRequests property\";\n+}\ndiff --git a/src/apps/lc-compliance/test_base.cpp b/src/apps/lc-compliance/test_base.cpp\nindex c9957b9e..a5e64c8b 100644\n--- a/src/apps/lc-compliance/test_base.cpp\n+++ b/src/apps/lc-compliance/test_base.cpp\n@@ -26,3 +26,13 @@ void CameraHolder::releaseCamera()\n \tcamera_->release();\n \tcamera_.reset();\n }\n+\n+void CameraTests::SetUp()\n+{\n+\tacquireCamera();\n+}\n+\n+void CameraTests::TearDown()\n+{\n+\treleaseCamera();\n+}\ndiff --git a/src/apps/lc-compliance/test_base.h b/src/apps/lc-compliance/test_base.h\nindex 52347749..8125e1c6 100644\n--- a/src/apps/lc-compliance/test_base.h\n+++ b/src/apps/lc-compliance/test_base.h\n@@ -21,4 +21,11 @@ protected:\n \tstd::shared_ptr camera_;\n };\n \n+class CameraTests : public ::testing::Test, public CameraHolder\n+{\n+protected:\n+\tvoid SetUp() override;\n+\tvoid TearDown() override;\n+};\n+\n #endif /* __LC_COMPLIANCE_TEST_BASE_H__ */\n","prefixes":["libcamera-devel","v10","19/19"]}