{"id":1804,"url":"https://patchwork.libcamera.org/api/1.1/patches/1804/?format=json","web_url":"https://patchwork.libcamera.org/patch/1804/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190813094020.10277-6-kieran.bingham@ideasonboard.com>","date":"2019-08-13T09:40:19","name":"[libcamera-devel,v3,5/6] test: v4l2_device: Remove unused function","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d917305f8ebc8d5b0a405aad6d1e4f015bcb2fd2","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1804/mbox/","series":[{"id":458,"url":"https://patchwork.libcamera.org/api/1.1/series/458/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=458","date":"2019-08-13T09:40:14","name":"V4L2 M2M Support (+RPi PoC)","version":3,"mbox":"https://patchwork.libcamera.org/series/458/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1804/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1804/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78E4861624\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Aug 2019 11:40:26 +0200 (CEST)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1578A327;\n\tTue, 13 Aug 2019 11:40:26 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565689226;\n\tbh=KuWEHIP7kI5s1B4Y6wAB4Z/UIf5ZF8he91quKAYIGKA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tPQwXRKDyMszwiyGPWapyOa5MJFuguE2ieCoSoZ+fthW6WIx/znlkjgOgtbE6guUo\n\t1OMY+NE395anlFi4lfNNKOAnxjBK/FEdvM2ac2M69jmxg4aZG7yD8fJm2RUx2Ebn1s\n\t384PknzoQwy9zb5/EpxjcSEQ4LrC3cwkHGYvsY6g=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Date":"Tue, 13 Aug 2019 10:40:19 +0100","Message-Id":"<20190813094020.10277-6-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190813094020.10277-1-kieran.bingham@ideasonboard.com>","References":"<20190813094020.10277-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 5/6] test: v4l2_device: Remove unused\n\tfunction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 13 Aug 2019 09:40:26 -0000"},"content":"The 'exists()' call is not used within the code base.\nRemove it.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/v4l2_videodevice/v4l2_videodevice_test.cpp | 11 -----------\n 1 file changed, 11 deletions(-)","diff":"diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.cpp b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\nindex a0d269fef7f4..096f9649bfc9 100644\n--- a/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n+++ b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n@@ -6,7 +6,6 @@\n  */\n \n #include <iostream>\n-#include <sys/stat.h>\n \n #include <linux/media-bus-format.h>\n \n@@ -18,16 +17,6 @@\n using namespace std;\n using namespace libcamera;\n \n-bool exists(const std::string &path)\n-{\n-\tstruct stat sb;\n-\n-\tif (stat(path.c_str(), &sb) == 0)\n-\t\treturn true;\n-\n-\treturn false;\n-}\n-\n int V4L2VideoDeviceTest::init()\n {\n \tenumerator_ = DeviceEnumerator::create();\n","prefixes":["libcamera-devel","v3","5/6"]}