{"id":18029,"url":"https://patchwork.libcamera.org/api/1.1/patches/18029/?format=json","web_url":"https://patchwork.libcamera.org/patch/18029/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221216122939.256534-16-paul.elder@ideasonboard.com>","date":"2022-12-16T12:29:36","name":"[libcamera-devel,v9,15/18] lc-compliance: Move role to string conversion to its own function","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e5a3663ea6948b93e2d5620dcf7615d0f43340a6","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18029/mbox/","series":[{"id":3675,"url":"https://patchwork.libcamera.org/api/1.1/series/3675/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3675","date":"2022-12-16T12:29:21","name":"lc-compliance: Add test to queue more requests than hardware depth","version":9,"mbox":"https://patchwork.libcamera.org/series/3675/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18029/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18029/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B79B8C328E\n\tfor ;\n\tFri, 16 Dec 2022 12:30:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C3AE6339F;\n\tFri, 16 Dec 2022 13:30:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3DAA6339F\n\tfor ;\n\tFri, 16 Dec 2022 13:30:28 +0100 (CET)","from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00817A31;\n\tFri, 16 Dec 2022 13:30:26 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671193829;\n\tbh=01pZHYVZngDe+B2HzCbcASuxSqUGF6xdmRpG+MH2Sh8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Kr9d0zngmA9qwUyJpkyV5v994Jz5Rxr84Hhq+HeH9cJ8Q0G4SDCct4Vy+JkiC4Aph\n\t9xJTkH4Uj3ZK/FJ89KFpxALY2dXTR2RHpyaJq07+cbCvk78pCTA/CdEyN6mVM2BW8Z\n\tH9KfLrQ3mQWrssCJoHP2YDEjFHKVqOwoH+jd2cJy/QlUoM8zaU5skoprqHfXuJNZyO\n\typ7JWQKMlDIC9gPO0PteNNBVnPVVqIjBR85EK6x3trW++n758+Jn0BA4RfpH9M4VTn\n\tyEiJQfq9xnLI88LAs1qrV0mXuKmhQt6cm4S97a/CCcd7GhzuK4coAC/VkXTlt39t9c\n\tpJAmVBgEyaW1Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671193828;\n\tbh=01pZHYVZngDe+B2HzCbcASuxSqUGF6xdmRpG+MH2Sh8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rlewFkH0fokTo2PLvCU+pKJLJgvBNrsVSzANxXihXsxlKj1SaTqMgWY7+j1e1FKOV\n\tnpDWppFdxdBeN/WWbRIPSiidGQ35d3H7YCvtF3n2SYmPdLPlONQkVOq/u23+KIJbMA\n\t3DZutr5z+XKv+IBE2mFACIvIcNe6F3e60UB7FP1M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rlewFkH0\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 16 Dec 2022 21:29:36 +0900","Message-Id":"<20221216122939.256534-16-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20221216122939.256534-1-paul.elder@ideasonboard.com>","References":"<20221216122939.256534-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v9 15/18] lc-compliance: Move role to\n\tstring conversion to its own function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Nícolas F. R. A. Prado \n\nThe functions that generate the test name based on the parameters need\nto convert a StreamRole to a string. Move this to a separate function to\navoid redundancy.\n\nSigned-off-by: Nícolas F. R. A. Prado \nReviewed-by: Laurent Pinchart \nReviewed-by: Paul Elder \nSigned-off-by: Paul Elder \n\n---\n\nChanges in v8:\n- Made roleToString()'s map const and changed usage from [] operator to at()\n\nChanges in v5:\n- New\n---\n src/apps/lc-compliance/capture_test.cpp | 25 ++++++++++++++-----------\n 1 file changed, 14 insertions(+), 11 deletions(-)","diff":"diff --git a/src/apps/lc-compliance/capture_test.cpp b/src/apps/lc-compliance/capture_test.cpp\nindex 2b82443a..d62f7692 100644\n--- a/src/apps/lc-compliance/capture_test.cpp\n+++ b/src/apps/lc-compliance/capture_test.cpp\n@@ -23,6 +23,18 @@ const std::vector ROLES = {\n \tStreamRole::Viewfinder\n };\n \n+static const std::string &roleToString(const StreamRole &role)\n+{\n+\tstatic const std::map rolesMap = {\n+\t\t{ StreamRole::Raw, \"Raw\" },\n+\t\t{ StreamRole::StillCapture, \"StillCapture\" },\n+\t\t{ StreamRole::VideoRecording, \"VideoRecording\" },\n+\t\t{ StreamRole::Viewfinder, \"Viewfinder\" }\n+\t};\n+\n+\treturn rolesMap.at(role);\n+}\n+\n class SingleStream : public testing::TestWithParam>, public CameraHolder\n {\n public:\n@@ -49,17 +61,8 @@ void SingleStream::TearDown()\n \n std::string SingleStream::nameParameters(const testing::TestParamInfo &info)\n {\n-\tstd::map rolesMap = {\n-\t\t{ StreamRole::Raw, \"Raw\" },\n-\t\t{ StreamRole::StillCapture, \"StillCapture\" },\n-\t\t{ StreamRole::VideoRecording, \"VideoRecording\" },\n-\t\t{ StreamRole::Viewfinder, \"Viewfinder\" }\n-\t};\n-\n-\tstd::string roleName = rolesMap[std::get<0>(info.param)];\n-\tstd::string numRequestsName = std::to_string(std::get<1>(info.param));\n-\n-\treturn roleName + \"_\" + numRequestsName;\n+\treturn roleToString(std::get<0>(info.param)) + \"_\" +\n+\t std::to_string(std::get<1>(info.param));\n }\n \n /*\n","prefixes":["libcamera-devel","v9","15/18"]}