{"id":17984,"url":"https://patchwork.libcamera.org/api/1.1/patches/17984/?format=json","web_url":"https://patchwork.libcamera.org/patch/17984/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221213091558.621950-2-paul.elder@ideasonboard.com>","date":"2022-12-13T09:15:52","name":"[libcamera-devel,v2,1/7] tracepoints: request: Use public Request pointer in all tracepoints","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7aeddd56eb794ca0f35f68afddcb4ef9f5c55274","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17984/mbox/","series":[{"id":3668,"url":"https://patchwork.libcamera.org/api/1.1/series/3668/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3668","date":"2022-12-13T09:15:51","name":"tracepoints: request: Improve request tracepoints","version":2,"mbox":"https://patchwork.libcamera.org/series/3668/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17984/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17984/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B9F6C328D\n\tfor ;\n\tTue, 13 Dec 2022 09:16:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E116663354;\n\tTue, 13 Dec 2022 10:16:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E14F563354\n\tfor ;\n\tTue, 13 Dec 2022 10:16:12 +0100 (CET)","from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AABC87C5;\n\tTue, 13 Dec 2022 10:16:11 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670922974;\n\tbh=AWwks3MUmdCPKcHt5f+555qCTZBdaS1XjdE7e3U70P4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=oVAt1dLFQFfpym+RdGk5IZu6YgQB8oVwxN2vDW6t9zPxZ84nQqeI7NSg8Vw15UNJe\n\tnXl5F2aKEKDQKFgAzzEABs1lOWaLXjLWtnGItIgD5bNZUuPp9md2H4U6pIL/Y1Ahgt\n\tZXt3nXGmAz2YFPIK5yJZw55J0KvJQJgSlN26743lOQ7S1q2CB1sIyTpbujsspK1N4n\n\tDqdebXMWwHvfw4KdjJHYUD/XYrDyu+4So0gSMMKOpSZ3UIt8gAc4XIvMjkr6wrVwwH\n\ttj50itN+PZeWsw+nMed7EKKZ45yXU7/8mXKDBJw/qJXRUqYWc2ZDAqtVhHtjGAlxGA\n\t2HeOaHoH6dPng==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670922972;\n\tbh=AWwks3MUmdCPKcHt5f+555qCTZBdaS1XjdE7e3U70P4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SZRVO9NZQ5WrxwymBcp2G2zYCoYtXYKnTgx/fh/gJtekx3XwK/+nKLv258WCOIG8Y\n\t5f7+sMz9/vMcuydUkwUOV0hmXujReITBzQkfvBdBgjLvAxx4llaG7oZgQlGCtNGVpN\n\tAAHjsUBUaglBg4XGoQCXFirRpetMkINDs2k9MNn8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SZRVO9NZ\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 13 Dec 2022 18:15:52 +0900","Message-Id":"<20221213091558.621950-2-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20221213091558.621950-1-paul.elder@ideasonboard.com>","References":"<20221213091558.621950-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/7] tracepoints: request: Use public\n\tRequest pointer in all tracepoints","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Make all tracepoints use the public Request pointer instead of some of\nthem using the Private one. This makes it easier to track the Requests\nin a trace.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v2\n---\n include/libcamera/internal/tracepoints/request.tp | 7 +++----\n src/libcamera/request.cpp | 7 ++++---\n 2 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp\nindex f1e54497..9d0bcbfa 100644\n--- a/include/libcamera/internal/tracepoints/request.tp\n+++ b/include/libcamera/internal/tracepoints/request.tp\n@@ -5,9 +5,8 @@\n * request.tp - Tracepoints for the request object\n */\n \n-#include \n-\n #include \n+#include \n \n TRACEPOINT_EVENT_CLASS(\n \tlibcamera,\n@@ -72,7 +71,7 @@ TRACEPOINT_EVENT_INSTANCE(\n \trequest,\n \trequest_complete,\n \tTP_ARGS(\n-\t\tlibcamera::Request::Private *, req\n+\t\tlibcamera::Request *, req\n \t)\n )\n \n@@ -81,7 +80,7 @@ TRACEPOINT_EVENT_INSTANCE(\n \trequest,\n \trequest_cancel,\n \tTP_ARGS(\n-\t\tlibcamera::Request::Private *, req\n+\t\tlibcamera::Request *, req\n \t)\n )\n \ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 949c556f..1dedc26e 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -121,7 +121,7 @@ void Request::Private::complete()\n \n \tLOG(Request, Debug) << request->toString();\n \n-\tLIBCAMERA_TRACEPOINT(request_complete, this);\n+\tLIBCAMERA_TRACEPOINT(request_complete, request);\n }\n \n void Request::Private::doCancelRequest()\n@@ -149,9 +149,10 @@ void Request::Private::doCancelRequest()\n */\n void Request::Private::cancel()\n {\n-\tLIBCAMERA_TRACEPOINT(request_cancel, this);\n-\n \tRequest *request = _o();\n+\n+\tLIBCAMERA_TRACEPOINT(request_cancel, request);\n+\n \tASSERT(request->status() == RequestPending);\n \n \tdoCancelRequest();\n","prefixes":["libcamera-devel","v2","1/7"]}