{"id":17978,"url":"https://patchwork.libcamera.org/api/1.1/patches/17978/?format=json","web_url":"https://patchwork.libcamera.org/patch/17978/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221212071647.23803-1-umang.jain@ideasonboard.com>","date":"2022-12-12T07:16:47","name":"[libcamera-devel] libcamera: camera_sensor: Rectify test patterns listed for IMX519","commit_ref":"b026e4a6a0a620ce994938c3d1babd3f3df4a47e","pull_url":null,"state":"accepted","archived":false,"hash":"f79d6567cdf52466f8125b14db9830a2418c5173","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17978/mbox/","series":[{"id":3665,"url":"https://patchwork.libcamera.org/api/1.1/series/3665/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3665","date":"2022-12-12T07:16:47","name":"[libcamera-devel] libcamera: camera_sensor: Rectify test patterns listed for IMX519","version":1,"mbox":"https://patchwork.libcamera.org/series/3665/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17978/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17978/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F73AC31E9\n\tfor ;\n\tMon, 12 Dec 2022 07:16:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6558463362;\n\tMon, 12 Dec 2022 08:16:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7894603C8\n\tfor ;\n\tMon, 12 Dec 2022 08:16:56 +0100 (CET)","from umang.jainideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3e:7d24:3f0:3e81:fb16:ab4d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 094A3896;\n\tMon, 12 Dec 2022 08:16:54 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670829418;\n\tbh=+JBOhToP2haO2JcwfnJCK0pb283fLxQO2ib8JwzeHBE=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=mEtwz5GnRqKlDbqFgpEkIWxosWrvD28Pc9ocrqcoB+QiP6rWV9eGREBkQkKHqaIS5\n\tnIvHSmtd7QjrtWjoVKgiQraw8eWqhrFnBRO10SuvDdt4MqjQ7XFQJbXFqVUzWTLioS\n\t8PIZiG+ua6aUveM2rTGMqWlAs6SCGdW0KjjhdjszdCMtFKPmO0o8M6fwmynFcZMLbp\n\tb+lNEXv8KhhSjFsKYt796nenr1eM6xU2f3dOwyzS6fYEmGMWm2i5YGGPj0A4j5Xd8I\n\tQCMrxf2MDKPKq477k0PT092bMHAq3DqVYezUE5yx+Kg/Xz3UXOlyAhGoXYltuwAHEW\n\tBXtFDCJLqpQMw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670829416;\n\tbh=+JBOhToP2haO2JcwfnJCK0pb283fLxQO2ib8JwzeHBE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=TD4b1ReK+/5bwnD9yf0Nbgd5rkE2lhCYiNVgm6wcnWOpamPgkdGnKjGuIAKuoS59u\n\t6h1/1ouNHMdmXLX/kYyJawYIDdfMTuSgBfTkerxepe4jeYrq+hdsUAYYbtGt+NHIyI\n\trzQkcHvmTjWPfxw7f5v0Zbe6YPQl/SPjSa7In/qg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TD4b1ReK\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 12 Dec 2022 12:46:47 +0530","Message-Id":"<20221212071647.23803-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.38.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: camera_sensor: Rectify test\n\tpatterns listed for IMX519","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IMX519 driver reports ColorBars and ColorBarsFadeToGray but upon\ninspecting the test pattern modes via v4l2-ctl utility, these test\npatterns do not comply with MIPI CCS v1.1 (Section 10.1).\n\nHence, omit from camera-sensor-properties database for now and add a\ncomment for the same.\n\nFixes: e3b26b4c4eb2 (\"libcamera: camera_sensor: Add IMX519 sensor properties\")\nSigned-off-by: Umang Jain \n---\n src/libcamera/camera_sensor_properties.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\nindex 04d80d6d..7f5e404e 100644\n--- a/src/libcamera/camera_sensor_properties.cpp\n+++ b/src/libcamera/camera_sensor_properties.cpp\n@@ -106,10 +106,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t.unitCellSize = { 1220, 1220 },\n \t\t\t.testPatternModes = {\n \t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n-\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n \t\t\t\t{ controls::draft::TestPatternModeSolidColor, 2 },\n-\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n+\t\t\t\t/*\n+\t\t\t\t * The driver reports ColorBars and ColorBarsFadeToGray as well but\n+\t\t\t\t * these two patterns do not comply with MIPI CCS v1.1 (Section 10.1).\n+\t\t\t\t */\n \t\t\t},\n \t\t} },\n \t\t{ \"ov2740\", {\n","prefixes":["libcamera-devel"]}