{"id":17941,"url":"https://patchwork.libcamera.org/api/1.1/patches/17941/?format=json","web_url":"https://patchwork.libcamera.org/patch/17941/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221202210818.343046-1-Rauch.Christian@gmx.de>","date":"2022-12-02T21:08:18","name":"[libcamera-devel,v2] meson: Use library() in order to let user chose the library type","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"05464dcc5e26e1422d5e1e4b540279f83b827d13","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/1.1/people/111/?format=json","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17941/mbox/","series":[{"id":3657,"url":"https://patchwork.libcamera.org/api/1.1/series/3657/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3657","date":"2022-12-02T21:08:18","name":"[libcamera-devel,v2] meson: Use library() in order to let user chose the library type","version":2,"mbox":"https://patchwork.libcamera.org/series/3657/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17941/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17941/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A914ABE08B\n\tfor ;\n\tFri, 2 Dec 2022 21:08:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 106C16333F;\n\tFri, 2 Dec 2022 22:08:23 +0100 (CET)","from mout.gmx.net (mout.gmx.net [212.227.15.19])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCDC160483\n\tfor ;\n\tFri, 2 Dec 2022 22:08:21 +0100 (CET)","from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx004\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1MtfNl-1oiIyQ10mt-00v68m;\n\tFri, 02 Dec 2022 22:08:21 +0100"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670015303;\n\tbh=Enswq83KrHuBmap7IrvlsXN9UGMn1ClNfiYlbJg0rGA=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=ugSeBpghdm5P2pi0OltCcVoD+Ll+DR+EvB08pXlsGIiC8tIWSasSg2XSWGYgaqL7Z\n\tjgmkkd6hdhUDA3uPIC8hzxIIP82j6QUivbZhdgmPcWVtbb9975S+v0HgUZlQObidTW\n\thS/RkOShvnDCP1VWORNg7N7TauwlyhMA2tagEYrRmL/jkwafma52/eWJVfHbXAMEKD\n\t43NxaBVqL7q0hcdJthdb92ZXBuONyIN3mjvX9sEVEa7ePJTqog1p8BEXjMpiwp3Pnw\n\tCh/ujc6HurX0ptxOl+/MpPubI6PPe7MXmyCjsnxQzFXA1Oz7ytoIbH9BdwAWbC7zco\n\tuX7JkdF+co9mQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; \n\tt=1670015301; bh=Enswq83KrHuBmap7IrvlsXN9UGMn1ClNfiYlbJg0rGA=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date;\n\tb=IQSTh7WTQ60uF6l/NteWe5JfQiFZREvhkDDf0KV+2PETfbEvk97ltnn8sVg4OMd90\n\tPapPrDWcHOvyuX7E0lU89G8yacS9zzaRiznqsDxFTOi1tMDaFQIWQPlmdZ3sRJU5M/\n\t+k4/BwWphRDo1KgQpKg4hE7jSws9iC2mU2VMRRFKHpfAYDZptxErBKlkM6vG7Jagho\n\twiKvRiFfIYaXZH32zo3Sg8sxkE/ia9IDBpF68dEGtoZVg4BiZBRXLPkeVOPmjz2fSK\n\thcSAMFOtiFi/OMO0W+l4hkPT0tseA1y7OUWBGUgd+A7Wap+XFRxoXeNlWkBF2wzhIW\n\trzcn/OjZcFFAg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmx.de header.i=@gmx.de\n\theader.b=\"IQSTh7WT\"; dkim-atps=neutral","X-UI-Sender-Class":"724b4f7f-cbec-4199-ad4e-598c01a50d3a","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Dec 2022 22:08:18 +0100","Message-Id":"<20221202210818.343046-1-Rauch.Christian@gmx.de>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:/4mNyiK/EPEV0U04TaAVZdpposuLzycXLCXtusf44sPk31pyIHK\n\tdbGRlTA+Un7316D7H/rrDIXTk2NfM45f0SEXQ0IM8o0whHkmuZbl3rcR45F0AgiBi6tk3rJ\n\tjlVWOCvuLRt96DmWRyMhr9n2+Rxh09yyUEKcTmkF+Kiq/B3N98VhzXbu4FW1ZBZTbGuE1hs\n\t8gG2lsYh8FVAaYXOtFt2A==","X-Spam-Flag":"NO","UI-OutboundReport":"notjunk:1; M01:P0:orwB6IP7CP0=;\n\tcumQb5kDKwbZv+cqd83pnxSquL6\n\tS9r1bZgJM4f84SkI9+AbfEWz36R6z9agXTyUs2RvHew91sJ7jFBAjx1eczkvWFrhH4QJMXqXa\n\tDS4i0bjZhGegwVoGI8/t0k/KtnH8NMGF0As3/0GhoWjAjVQc4z8Iesq3sT2uwQeyA3Fwa3oOa\n\tUKIbZOOiBuCkWdEWUN5v3+yrkfbDQPreu/YQBMjwBSHAE7EZbGkUVv/YmHS0MWa6mabtPq8Ln\n\tCMziPBCuyJaZR/aT1zYI7QxzBYkWos+yhwC+mpiW5ypigp5QCFo5Z3wdyR8VQzzXPQpbl1+oI\n\tELG951kaBH0OKKlT1EL5hm4FdTYMfFmZa9YghJnRQQVthEHte2JhSGdNsNFdFxdzmCQ98Xl1h\n\t+OfBswLdG2tQiEugXCI6AVW25RlzKkL+PqjaODNTL9AiCXtoMkWcNbYtxXMYP4Fx5ZdFKI80O\n\tcTl52iPsnrep12Uek4uHgUo892EaV+1D6wPNml1thLWe170HYkbMHfJvOS27CwQb3T3MqxBAw\n\tFoXgvXWmTdGan7k1BZCWyjMN7Zz5LTRgZQMTceFnmEbbNJCEEAr22i2PF1kFSgb+aJ91fyPFZ\n\tC6gw/xAOiiy6N30PyPavlk5lIGfX+XcY6+Ugu5/1wK6kVE0Y+Mu9zwqVtZqkdlGe28V1h2DIT\n\t5KMaD9cnfa5D2OOygp46/PCUZvrLGHl9FSYNrx3adwojn5TM0VijHDroIbMxJf05CA+RU0Ln3\n\thrlkedeVSap/jS0C5h1hbm315w4hyPmxZTc0sCy9l7DFPZqkQEb9uZ74qkhyubMXcrRkGULrz\n\t2xDSVZUDnNj+6poEIPYMBK5DOnBsjgjhFfntVe3ZgOjk/Lgvbsyn4C99ZCLntisb4uJaBR/DP\n\t4oYf9lXoYmrzrm50EBnsbZ+p4NTfeg/UL+IhvziSzOfl+pSBZ/U9SVXqgUgRWeF2Ac5U+VDeK\n\tStRowA==","Subject":"[libcamera-devel] [PATCH v2] meson: Use library() in order to let\n\tuser chose the library type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Defining libraries via shared_library() prevents compiling libcamera as\nstatic library. The meson project recommends using library() instead of\nshared_library(), static_library() or both_libraries():\nhttps://mesonbuild.com/Reference-manual_functions.html#library\n\nSigned-off-by: Christian Rauch \n---\n src/libcamera/base/meson.build | 18 +++++++++---------\n src/libcamera/meson.build | 18 +++++++++---------\n 2 files changed, 18 insertions(+), 18 deletions(-)\n\n--\n2.34.1","diff":"diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\nindex 7a7fd7e4..91dc1e71 100644\n--- a/src/libcamera/base/meson.build\n+++ b/src/libcamera/base/meson.build\n@@ -48,15 +48,15 @@ libcamera_base_deps = [\n # the use of headers which must not be exposed to the libcamera public api.\n libcamera_base_args = [ '-DLIBCAMERA_BASE_PRIVATE' ]\n\n-libcamera_base_lib = shared_library('libcamera-base',\n- [libcamera_base_sources, libcamera_base_headers],\n- version : libcamera_version,\n- soversion : libcamera_soversion,\n- name_prefix : '',\n- install : true,\n- cpp_args : libcamera_base_args,\n- include_directories : libcamera_includes,\n- dependencies : libcamera_base_deps)\n+libcamera_base_lib = library('libcamera-base',\n+ [libcamera_base_sources, libcamera_base_headers],\n+ version : libcamera_version,\n+ soversion : libcamera_soversion,\n+ name_prefix : '',\n+ install : true,\n+ cpp_args : libcamera_base_args,\n+ include_directories : libcamera_includes,\n+ dependencies : libcamera_base_deps)\n\n libcamera_base = declare_dependency(sources : [\n libcamera_base_headers,\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 0494e808..cd1bf4ed 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -163,15 +163,15 @@ libcamera_deps = [\n # runtime if the library is running from an installed location by checking\n # for the presence or abscence of the dynamic tag.\n\n-libcamera = shared_library('libcamera',\n- libcamera_sources,\n- version : libcamera_version,\n- soversion : libcamera_soversion,\n- name_prefix : '',\n- install : true,\n- include_directories : includes,\n- build_rpath : '/',\n- dependencies : libcamera_deps)\n+libcamera = library('libcamera',\n+ libcamera_sources,\n+ version : libcamera_version,\n+ soversion : libcamera_soversion,\n+ name_prefix : '',\n+ install : true,\n+ include_directories : includes,\n+ build_rpath : '/',\n+ dependencies : libcamera_deps)\n\n libcamera_public = declare_dependency(sources : [\n libcamera_ipa_headers,\n","prefixes":["libcamera-devel","v2"]}