{"id":17938,"url":"https://patchwork.libcamera.org/api/1.1/patches/17938/?format=json","web_url":"https://patchwork.libcamera.org/patch/17938/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221202132706.15675-1-jacopo@jmondi.org>","date":"2022-12-02T13:27:06","name":"[libcamera-devel] utils: ipu3: Include libgen.h for basename()","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"4a56df4b87b0549725f5fa254ba22724a80a3525","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17938/mbox/","series":[{"id":3655,"url":"https://patchwork.libcamera.org/api/1.1/series/3655/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3655","date":"2022-12-02T13:27:06","name":"[libcamera-devel] utils: ipu3: Include libgen.h for basename()","version":1,"mbox":"https://patchwork.libcamera.org/series/3655/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17938/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17938/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4C48BDE6B\n\tfor ;\n\tFri, 2 Dec 2022 13:27:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A86763336;\n\tFri, 2 Dec 2022 14:27:15 +0100 (CET)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83C7060483\n\tfor ;\n\tFri, 2 Dec 2022 14:27:14 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id C5399240005;\n\tFri, 2 Dec 2022 13:27:13 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669987635;\n\tbh=2lXcHSmNsL4ACnngr6hFv7GfYvaz4mQVw3QMU0pKzvw=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=nj8tuDdE/d9BrfdntdusqNuoSsBUDkNeZBoI/32mswQxaJoL73TstTTbHWVOm8QRV\n\t4iG8JvAz/hE8+ObOTtzuYz1GTttDn+V+Mp3nSD6YCmd93cnkQFyFIcEYf+ZunirO+f\n\tcFSa1qheBQ5Z43jXRW04QPCnYEvuTGKX0MInMVVM4KnWy8L2buNHaKL9qI0b+50GRb\n\tgpys7KA532NVZiB4HpHL6Y4l8ANcG6+rdzN2u6lSCQjTKqe26bPrK9irNGpXUKE+05\n\tO172cJEI2zs6hhmxDC7MNUgxnEpyVHCJHinrsEY51NOAnNU7nJLQktSpT/lF06n0bR\n\tAnPmQwCJPaM7A==","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Dec 2022 14:27:06 +0100","Message-Id":"<20221202132706.15675-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.38.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] utils: ipu3: Include libgen.h for\n\tbasename()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The \"basename\" function from the standard C library is defined in the\nlibgen.h header.\n\nInclude it to avoid errors triggered by -Wimplicit-function-declaration\n\n../utils/ipu3/ipu3-pack.c:21:47: error: implicit declaration of function\n'basename' is invalid in C99 [-Werror,-Wimplicit-function-declaration]\n\nSigned-off-by: Jacopo Mondi \n---\n utils/ipu3/ipu3-pack.c | 1 +\n utils/ipu3/ipu3-unpack.c | 1 +\n 2 files changed, 2 insertions(+)","diff":"diff --git a/utils/ipu3/ipu3-pack.c b/utils/ipu3/ipu3-pack.c\nindex decbfc6c397a..27af44068956 100644\n--- a/utils/ipu3/ipu3-pack.c\n+++ b/utils/ipu3/ipu3-pack.c\n@@ -8,6 +8,7 @@\n \n #include \n #include \n+#include \n #include \n #include \n #include \ndiff --git a/utils/ipu3/ipu3-unpack.c b/utils/ipu3/ipu3-unpack.c\nindex 9d2c1200d932..aa67e0b0ecf5 100644\n--- a/utils/ipu3/ipu3-unpack.c\n+++ b/utils/ipu3/ipu3-unpack.c\n@@ -8,6 +8,7 @@\n \n #include \n #include \n+#include \n #include \n #include \n #include \n","prefixes":["libcamera-devel"]}