{"id":17920,"url":"https://patchwork.libcamera.org/api/1.1/patches/17920/?format=json","web_url":"https://patchwork.libcamera.org/patch/17920/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221130113727.13299-1-naush@raspberrypi.com>","date":"2022-11-30T11:37:27","name":"[libcamera-devel] ipa: raspberrypi: Fix bug in IPA frame drop logic","commit_ref":"6b03da662b8b0f919e7df230cd78ba007aafc096","pull_url":null,"state":"accepted","archived":false,"hash":"016c0ff05a839affb6fca031ffe6fc15056fa66b","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17920/mbox/","series":[{"id":3650,"url":"https://patchwork.libcamera.org/api/1.1/series/3650/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3650","date":"2022-11-30T11:37:27","name":"[libcamera-devel] ipa: raspberrypi: Fix bug in IPA frame drop logic","version":1,"mbox":"https://patchwork.libcamera.org/series/3650/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17920/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17920/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC399BDE6B\n\tfor ;\n\tWed, 30 Nov 2022 11:37:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A220A63336;\n\tWed, 30 Nov 2022 12:37:32 +0100 (CET)","from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C61161F23\n\tfor ;\n\tWed, 30 Nov 2022 12:37:31 +0100 (CET)","by mail-wm1-x335.google.com with SMTP id\n\t2-20020a1c0202000000b003d0760654d3so593078wmc.4\n\tfor ;\n\tWed, 30 Nov 2022 03:37:31 -0800 (PST)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tay2-20020a05600c1e0200b003cfd0bd8c0asm1684453wmb.30.2022.11.30.03.37.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 30 Nov 2022 03:37:30 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669808252;\n\tbh=hOwXpYEbokN/9FzGW9HbnyOVGStujn0uJbY7Of4SplM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=0HEPuKZeNYI2dtmwxkEtjlFpmyqNTriGpj2+ao8h0GuqiYiwxwDh0EFe/3fAy0C40\n\tbXVPXB5X94nF8XoFyUow/DCylhdHKb7ZNVOUIRPwUJkY6jN7a4bf5cXU3S5ULEOvy2\n\tASQR8j8ROSAZtbR5I5yYmXc6H+Y6Wog1qKBZKSww2LIBMN4Nh7L9IH4UuLTtZarNZQ\n\tvDyNz04BxVY/3QA1WrQMVvC1LrXWCOAgrK78Vo6gSH6zbU8g1+0jStTgdKu41qGbxk\n\tVggu7k0iVeZXh2eG58NDOP5w0HeBRLkFDZyc2S1W+16XTuhXexzX+RKUgso7nY6M4i\n\tweBAM0Kae3+dQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=jV0DkeSD9+ryVwEfDFqMUMlzS2JZq+Z7ewx9Mer0lCk=;\n\tb=YvEvgefof4VM7zofLYro6LqNvc7Uv3s1N6y7Cytw+mtfOq1WjNMqNLPL1ouR1LrfPp\n\t94oJKCTu/bDUb6ck2N8IT8hDypV+EKqyZNhAEEGpb43LrirI8EKSS3l6CLxKqn6ngZW9\n\t5qBjNPMqb0bQnkXf5wjE6FGO6v5ZGVSf7PAkHTHEW/wBNZCxa+YHnyYqilEk2m4MjnkV\n\tb2LMnU5YS2JCRU3eNF/4dOQbYqoiYRUNpP1F8gvQNTIjOB9J0oOQfLFVOy6zVYkSNHUk\n\tlBu1mHpJjkfdWYiVkjtBRTA3gBdDafqOhZvj+CN+tHxSkWN0JDgLk1XZGQQQzAIGq6To\n\tbqUg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"YvEvgefo\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=jV0DkeSD9+ryVwEfDFqMUMlzS2JZq+Z7ewx9Mer0lCk=;\n\tb=pCTHGNiGnE+Q6ftewTkLSYCrrKxUQcVT5cyRT3JSApUlPp2K6N/y8M/IvYp/yZcCxW\n\tYiMW5MXqonYo5m4xzvxnnLixhGOxKboN5Fpaz9AMcJd0AWy86QJco6/OzFHMlq7q97ym\n\tyDY2JNnu2tudNL7WCD4rN0FUyaIr7AazUtun7geVWHkohOxufCxYSTjS5WlxhPJpcMgq\n\tIWJZMMLCf0F7zzmi45Q0Lev1XlpFCuP/EjZHEjkIT86+DFcon3JkHfvNbXV7uUW7Y6ZC\n\tbAJfJeAC3lfvxrojlaBlVokT5hmP7kCPu+RK/SHRZ+hBJy8qWA1CGM0nCmi6fWklfXKB\n\tJn3Q==","X-Gm-Message-State":"ANoB5plsTy7f1Zr593nRzbRVOCzF5PdH0s0QWIME1mvUPeNmsEaN3WTA\n\tuDIqIhtMFCsbhA2wTprSkBUYVkuelXUCqA==","X-Google-Smtp-Source":"AA0mqf5eSozeH+LikIcp3TfRqUxdSyjC7Af/hNu+l8rN00i7IYWTTr+gKssvo3xTF4OyoBpAh1T3eQ==","X-Received":"by 2002:a05:600c:4e50:b0:3d0:bda:f2c with SMTP id\n\te16-20020a05600c4e5000b003d00bda0f2cmr31740878wmq.117.1669808250493; \n\tWed, 30 Nov 2022 03:37:30 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 30 Nov 2022 11:37:27 +0000","Message-Id":"<20221130113727.13299-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20221130105253.12497-1-naush@raspberrypi.com>","References":"<20221130105253.12497-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: raspberrypi: Fix bug in IPA frame\n\tdrop logic","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Fix a bug in the IPA frame dropping (for rate control) logic, where the\nmetadata for the current context was copied from itself (i.e. a no-op), instead\nof being copied from the previous context.\n\nThis bug does not occur in normal conditions, only when running with a low\nexposure time and unconstrained framerate, which happens in a particular\npicamera2 test.\n\nFixes: 546154b13433 (\"pipeline: ipa: raspberrypi: Use IPA cookies\")\nSigned-off-by: Naushir Patuck \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 0f914f841e54..bead436def3c 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -1062,7 +1062,7 @@ void IPARPi::prepareISP(const ISPConfig &data)\n \t\t * in helper_->Prepare().\n \t\t */\n \t\tRPiController::Metadata &lastMetadata =\n-\t\t\trpiMetadata_[ipaContext ? ipaContext : rpiMetadata_.size()];\n+\t\t\trpiMetadata_[(ipaContext ? ipaContext : rpiMetadata_.size()) - 1];\n \t\trpiMetadata.mergeCopy(lastMetadata);\n \t\tprocessPending_ = false;\n \t\treturn;\n","prefixes":["libcamera-devel"]}