{"id":17898,"url":"https://patchwork.libcamera.org/api/1.1/patches/17898/?format=json","web_url":"https://patchwork.libcamera.org/patch/17898/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221124155314.21332-1-max.schulze@online.de>","date":"2022-11-24T15:53:15","name":"[libcamera-devel] ipa: rpi: print path and version read on config mismatch","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fd6af87c5e116e115f69cdf418bb6fe43878ab78","submitter":{"id":139,"url":"https://patchwork.libcamera.org/api/1.1/people/139/?format=json","name":"Max Schulze","email":"max.schulze@online.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17898/mbox/","series":[{"id":3641,"url":"https://patchwork.libcamera.org/api/1.1/series/3641/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3641","date":"2022-11-24T15:53:15","name":"[libcamera-devel] ipa: rpi: print path and version read on config mismatch","version":1,"mbox":"https://patchwork.libcamera.org/series/3641/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17898/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17898/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A193BE08B\n\tfor ;\n\tThu, 24 Nov 2022 15:53:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 049BD63319;\n\tThu, 24 Nov 2022 16:53:51 +0100 (CET)","from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DD6D6330D\n\tfor ;\n\tThu, 24 Nov 2022 16:53:49 +0100 (CET)","from raspberrypi.fritz.box ([84.160.56.77]) by\n\tmrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA\n\t(Nemesis)\n\tid 1M27ix-1ovlZN304f-002Y4G; Thu, 24 Nov 2022 16:53:48 +0100"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669305231;\n\tbh=sfFvGE11+iuy0egk9oEWahbW8749aGgqYy6pOcUucMs=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=DlR8iD0wYBIRc9xHvm0PxY0ri+oGWD6kaON5vi+3O+HytxlReF9s1UjvfBtKyOJ6g\n\tpgGuim9Q5zuCP92S9tfzy8CaS8aZFCP0sVZ3YDy50f4lz29fmS7iQg3ktfUI8YpiiM\n\tkbx04gYjE3mxMmahhZEjxxN2tZnMLH6aYKMp4P4V42D+P5rIbxA2rDcZ4+rCwzt1Fn\n\tSbdn3U1wZHMll5Ey9Ek/mi2NHVAvUAW7rBsqoQ97Xy7hym97PhvtdWycKBBS8iTVkR\n\toONlqjkRFicSoWM+ydJp/DJaZxlwkeNSWExa+iiX/vrsABgEtJKo4jBophmH8ucR1k\n\t01YoLg4iW8fpQ==","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 24 Nov 2022 16:53:15 +0100","Message-Id":"<20221124155314.21332-1-max.schulze@online.de>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Provags-ID":"V03:K1:hClnlmyORnyMkc76RJfqcG9G4H76lVX+fJVYsgbQEuQbVwLKu1n\n\tlTk+/vKa10quplh3qzWzqABGMXx+erq28tg8K+KtUxRz9U4XPs8Ow6iRKl7nhqz4ChFJkqb\n\t1GEmEdn9f+oO4nKXFLBhbAk4PN1t15lJRl03MEfRvRL5bFxd1LkG9ZrR08ee4ChDMSqJiRI\n\tUSgTMPHN03pjIef54nLPw==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:lzsupu2IEOM=:E+fbLUQa0pi0b/OCQlC2p4\n\tvqT3SJhD/pjYMSReupHWmqXTSQmnTVNHb1DkpRmrxubUg9VlovCHkaiDYvphQW/PhZCLu/cur\n\tyYEltBvgAe9EpxzDWaatOvlWEVuHmDzLJruvcXlon3OSfnyn/JD7qhooNP4ueThEySbXW4SBi\n\tFa3FPtytmck45NdD8JVnOXO1Mo258uDQLwjOuChW6Augwa+3fuLAf6a5XcMsYclKGWPl7oLu2\n\t547X57BK/kuVR/FivCB1AyrVB8owNm4sxt/6aHV9VBpSg6fq1nLFQk1eDgG7tjKKIuCK7dQDm\n\tOxGWgkFe0Dd6nKhijXxiWNg5h5sNTxnW/UaIjrw0fiGKCRWeOqwkf2AYptYl+HnrocI6tFeuC\n\tKbO5ZcI3ulKQWRsC6G+jXkyrUWy5/Iv3whUTpW4NyETyzWTaiMV/XdlRcJZ4UA5lQSnFvBYy9\n\tbXpPe/rZpNSJTpE4ivSiAvNXKtf2V2SRYi5h+/jAlUzn6p1KFx1OvjGdLHC2IImQ4ksjixAml\n\tTjJdVjN6ABYySRNJuZSvxZTUy9yJDNjvfNMidam3453H+SAyTdAxn9DqodHEg5Pcpi5hjcluv\n\tmt3tZIfdWmxyDAT5o8zGqCMVzJz3PWRI/HStGEHnhvw8brTD4dYDxSwZ2Qpy9790CQ0lbh/+M\n\tLzaxDomSvqant2etCgffOPhXijzgvIJ7hyy6jVqPe82ejDYFXStgMdfe9o3F3NZvf8s8lPOJJ\n\toDJ8ffjEnOR/GkAjVml9AAefwSqCZg7Gz72ng6v5it6wM75qfWEoBRF6WREdqlhz9f5Uan2hR\n\t5FE4Hy+","Subject":"[libcamera-devel] [PATCH] ipa: rpi: print path and version read on\n\tconfig mismatch","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Max Schulze via libcamera-devel ","Reply-To":"Max Schulze ","Cc":"Max Schulze ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the version is not what we expect, it is way helpful to\nnote the file where it happened and which version was effectively read\n(i.e. to rule out conversion errors...)\n\nSigned-off-by: Max Schulze \n---\n src/ipa/raspberrypi/controller/controller.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/controller.cpp b/src/ipa/raspberrypi/controller/controller.cpp\nindex e9156785..3f09ea92 100644\n--- a/src/ipa/raspberrypi/controller/controller.cpp\n+++ b/src/ipa/raspberrypi/controller/controller.cpp\n@@ -41,7 +41,9 @@ int Controller::read(char const *filename)\n \n \tif (version < 2.0) {\n \t\tLOG(RPiController, Warning)\n-\t\t\t<< \"This format of the tuning file will be deprecated soon!\"\n+\t\t\t<< \"This format of the tuning file \" << filename\n+\t\t\t<< \" will be deprecated soon! \\n\"\n+\t\t\t<< \" Read version \" << (*root)[\"version\"].get(\"\")\n \t\t\t<< \" Please use the convert_tuning.py utility to update to version 2.0.\";\n \n \t\tfor (auto const &[key, value] : root->asDict()) {\n","prefixes":["libcamera-devel"]}