{"id":17864,"url":"https://patchwork.libcamera.org/api/1.1/patches/17864/?format=json","web_url":"https://patchwork.libcamera.org/patch/17864/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221124103832.6172-4-naush@raspberrypi.com>","date":"2022-11-24T10:38:30","name":"[libcamera-devel,v2,3/5] ipa: raspberrypi: awb: Delay release of the statistics buffer","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bfeaf5625c13acb70d2cf68ebd0eaf6be7f73509","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17864/mbox/","series":[{"id":3635,"url":"https://patchwork.libcamera.org/api/1.1/series/3635/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3635","date":"2022-11-24T10:38:27","name":"Raspberry Pi: Generalise statistics","version":2,"mbox":"https://patchwork.libcamera.org/series/3635/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17864/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17864/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D63F5C3286\n\tfor ;\n\tThu, 24 Nov 2022 10:38:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B80D06331B;\n\tThu, 24 Nov 2022 11:38:44 +0100 (CET)","from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 478E663316\n\tfor ;\n\tThu, 24 Nov 2022 11:38:42 +0100 (CET)","by mail-wr1-x42a.google.com with SMTP id n7so1819974wrr.13\n\tfor ;\n\tThu, 24 Nov 2022 02:38:42 -0800 (PST)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\ts16-20020adff810000000b002368a6deaf8sm995103wrp.57.2022.11.24.02.38.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 24 Nov 2022 02:38:41 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669286324;\n\tbh=/5KjD6c/IL+fXydsKOzb9YnlaccYxgItMGrGOcqLFgc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=1ObkNSMDWXDqWYMUhl/+mqX/StKj3tjh0SPTgA05ONDaH8ZFDWt0cpUzvxVPk10Hl\n\tXLGiFa/feMPO+mTasRSEos9cZB7QwpRLNtwKqn2ZqgCTqeWI11crcg3fMVi6D5wBU/\n\tyAgmq+A9OZ05jdoovG8x8YwEwdo82ykN41d5R/rzjG3McmwNYQoPhUW+CNJpJWNNsd\n\trUcO/mYCcs4AmEmrlu/+id1Z73ofA60uK1/rbzRRqycjR0yCP1m95FlNCAmLYHdwSZ\n\t0JTgL19BPhdZnEFRKwjd21KWYmUY+AYChmnur1+HgKIcIbKRl3R/UmG7Xk/Nn0LRDu\n\tgEkjVvsW81X3w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=raGM6H8WE6ZOibbytcLb47YD73g9Kdg0YHaASybQJqg=;\n\tb=A0EqnhyrEMpdzklSN1K7/Xm6Xc7qluzQEu8NmC7OMJZXBGR/b0x1ZzZWAenRI/2i9N\n\tRpj/96RavfG++RlJfXmevu7LM/OM+lSdtqrvMLrKY/OCTxXLxl0shjm53Cw3VvuJvYTT\n\t/aKsnFJGX4DrWeYCsw2titWC4LA2eZzh93eRl0luAsD0+gXj76JG1GNPyYoOu7CverGf\n\t+QYgS6+iq2DZQFa+6Z0rKv7oCyvHcVr8h1N/Vntx22ulbX1pCq7ynUPOq0YG2f8DZqrC\n\tqWSwtZQ3hrPczCOvnvnSH01En0DlifRVPXBY9u4eIRoFi+3Vi1q5tn9sTNV/Ols3x6JK\n\trCoQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"A0Eqnhyr\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=raGM6H8WE6ZOibbytcLb47YD73g9Kdg0YHaASybQJqg=;\n\tb=Rgj2eID3fsVuuNFyk+OovUbCVn0l3cG3LInZIqkcsYcORzx983F7TcJu5/pmq18iXm\n\t1qov2RF29Bn14RLNVeHpY9rnZ1nSAMv0LZ5HR37uChrKKwZ6tSxtJMOiObV2g26Y19vO\n\tvUHTf016/S62zCbSuwEO1DVMM7fQf0UiHJ5VCWr1PsCrXhqclYt2PHIaQm9MtTTiN4ap\n\t887INGp/Op8eHcUbkNc3t9EOoCu9c2k74BAkWuF8Lw9UFArs5VzOsy9m2J7Cv9Z45Zvp\n\t0wAt4kMKWYrC+4GXcdom+O5UfXA5jGFuBbzgK79ZmydKKM7shLDxvr3YVHXNS8pLAHpP\n\tlxeg==","X-Gm-Message-State":"ANoB5pkZgh/pCzQYcdb88nOjNPP6Zs4+9udsnL6qVayFvN/1acciV4GR\n\t/wwlBiOmYO+7wg138vomMWZEGTk0pVxwKg==","X-Google-Smtp-Source":"AA0mqf7k/Uvk5SeJ1ceMN5chg0dhgos+H8JvrD2DBdpG+dHP7+OfQB5Jh0I7cQg6voLZK85Hd2n3ww==","X-Received":"by 2002:a5d:5684:0:b0:236:61bb:c79d with SMTP id\n\tf4-20020a5d5684000000b0023661bbc79dmr19347079wrv.632.1669286321700; \n\tThu, 24 Nov 2022 02:38:41 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 24 Nov 2022 10:38:30 +0000","Message-Id":"<20221124103832.6172-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20221124103832.6172-1-naush@raspberrypi.com>","References":"<20221124103832.6172-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 3/5] ipa: raspberrypi: awb: Delay\n\trelease of the statistics buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Release the statistics buffer after running the through the AWB calculations.\nOnly the \"counted\" statistics are copied out to a local structure, so keeping\nthe statistics buffer allows the algorithm to see the \"uncounted\" statistics as\nwell.\n\nThis is currently handled by hard-coding the total number of statistics regions\nregions based on the structure definition in the bcm2835_isp_stats structure.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \n---\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\nindex 8d8ddf0913f7..861022014896 100644\n--- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n@@ -432,11 +432,6 @@ void Awb::prepareStats()\n \t */\n \tgenerateStats(zones_, statistics_->awb_stats, config_.minPixels,\n \t\t config_.minG);\n-\t/*\n-\t * we're done with these; we may as well relinquish our hold on the\n-\t * pointer.\n-\t */\n-\tstatistics_.reset();\n \t/*\n \t * apply sensitivities, so values appear to come from our \"canonical\"\n \t * sensor.\n@@ -733,6 +728,11 @@ void Awb::doAwb()\n \t\t\t<< \" with gains r \" << asyncResults_.gainR\n \t\t\t<< \" and b \" << asyncResults_.gainB;\n \t}\n+\t/*\n+\t * we're done with these; we may as well relinquish our hold on the\n+\t * pointer.\n+\t */\n+\tstatistics_.reset();\n }\n \n /* Register algorithm with the system. */\n","prefixes":["libcamera-devel","v2","3/5"]}