{"id":17840,"url":"https://patchwork.libcamera.org/api/1.1/patches/17840/?format=json","web_url":"https://patchwork.libcamera.org/patch/17840/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221122120343.4825-3-david.plowman@raspberrypi.com>","date":"2022-11-22T12:03:42","name":"[libcamera-devel,2/3] libcamera: pipeline: rkisp1: Reset sensor HBLANK control","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cfeb6f4548551c4bc92f1bec337cde4fa0694180","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17840/mbox/","series":[{"id":3629,"url":"https://patchwork.libcamera.org/api/1.1/series/3629/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3629","date":"2022-11-22T12:03:40","name":"Resolve invalid attempt to set sensor HBLANK control","version":1,"mbox":"https://patchwork.libcamera.org/series/3629/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17840/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17840/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 832D6BE08B\n\tfor ;\n\tTue, 22 Nov 2022 12:03:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C258B6331D;\n\tTue, 22 Nov 2022 13:03:52 +0100 (CET)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3133363314\n\tfor ;\n\tTue, 22 Nov 2022 13:03:51 +0100 (CET)","by mail-wm1-x333.google.com with SMTP id\n\tl39-20020a05600c1d2700b003cf93c8156dso11102565wms.4\n\tfor ;\n\tTue, 22 Nov 2022 04:03:51 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tp18-20020adfe612000000b002366a624bd4sm12119141wrm.28.2022.11.22.04.03.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Nov 2022 04:03:49 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669118632;\n\tbh=G8frbkZVyMaSX9UYgeVvPpdfKXAc2FdySpJjfQpPuxE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xX0bhW4TfhBF7xsUlcPcWj02CvaixHlxR3qUVnsa9c/Qp9VlLLmgW2jGDLyG6JxhZ\n\tRZDG3vNvi5WLjmvWh3Djft8ove6W141+/uyv/ZhqINYkbqa+Ffx5HK6bWJOA3FyouG\n\tkDXUi1+kZi8KLPi+YRVMPdzvu17kYLblrdHFWka8CyBZYiQhQNX1jxtR9J6DwzK59g\n\tQtAQ12gsvUpiCg0WhtU5Nki6RQwOY3pSh2yCu4HcQriEgxik8VNVhAvlgZxgc30Z3K\n\tsm/ycrcdtNiHJdepC5L9fyqoYqi4DQ9C5zoiGe9EZS5OUDf3l5LBlUYBYrHdxg/A84\n\t8yMhvhh5QImfA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=K9hGY02j4oY0BOoVT4ZMtV3lThC8jKwGnVMrWOiWI24=;\n\tb=INqJK4iA7Nk825hrmgVGDW3REsF0fVGcrR2ELMdekCgRPXRdUBJptBfIYgjAdKEkY2\n\tkQ0DhvIS4AFTUHBPUiHKctj5WBc7AFnnVMc2R35yqshDYE9KFvQJwGpnk7JqsJ+Ebaow\n\tyQP72xXUygPUkkItZikskPSEhnui9CsODB3Vv5uAcEUuHpRZeVddBCKaaX43lPeNT1mT\n\tBwVjfIgMS9tP+m2kH8XoPxdpSJBWSKhIYjzMiOS7K7SBwkNM8WWvTBQFmfw8YVj6CZb2\n\t/2Fnihg7+b/3fTOth5urxUnhxTHmDkp+lXaS9k/Z8ZivgjBDlkuVIk12b0A8vIHJFBKu\n\tuzAg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"INqJK4iA\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=K9hGY02j4oY0BOoVT4ZMtV3lThC8jKwGnVMrWOiWI24=;\n\tb=DOozPFGIfqUR5wZWE6zTWnJOzDkFM/cOnyjWnX56Ay6tyrO2ov9iKo8cnH4X6R9nWK\n\tJNeN32P0gu/P03zIVjGCb1VdurG/ijWZIOaWPI+AD9n8LHzX5FMj3Ef4Ww7Yd8HdXKWL\n\t7kr90PevZl/8mve0ppD+XuClUKbyC8/raBvfCtcY28gj4jpkj4tAJmLzvq7HJzRorCCr\n\tT29xMos7DWXBzCvSqfys6DL8R+A8hlBitm95iiR2P4/U5iubH6bGxtnaK2Yc3WFOJCI4\n\ttn9N9xF2OriiCgfmGekrJElJnBjHGJrQNQneIsy3Y2TOKLaugUuQ470c22uYE4v4HWJz\n\takcg==","X-Gm-Message-State":"ANoB5pnDQJOk6rmCsKBsx7NHuk9kfo+P4O33X3TLpmgh1o/Pt+3LuCI+\n\thQ2OOUHBNaNZxZN6A4NadgEFkBuRyJn4nA==","X-Google-Smtp-Source":"AA0mqf5m19ATH2S5NH5cU1BW2ndJWWjoW80Hd4cLAwomEIcdxarEcwfMf/F6ylb1XkFjZ+sbfQVrpg==","X-Received":"by 2002:a05:600c:46c8:b0:3cf:8896:e1de with SMTP id\n\tq8-20020a05600c46c800b003cf8896e1demr8991976wmo.4.1669118630462; \n\tTue, 22 Nov 2022 04:03:50 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Nov 2022 12:03:42 +0000","Message-Id":"<20221122120343.4825-3-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20221122120343.4825-1-david.plowman@raspberrypi.com>","References":"<20221122120343.4825-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/3] libcamera: pipeline: rkisp1: Reset\n\tsensor HBLANK control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Resetting the sensor's HBLANK to its minimum value is no longer\nperformed for us, so the pipeline handler must call the helper method\nto do it.\n\nSigned-off-by: David Plowman \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 3d3a7086..4163cc27 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -632,6 +632,9 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \tif (ret)\n \t\treturn ret;\n \n+\t/* Reset the horizontal blanking to minimum in case it has changed. */\n+\tsensor->resetHblank();\n+\n \t/*\n \t * Configure the format on the sensor output and propagate it through\n \t * the pipeline.\n","prefixes":["libcamera-devel","2/3"]}