{"id":1779,"url":"https://patchwork.libcamera.org/api/1.1/patches/1779/?format=json","web_url":"https://patchwork.libcamera.org/patch/1779/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190812124642.24287-2-laurent.pinchart@ideasonboard.com>","date":"2019-08-12T12:46:25","name":"[libcamera-devel,01/18] libcamera: object: Make message() method protected","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2ce22b9bbca2f4ce7e5810d56664b58c3856d112","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1779/mbox/","series":[{"id":455,"url":"https://patchwork.libcamera.org/api/1.1/series/455/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=455","date":"2019-08-12T12:46:24","name":"Object & Thread enhancements","version":1,"mbox":"https://patchwork.libcamera.org/series/455/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1779/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1779/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3261460E38\n\tfor ;\n\tMon, 12 Aug 2019 14:46:49 +0200 (CEST)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B379F594\n\tfor ;\n\tMon, 12 Aug 2019 14:46:48 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565614008;\n\tbh=LfgV2vhRtVXJJcIX5MHhgR4vFf2+h2aRWcl99FF73IM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=MpsiwLdpKAtzqTNqGET5qcEThE+J32ZLrsmWETjWrcfwaYHc47qSTauao9SstJHNi\n\tNif2hfSIXpzertv94tPadfjz4Ctt90syOSeAs3ZXPaPuzbLumqOXQG1nQ2EXp9pf1v\n\tWTgFufaKCpEWdlXuMxPTSqIyox846F7Adq9+4NFE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 12 Aug 2019 15:46:25 +0300","Message-Id":"<20190812124642.24287-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190812124642.24287-1-laurent.pinchart@ideasonboard.com>","References":"<20190812124642.24287-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 01/18] libcamera: object: Make message()\n\tmethod protected","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 12 Aug 2019 12:46:49 -0000"},"content":"The message() method shouldn't be called externally (except by a few\nfriend classes), make it protected.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/object.h | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/object.h b/include/libcamera/object.h\nindex 5c251a822d9a..3d08d69a9044 100644\n--- a/include/libcamera/object.h\n+++ b/include/libcamera/object.h\n@@ -26,11 +26,13 @@ public:\n \tvirtual ~Object();\n \n \tvoid postMessage(std::unique_ptr msg);\n-\tvirtual void message(Message *msg);\n \n \tThread *thread() const { return thread_; }\n \tvoid moveToThread(Thread *thread);\n \n+protected:\n+\tvirtual void message(Message *msg);\n+\n private:\n \ttemplate\n \tfriend class Signal;\n","prefixes":["libcamera-devel","01/18"]}