{"id":17769,"url":"https://patchwork.libcamera.org/api/1.1/patches/17769/?format=json","web_url":"https://patchwork.libcamera.org/patch/17769/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221110144556.7858-5-david.plowman@raspberrypi.com>","date":"2022-11-10T14:45:54","name":"[libcamera-devel,4/6] libcamera: pipeline: uvcvideo: Set device's flip controls correctly","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4876a0fa5b079272666da7c14eabf7217542d4c2","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17769/mbox/","series":[{"id":3602,"url":"https://patchwork.libcamera.org/api/1.1/series/3602/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3602","date":"2022-11-10T14:45:50","name":"Resolve invalid attempts to set sensor flip controls","version":1,"mbox":"https://patchwork.libcamera.org/series/3602/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17769/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17769/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAD7CC3285\n\tfor ;\n\tThu, 10 Nov 2022 14:46:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 81FA463095;\n\tThu, 10 Nov 2022 15:46:09 +0100 (CET)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA8D363083\n\tfor ;\n\tThu, 10 Nov 2022 15:46:06 +0100 (CET)","by mail-wm1-x333.google.com with SMTP id\n\tm7-20020a05600c090700b003cf8a105d9eso1281844wmp.5\n\tfor ;\n\tThu, 10 Nov 2022 06:46:06 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tu24-20020a7bc058000000b003b476cabf1csm5249759wmc.26.2022.11.10.06.46.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 10 Nov 2022 06:46:05 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668091569;\n\tbh=e5cWW4cvf5Nxfg5oOAVrMT/Yb+FcJFD5zlWOs2WGIvg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=mVEjDIoJOR7xP70hmJyfY7CFTtdBFcGqaBQiI5a2wEWf4VGC4g9NMjvzaa3mpJyNQ\n\tLJqYIK5FrGovnlQYPoJ//xMFyryGJyOr/9aiWv4fdl9FP2oQR6wgPCVUIqvgWF4KnV\n\tZqD1BpMPmOXBX52aF0MksrK7MCWA7Rrfuhs5Dz5Is1hUvtuH30JY4oBrrBX0lP2EqK\n\thvOoOs2aIBFn5FCiQDaNwBu3bFmqY1m/8cXYLYtrfUYmFqSW9VJSIIDdKmyKutcrlL\n\t/zp1VHVcY6GDEQrVAFT1MVtMKJqmAiruBbCVkAVBHUyPXCEh9BC0Qb2PIM0/DV5rk1\n\t6DbOChuGZSHYg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=WSJzl7kxIvYV64/0iXvdPD4pm/+rRQJ7WgzAhvrgZIE=;\n\tb=eb3ObKIjBxrNa0WVsF94I+v1Ik6ADd1HzjMRkfRvKhvOsXKawZMwNvBAMvwTkGWy6C\n\tC1N8eG/6kUYJR+cNIFowXgX9NTU+uFcjMQliqyDX9md/J02Y1g4UBiVoziSfFyMGyaTX\n\ti3YR+My8lFWYlr6eLJJ4mola/DQv9+VHcQ0063VHlncO4X9gijc9kE2/9GdKv2aoxSoT\n\t6ubRX6yJJoBBz95RwmN7Js6SwT9Z8+GKgZoI+BD7NyV4nD1ja5dVD8gUafE5YWQFimV+\n\tz2bnbjXm2n05Rp2p3DncRFXx6imZw8vbuoEJz2fJsJ4nBTyo84d60LBNj9s3mOb6WZ+5\n\tX9FA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"eb3ObKIj\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=WSJzl7kxIvYV64/0iXvdPD4pm/+rRQJ7WgzAhvrgZIE=;\n\tb=It31/4j0HbjJ9JehdULwAHx+o6M5j6YDNOeXEia44X9C95IkA38F55CnCxzlddMra2\n\tE+tfJZaEgGzwO9yx/0z90EDHOTpfyz3GItmKEaVKLfey7T5O6fGNjOPdZAczbbJVtFmp\n\tCYzb2AfQ+/S33zkLilpQbyV2e28AD4OdwiFNdmK22CZT+UY+fgjdyoI91NcnjhqG1k6N\n\tYtcLuYQMJF1rK4EDMnP+LFKXhHYMfziF/QfGv+MIOW7dyQV/AA1l5v+vTE2UkmF36yj3\n\tVBJcJw4s/nNLFe2Tanu5T9po5gyNZfk75P93lzPpRsmOdxynKBcBhaq0xygGCHn/DCsh\n\t/V/Q==","X-Gm-Message-State":"ACrzQf2vOmuSJk49vTUZE2VhKdJ2r90b9A7HVTGkqXulTX2RXHD0wZ2P\n\tnnedrpDzTGqYErH4SeTq0zfppbyhLzYwmw==","X-Google-Smtp-Source":"AMsMyM71bGGOu5A9NOXlLEPk/OWC3mS9+IswaYvkfB1qhtFZwr2LQ5nKMVuGEPE+I/Hg9K7umpupzw==","X-Received":"by 2002:a05:600c:28ce:b0:3cf:6e78:e335 with SMTP id\n\th14-20020a05600c28ce00b003cf6e78e335mr38288108wmd.142.1668091566136; \n\tThu, 10 Nov 2022 06:46:06 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 10 Nov 2022 14:45:54 +0000","Message-Id":"<20221110144556.7858-5-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20221110144556.7858-1-david.plowman@raspberrypi.com>","References":"<20221110144556.7858-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/6] libcamera: pipeline: uvcvideo: Set\n\tdevice's flip controls correctly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Set the horizontal and vertical flip controls correctly by\ncalling the device's setTransform method now that this no longer\nhappens in CameraSensor::init().\n\nSigned-off-by: David Plowman \n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 277465b7..4a891c23 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -209,6 +209,9 @@ int PipelineHandlerUVC::configure(Camera *camera, CameraConfiguration *config)\n \tStreamConfiguration &cfg = config->at(0);\n \tint ret;\n \n+\t/* Set up the video device's horizontal and vertical flips. */\n+\tdata->video_->setTransform(config->transform);\n+\n \tV4L2DeviceFormat format;\n \tformat.fourcc = data->video_->toV4L2PixelFormat(cfg.pixelFormat);\n \tformat.size = cfg.size;\n","prefixes":["libcamera-devel","4/6"]}