{"id":17706,"url":"https://patchwork.libcamera.org/api/1.1/patches/17706/?format=json","web_url":"https://patchwork.libcamera.org/patch/17706/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221027224135.348115-5-nicholas@rothemail.net>","date":"2022-10-27T22:41:29","name":"[libcamera-devel,v4,04/10] ipa: libcamera: add support for ov8858 sensor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3956f0ba305d7437f2f80ccb601b307e33480587","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/1.1/people/97/?format=json","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17706/mbox/","series":[{"id":3581,"url":"https://patchwork.libcamera.org/api/1.1/series/3581/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3581","date":"2022-10-27T22:41:26","name":"[libcamera-devel,v4,01/10] ipa: workaround libcxx duration limitation","version":4,"mbox":"https://patchwork.libcamera.org/series/3581/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17706/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17706/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7356ABDB16\n\tfor ;\n\tThu, 27 Oct 2022 22:41:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA5C262FC4;\n\tFri, 28 Oct 2022 00:41:50 +0200 (CEST)","from mail-oa1-x34.google.com (mail-oa1-x34.google.com\n\t[IPv6:2001:4860:4864:20::34])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1C4462FA0\n\tfor ;\n\tFri, 28 Oct 2022 00:41:44 +0200 (CEST)","by mail-oa1-x34.google.com with SMTP id\n\t586e51a60fabf-12c8312131fso4315392fac.4\n\tfor ;\n\tThu, 27 Oct 2022 15:41:44 -0700 (PDT)","from nroth-pc.attlocal.net\n\t([2600:1700:20:20c0:6a4b:7aa7:dda2:75cb])\n\tby smtp.gmail.com with ESMTPSA id\n\tr20-20020a056830419400b006619533d1ddsm976825otu.76.2022.10.27.15.41.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 27 Oct 2022 15:41:42 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666910510;\n\tbh=daE6WY54HAjKlN885/mrlKW4bKHReC2Ox9JTDd8H68w=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=y0EVYu0Dl1XWGH8FfZdynSp3kCb6jBHG1ixz1LdRL++U+YObkOU04B+aIQ11pOW5V\n\tckF0N5gOzxrfPT+YDG7pnEBJTjHKoporkzZSJv9X5btwHfMrVde/wQjWqtycre7A2S\n\tj3xWcWTOb48zulxrWO/ibDmy69SZeY65b46GrZffGvxh0K+MRGOJo/djx6qWEnF5V6\n\tFFg24yrNKg15HDDOaK7rKRD99LTpf0XKkpRvHE+joz6YPdViAO1j3lNPKSolm26W7e\n\tnLiveN/0elg17HwsFjv3yIIy0h7N1ItpnXL7Gq9HiNRUsYRUI86/LKmX9ELRGCjQ37\n\t4IbflmcIWHj3g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=Nx/vHY66gELOXMwShEVVfeaHqV/OVGT2Ylh4eoO+CP8=;\n\tb=rVB+ZD6H/Nt57SFsAK95bhsBqgJNZpNTIrIFoKM8fPv5BSCVExWfxzhDxjMHZOYiTP\n\t8cVk9jsCVXo7Oj8A6BjbhOQG2fzZo+IE2luhbA7vWsm67suW5Gyc+XIgGtfpdcsBRsli\n\t+IZ5cGOfdKHiXxk8C7/mpPXSnPkNFO4cq/7k3ranfbakdT36xjtvzec2SZ7u+de2QRg2\n\txozsWXJP2POV7r6lnoM0xsX6VG4/622qtS/605Zdfb786Nugmg7KCbWftMJNg0luF8Ok\n\tmSxsQSGgM+YgyrwhLTbZfEE/xqZDK5sZx//STidyQwA1NjWD1OlNKoyMPQt3VDLFCP+Q\n\tVwxw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"rVB+ZD6H\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=Nx/vHY66gELOXMwShEVVfeaHqV/OVGT2Ylh4eoO+CP8=;\n\tb=BPueyZHSY5k58cjcI4Sj6BaAcXKVX7TIy1fxF8nfbulnUgW+AvOWMcVd5z+RjaBr3r\n\trUYyWnOtbiKAfo3D6g8+W/iswZgrsBrc+/OiwJgFddCisANFO5hSdGGMVp3l3IODWolB\n\t64rfiCoH7KaJp9YoTTHdydvchguox26WFzHEGml0VCGMyiN0UKUp+AArEDcRBS2jeneG\n\tHoE/gvESwvS2rAWI935AV9AmV75MAvSl/6Q1Qbuz9NlESSe99Jr1aDiOS28ugqa+xiWF\n\t3aIRCFtVNTdwNo6uGKcvPYgTB30NbFmSBFnTPc+YAbAEAwunzGIhkvOVEsO9KglZ7gDj\n\tUQoQ==","X-Gm-Message-State":"ACrzQf34ylsivrXPjcP3ukpPy1R8L4rzLusfa3y1fKngozQSwr4ZaH7x\n\tmsjHVeVtP0V4FZnKlmAhF9v8ZuykAATk30xl","X-Google-Smtp-Source":"AMsMyM5wpO2WJUi6LNpnTfgqfE9bfRcVy9pvrHwKX8JhwlYzUxSBohuzFelcNk+sZAEUDb8QUSFWsw==","X-Received":"by 2002:a05:6870:3409:b0:13b:5dee:40d with SMTP id\n\tg9-20020a056870340900b0013b5dee040dmr7173622oah.121.1666910502834; \n\tThu, 27 Oct 2022 15:41:42 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 27 Oct 2022 17:41:29 -0500","Message-Id":"<20221027224135.348115-5-nicholas@rothemail.net>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20221027224135.348115-1-nicholas@rothemail.net>","References":"<20221027224135.348115-1-nicholas@rothemail.net>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 04/10] ipa: libcamera: add support for\n\tov8858 sensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicholas Roth via libcamera-devel ","Reply-To":"libcamera-devel@lists.libcamera.org","Cc":"nicholas@rothemail.net","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Nicholas Roth \n\nCurrently, libcamera does not have information for the ov8858 sensor\nused in the PinePhone Pro, a phone designed to run Linux.\n\nThis commit adds metadata, especially that sensor gain is reported and\nset in 1/16 discrete increments.\n\nFor more information, see \"5.8 manual exposure compensation/ manual\ngain compensation\" in [0] and the driver in [1].\n\n[0] http://www.ahdsensor.com/uploadfile/202008/55322e75316871.pdf\n[1] https://github.com/megous/linux/blob/orange-pi-5.19/drivers/media/i2c/ov8858.c\n\nSigned-off-by: Nicholas Roth \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n src/libcamera/camera_sensor_properties.cpp | 14 ++++++++++++++\n 2 files changed, 25 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 35056bec..f2040cbd 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -476,6 +476,17 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n \n+class CameraSensorHelperOv8858 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperOv8858()\n+\t{\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 1, 0, 0, 16 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"m00_f_ov8858\", CameraSensorHelperOv8858)\n+\n class CameraSensorHelperOv8865 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\nindex e5f27f06..d0757c15 100644\n--- a/src/libcamera/camera_sensor_properties.cpp\n+++ b/src/libcamera/camera_sensor_properties.cpp\n@@ -146,6 +146,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t */\n \t\t\t},\n \t\t} },\n+\t\t{ \"m00_f_ov8858\", {\n+\t\t\t.unitCellSize = { 1200, 1200 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n+\t\t\t\t/*\n+\t\t\t\t * No best corresponding test pattern for:\n+\t\t\t\t * 1: \"Vertical Color Bar Type 1\",\n+\t\t\t\t * 2: \"Vertical Color Bar Type 2\",\n+\t\t\t\t * 3: \"Vertical Color Bar Type 3\",\n+\t\t\t\t * 4: \"Vertical Color Bar Type 4\"\n+\t\t\t\t */\n+\t\t\t},\n+\t\t} },\n \t\t{ \"ov8865\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n \t\t\t.testPatternModes = {\n","prefixes":["libcamera-devel","v4","04/10"]}