{"id":17645,"url":"https://patchwork.libcamera.org/api/1.1/patches/17645/?format=json","web_url":"https://patchwork.libcamera.org/patch/17645/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221019231537.26880-2-laurent.pinchart@ideasonboard.com>","date":"2022-10-19T23:15:32","name":"[libcamera-devel,v1,1/6] cam: Don't print DNG option text if libtiff isn't found","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ce449495797d253dfe2a485286a2aa44f4366581","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17645/mbox/","series":[{"id":3571,"url":"https://patchwork.libcamera.org/api/1.1/series/3571/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3571","date":"2022-10-19T23:15:31","name":"apps: Avoid duplicate compilation of common code","version":1,"mbox":"https://patchwork.libcamera.org/series/3571/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17645/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17645/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C875C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 19 Oct 2022 23:16:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 27A9962E7B;\n\tThu, 20 Oct 2022 01:16:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A52B662E6E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Oct 2022 01:16:04 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 31C8F570\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Oct 2022 01:16:04 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666221367;\n\tbh=oDSDIvv3/JdgM/4wy4c7pNgN9fWMIpipiabTOydjRZM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=qRvq/U0RsJQGvc/WcurgkUwac8CbbQmcA9P0rf6CrORi9bHTPdOjZ48GUtK4W3vcX\n\tLC0Yih4O89lZpfmlNX//rnN3y4HV2mmcKavj8W0QRbFQsJDr/BiLV0YZ4FrRTiso18\n\t52BopYNflSGr2bPZjPkEesZup9GHCjM6IAZcK5AMtsMX/eTIWycHe0xm7ROizlhv+7\n\tITLCWNX4JQ8S1urc97y3LPFyOudLJ1KYrOhvUbxcoP3mQ7Z8DpTr3UEporhr6aqgc0\n\tn7NCBt0vSQQwKYFe/PWGVXys5YmZDQIpq+o/l4xCfX7H5AzuKiCC4ZZrhS637NHpLb\n\twy1Y7r5s9aEJg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666221364;\n\tbh=oDSDIvv3/JdgM/4wy4c7pNgN9fWMIpipiabTOydjRZM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=putWmlPhDg0ir4EVj7arN+3ZinsChZBE94j3vjQo4s9A3zCvfowVCDy+F0yi8af5k\n\tYLdmB7F4JIf9B26Jc3LmniES+V72Lor+OYVa5kjKb8m7hX+efm4gj/RK8lKVVsshYX\n\tGolAwuVJa7J0PCipEaqPVLD8u+PAXSI5Gc844yh4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"putWmlPh\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 20 Oct 2022 02:15:32 +0300","Message-Id":"<20221019231537.26880-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.37.3","In-Reply-To":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 1/6] cam: Don't print DNG option text\n\tif libtiff isn't found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"If libtiff isn't found, DNG capture support is disabled. Don't print the\npart of the --file help text that mentions DNG in that case.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/main.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex c4e18a130c02..d70130e2ab81 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -144,8 +144,10 @@ int CamApp::parseOptions(int argc, char *argv[])\n \t\t\t \"to write files, using the default file name. Otherwise it sets the\\n\"\n \t\t\t \"full file path and name. The first '#' character in the file name\\n\"\n \t\t\t \"is expanded to the camera index, stream name and frame sequence number.\\n\"\n+#ifdef HAVE_TIFF\n \t\t\t \"If the file name ends with '.dng', then the frame will be written to\\n\"\n \t\t\t \"the output file(s) in DNG format.\\n\"\n+#endif\n \t\t\t \"The default file name is 'frame-#.bin'.\",\n \t\t\t \"file\", ArgumentOptional, \"filename\", false,\n \t\t\t OptCamera);\n","prefixes":["libcamera-devel","v1","1/6"]}