{"id":17570,"url":"https://patchwork.libcamera.org/api/1.1/patches/17570/?format=json","web_url":"https://patchwork.libcamera.org/patch/17570/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"","date":"2022-10-10T13:45:08","name":"[libcamera-devel] ipa: tweak constant expressions that fail to be determined on ppc64el","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2bc2676a0acb3a667c93d5723e40696c2601b2fc","submitter":{"id":136,"url":"https://patchwork.libcamera.org/api/1.1/people/136/?format=json","name":"Olivier Gayot","email":"olivier.gayot@sigexec.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17570/mbox/","series":[{"id":3548,"url":"https://patchwork.libcamera.org/api/1.1/series/3548/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3548","date":"2022-10-10T13:45:08","name":"[libcamera-devel] ipa: tweak constant expressions that fail to be determined on ppc64el","version":1,"mbox":"https://patchwork.libcamera.org/series/3548/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17570/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17570/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D472BD16B\n\tfor ;\n\tMon, 10 Oct 2022 13:50:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D955162D64;\n\tMon, 10 Oct 2022 15:50:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665409834;\n\tbh=kZFXeAmmFzMVGQ0Crs45f/kFbhtW8GYYO3UpjtoXGHw=;\n\th=To:Date:List-Id:List-Post:From:Cc:List-Subscribe:List-Unsubscribe:\n\tList-Archive:Reply-To:List-Help:Subject:From;\n\tb=E19JyBwpzYdUXi4QtC6H+wBdB0nJo9eydDc9MPleVOP6B6/3wRm79QZhlciw7WrPm\n\tLep32ATyufB7KBxf+VJ4F+0cs7Cp20y2OCzHaCcEWh3K7QGtwphD4kxfvNBw9ULaAE\n\tl1cxXPqy15lqvAqGb3PnZMDxA9zuWX5bbyzR/hoLCWcgSxdHZPzxnlvcp/3huEgf0k\n\teFqht1ZM/K7bG64J7wJGRFSCL7ayMBiMyvm7p9sTep3XG7v4wpl5SZ7bGDIZj8A4Q0\n\tMr+/v6GZr33I+hhL92mZZ1PlOro272sECMrjjkM0pJDOhKsXtHhqkfNgynijmN3rpw\n\tDpT8vdqwES8TA==","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 10 Oct 2022 15:45:08 +0200","X-Mailman-Approved-At":"Mon, 10 Oct 2022 15:50:33 +0200","MIME-Version":"1.0","Message-ID":"","List-Id":"","List-Post":"","From":"Olivier Gayot via libcamera-devel ","Precedence":"list","Cc":"Olivier Gayot ,\n\tOlivier Gayot ","X-Mailman-Version":"2.1.29","X-BeenThere":"libcamera-devel@lists.libcamera.org","List-Subscribe":",\n\t","List-Unsubscribe":",\n\t","List-Archive":"","Reply-To":"olivier.gayot@canonical.com","List-Help":"","Subject":"[libcamera-devel] [PATCH] ipa: tweak constant expressions that fail\n\tto be determined on ppc64el","Content-Type":"message/rfc822","Content-Disposition":"inline","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Olivier Gayot \n\nOn ppc64el, GCC fails to determine the result of some long double\nexpressions at compile time. This makes libcamera fail to build with GCC\non that architecture.\n\ne.g.:\n\nconstexpr auto x = 1.0l/30.0;\n\nin ‘constexpr’ expansion of ‘std::chrono::operator/,\n double>(std::literals::chrono_literals::operator\"\"s(1.0e+0l), 6.0e+1)’\n/usr/include/c++/11/chrono:710:39: error: ‘(1.0e+0l / 6.0e+1)’ is not a constant expression\n 710 | return __cd(__cd(__d).count() / __s);\n\nTweaking the expressions just a bit makes GCC happy and allows libcamera\nto build properly on ppc64el.\n\nSigned-off-by: Olivier Gayot \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 14b06a4f..3e4383f9 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -60,7 +60,7 @@ using utils::Duration;\n /* Configure the sensor with these values initially. */\n constexpr double defaultAnalogueGain = 1.0;\n constexpr Duration defaultExposureTime = 20.0ms;\n-constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n+constexpr Duration defaultMinFrameDuration = 1s / 30.0;\n constexpr Duration defaultMaxFrameDuration = 250.0s;\n \n /*\n@@ -69,7 +69,7 @@ constexpr Duration defaultMaxFrameDuration = 250.0s;\n * we rate-limit the controller Prepare() and Process() calls to lower than or\n * equal to this rate.\n */\n-constexpr Duration controllerMinFrameDuration = 1.0s / 30.0;\n+constexpr Duration controllerMinFrameDuration = 1s / 30.0;\n \n /* List of controls handled by the Raspberry Pi IPA */\n static const ControlInfoMap::Map ipaControls{\n","prefixes":["libcamera-devel"]}