{"id":17512,"url":"https://patchwork.libcamera.org/api/1.1/patches/17512/?format=json","web_url":"https://patchwork.libcamera.org/patch/17512/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221003212128.32429-3-laurent.pinchart@ideasonboard.com>","date":"2022-10-03T21:21:22","name":"[libcamera-devel,2/8] ipa: camera_sensor_helper: Make registerType() and createInstance() private","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9194fdc720b74eeaedbead0add26897e3a6038ff","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17512/mbox/","series":[{"id":3528,"url":"https://patchwork.libcamera.org/api/1.1/series/3528/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3528","date":"2022-10-03T21:21:20","name":"libcamera: Use class templates for auto-registration","version":1,"mbox":"https://patchwork.libcamera.org/series/3528/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17512/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17512/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DFA07C3285\n\tfor ;\n\tMon, 3 Oct 2022 21:21:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E03F601CD;\n\tMon, 3 Oct 2022 23:21:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB5AB601C8\n\tfor ;\n\tMon, 3 Oct 2022 23:21:34 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57016519\n\tfor ;\n\tMon, 3 Oct 2022 23:21:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664832096;\n\tbh=KvqcdANCeqMf88XLPLtbLZi/p5eiyr6xbGwNV6d227I=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ovdgyiVS16NfksNO3hhUxeQBKpJNsVqis9uOR9c65Ko4oejjrWPHuTfj5glAaOCsP\n\tnRm47Cyk7YFQXRmhS4eYtb/JvqYixK6F/crA+sXh7AKb8+6MXl3q1i+66MW3LJUD+7\n\tS+Jf51wdxbkFIabdk+WFKxLWRZlJWBnETWvo0ZB8UucPn0Dmh7TwvGWPeVxuYGP31g\n\t2500dVDMXJdr7JjCGmckZyFWgnIRbSmsO+OrLSCJ09O+TvoPKFVTWrcGLVG4y5hGFc\n\tMaW024UKSqFt66a9UNComrMMrup4MVbyedV4SAc1k1s2aOxF4ilV5A7ASTNu11jwt1\n\tjVcw6cGLloZDg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664832094;\n\tbh=KvqcdANCeqMf88XLPLtbLZi/p5eiyr6xbGwNV6d227I=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=qJ7Qlysf9+4+F79lmznrGvuKthiKPuT+k02uONEtiw98DcPY8eOdqs/6juKWD+RZ3\n\tY1306Agy4DZHktTSBHREAIhoNRU6xIaCWEZBfDgbQkysGwUSZl+o1fKyX3zIo0EWqu\n\tUxpg/FigNnQvqdptx1zXKI88PnkAK3PBjLGARylk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qJ7Qlysf\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 4 Oct 2022 00:21:22 +0300","Message-Id":"<20221003212128.32429-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20221003212128.32429-1-laurent.pinchart@ideasonboard.com>","References":"<20221003212128.32429-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/8] ipa: camera_sensor_helper: Make\n\tregisterType() and createInstance() private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CameraSensorHelperFactory registerType() and createInstance()\nfunctions are called by the CameraSensorHelperFactory class only. Make\nthem private.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/libipa/camera_sensor_helper.h | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\nindex 2042847f29e8..410156efb2ea 100644\n--- a/src/ipa/libipa/camera_sensor_helper.h\n+++ b/src/ipa/libipa/camera_sensor_helper.h\n@@ -66,15 +66,15 @@ public:\n \n \tstatic std::unique_ptr create(const std::string &name);\n \n-\tstatic void registerType(CameraSensorHelperFactory *factory);\n \tstatic std::vector &factories();\n \n-protected:\n-\tvirtual CameraSensorHelper *createInstance() const = 0;\n-\n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactory)\n \n+\tstatic void registerType(CameraSensorHelperFactory *factory);\n+\n+\tvirtual CameraSensorHelper *createInstance() const = 0;\n+\n \tstd::string name_;\n };\n \n","prefixes":["libcamera-devel","2/8"]}