{"id":17473,"url":"https://patchwork.libcamera.org/api/1.1/patches/17473/?format=json","web_url":"https://patchwork.libcamera.org/patch/17473/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220930165731.9063-1-laurent.pinchart@ideasonboard.com>","date":"2022-09-30T16:57:31","name":"[libcamera-devel] qcam: Fix YUV planar fragment shaders","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7c2083a9a539e5a514a2e76b17b0cbcbe25e08f3","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17473/mbox/","series":[{"id":3518,"url":"https://patchwork.libcamera.org/api/1.1/series/3518/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3518","date":"2022-09-30T16:57:31","name":"[libcamera-devel] qcam: Fix YUV planar fragment shaders","version":1,"mbox":"https://patchwork.libcamera.org/series/3518/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17473/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17473/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F3FEC0DA4\n\tfor ;\n\tFri, 30 Sep 2022 16:57:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8753662839;\n\tFri, 30 Sep 2022 18:57:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7971261FB1\n\tfor ;\n\tFri, 30 Sep 2022 18:57:33 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C5F4047C;\n\tFri, 30 Sep 2022 18:57:32 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664557055;\n\tbh=PZ+X8hHJsRFoazT2JkWoL7CfMvFzoXwDzH5ePzmNAB0=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=JvQZbQKW/CaJBVfCKbwPi9iNftTZAjmnHwkfbQxk0S2I+1xH7I7H1hyhXcX1YrM43\n\tFuVjO0VLTbi0E4PwnVvbnzUQTBiHKIuaDqbmyTh5KB29xz0FfrCKQUd1qcjQyoZEji\n\tDS2kVHrVbxzGbUwbpSSi/ZD1TvanUpO67ZTAvbtW2nJIMIUc1+1UdlTcb6q2N6/iAS\n\t0r7IKjCT8kUYbdCznpBcZ2+5G9uBj7InSC2XSyMigW28mDft7GvpNLC81cj3iEPwMj\n\tre9pQB/KiFhXAvZwlt4PqAMkLadZChR32BASkyBB/CxX5lXsCrrUirB2mJw/k5o1tk\n\t8hcoBziSHvBjQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664557053;\n\tbh=PZ+X8hHJsRFoazT2JkWoL7CfMvFzoXwDzH5ePzmNAB0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=VN3bFtme2Jvcr+vy7Bn2BYqYwQgiGH5B7WwISeHQoiGsjfpFc7JsO+FlGu79UIPul\n\tLip0W8ov3+uvLUa+VjYvnIitUxkqcT1b36cZIcqAybNLWk++m98Icrkgpe+waBj03g\n\tP4ymwQ6cXcS9a28gRB0LD6WaaxR7++uYTGQ3k60E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VN3bFtme\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Sep 2022 19:57:31 +0300","Message-Id":"<20220930165731.9063-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] qcam: Fix YUV planar fragment shaders","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Commit 251f0534b74b (\"qcam: viewfinder_gl: Take color space into account\nfor YUV rendering\") introduced compilation failures in the YUV\nsemi-planar and planar fragment shaders due to a bad copy & paste. Fix\nit.\n\nFixes: 251f0534b74b (\"qcam: viewfinder_gl: Take color space into account for YUV rendering\")\nReported-by: Kieran Bingham \nSigned-off-by: Laurent Pinchart \n---\nKieran,\n\nThis should fix the issue you have reported. I haven't tested the patch\nyet, could you give it a try ?\n---\n src/qcam/assets/shader/YUV_2_planes.frag | 2 +-\n src/qcam/assets/shader/YUV_3_planes.frag | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/qcam/assets/shader/YUV_2_planes.frag b/src/qcam/assets/shader/YUV_2_planes.frag\nindex da8dbcc5f801..1d5d1206248f 100644\n--- a/src/qcam/assets/shader/YUV_2_planes.frag\n+++ b/src/qcam/assets/shader/YUV_2_planes.frag\n@@ -36,7 +36,7 @@ void main(void)\n #error Invalid pattern\n #endif\n \n-\tvec3 rgb = yuv2rgb_matrix * (vec3(y, uv) - yuv2rgb_offset);\n+\tvec3 rgb = yuv2rgb_matrix * (yuv - yuv2rgb_offset);\n \n \tgl_FragColor = vec4(rgb, 1.0);\n }\ndiff --git a/src/qcam/assets/shader/YUV_3_planes.frag b/src/qcam/assets/shader/YUV_3_planes.frag\nindex e754129d74d1..8f788e90a6f8 100644\n--- a/src/qcam/assets/shader/YUV_3_planes.frag\n+++ b/src/qcam/assets/shader/YUV_3_planes.frag\n@@ -30,7 +30,7 @@ void main(void)\n \tyuv.y = texture2D(tex_u, textureOut).r;\n \tyuv.z = texture2D(tex_v, textureOut).r;\n \n-\tvec3 rgb = yuv2rgb_matrix * (vec3(y, uv) - yuv2rgb_offset);\n+\tvec3 rgb = yuv2rgb_matrix * (yuv - yuv2rgb_offset);\n \n \tgl_FragColor = vec4(rgb, 1.0);\n }\n","prefixes":["libcamera-devel"]}