{"id":17341,"url":"https://patchwork.libcamera.org/api/1.1/patches/17341/?format=json","web_url":"https://patchwork.libcamera.org/patch/17341/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220908014200.28728-33-laurent.pinchart@ideasonboard.com>","date":"2022-09-08T01:42:00","name":"[libcamera-devel,v4,32/32] ipa: rkisp1: awb: Remove bias from gain calculation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1145d773a9f91aa5186f0c013601822040ae4849","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17341/mbox/","series":[{"id":3476,"url":"https://patchwork.libcamera.org/api/1.1/series/3476/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3476","date":"2022-09-08T01:41:28","name":"ipa: Frame context queue, IPU3 & RkISP consolidation, and RkISP1 improvements","version":4,"mbox":"https://patchwork.libcamera.org/series/3476/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17341/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17341/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C46CC327D\n\tfor ;\n\tThu, 8 Sep 2022 01:43:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13C686209D;\n\tThu, 8 Sep 2022 03:43:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6D436209D\n\tfor ;\n\tThu, 8 Sep 2022 03:43:02 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 73246888\n\tfor ;\n\tThu, 8 Sep 2022 03:43:02 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662601384;\n\tbh=cxjIAz7fxkLpqHRIBc5gwql1/d+wyi2dDUmV7Xjien8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=h/zTC3nfok7fB02mjWg4X83b+DPn01Pxm1UqCZC7AxaxE/9/GNfDDoCYNDVCXERks\n\tEcEfnPAuvASp2h58yQqmRzvCHbd0QijdCARg169vs0BilDRJakM4kHjAieGiOEwsA5\n\tNtKoL12Fch7EQlHmQ5tbzT7wNdQyPShT9vmnVHEd59E3Ob+3hh9lPYt8epTzJZpNrp\n\tColAFGHsooVtzZ1ViCjIOKV5XoFY7Nzhs4GgMqXaqVz6Ic7yVt4EYDooQ5bx9utb4C\n\tTv9yLkkHwEU0S6eebivdZY0GTz6f12OEkTaW1BPTMpK4KKZeee9kKfKZhVyeCv89VD\n\t8CjR858M3TdpA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662601382;\n\tbh=cxjIAz7fxkLpqHRIBc5gwql1/d+wyi2dDUmV7Xjien8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=sdB8TXB0VjoPe7zLwH1FirGynywDyi6rI489+Z3AIRJTGld05bsgRjC/kuFDsCEae\n\tG3AQ20QroDV1YwZcVAbI+97zIMDo1hgC4ceaVdyUIYr3nguAmfVYztjX96ioeM7cbD\n\tiC9oi18eDMHb2gx4zAPU6Lfwo5NZ9XdOpcnL0os4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"sdB8TXB0\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 8 Sep 2022 04:42:00 +0300","Message-Id":"<20220908014200.28728-33-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 32/32] ipa: rkisp1: awb: Remove bias\n\tfrom gain calculation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The red and blue gains are computed by dividing the green mean by the\nred and blue means respectively. An offset of 1 is added to the dividers\nto avoid divisions by zero. This introduces a bias in the gain values.\nFix it by clamping the divisors to a minimum of 1.0 instead of adding an\noffset.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/algorithms/awb.cpp | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 404ad66e6953..fe1ba09a99a2 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -280,10 +280,11 @@ void Awb::process(IPAContext &context,\n \n \t/*\n \t * Estimate the red and blue gains to apply in a grey world. The green\n-\t * gain is hardcoded to 0.\n+\t * gain is hardcoded to 0. Avoid divisions by zero by clamping the\n+\t * divisor to a minimum value of 1.0.\n \t */\n-\tdouble redGain = greenMean / (redMean + 1);\n-\tdouble blueGain = greenMean / (blueMean + 1);\n+\tdouble redGain = greenMean / std::max(redMean, 1.0);\n+\tdouble blueGain = greenMean / std::max(blueMean, 1.0);\n \n \t/*\n \t * Clamp the gain values to the hardware, which expresses gains as Q2.8\n","prefixes":["libcamera-devel","v4","32/32"]}