{"id":17314,"url":"https://patchwork.libcamera.org/api/1.1/patches/17314/?format=json","web_url":"https://patchwork.libcamera.org/patch/17314/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220908014200.28728-6-laurent.pinchart@ideasonboard.com>","date":"2022-09-08T01:41:33","name":"[libcamera-devel,v4,05/32] ipa: libipa: Provide a common base for frame contexts","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f346b4a697dea4bf7b59f01e9875b41d0bc61edd","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17314/mbox/","series":[{"id":3476,"url":"https://patchwork.libcamera.org/api/1.1/series/3476/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3476","date":"2022-09-08T01:41:28","name":"ipa: Frame context queue, IPU3 & RkISP consolidation, and RkISP1 improvements","version":4,"mbox":"https://patchwork.libcamera.org/series/3476/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17314/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17314/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C46DAC327D\n\tfor ;\n\tThu, 8 Sep 2022 01:42:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89910620A8;\n\tThu, 8 Sep 2022 03:42:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7D0A6209E\n\tfor ;\n\tThu, 8 Sep 2022 03:42:24 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 300D7888;\n\tThu, 8 Sep 2022 03:42:24 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662601346;\n\tbh=XHI/YYMDnKXaWp7Try6x/5ydzAneF2irlbrDSiVsVL0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=hlYjlbR5o0jODCWnszneRehcNpznXk+n7TTG4a2a9Bg6c0xmAskvBjd3pTwi/x1ig\n\tLNGdHUqhIDWwNLm0bynIQt83HNp+tS6CPJdWl3y+7c+kAaBhnXM5hIABekQStyuQiF\n\tw5WeZq4GdXTsO/6ANV/u5+L3gjdasnaIcIXQpcd+Z/xMHJuGHMQFAkBAJ2ZAHly0lO\n\ty5qaCpGXlc4wUtX+hUdhGS1TojDodV6uBobz5xwrsZ/Rd+mZSwX1ltMSjh5jfxHZw2\n\tjI1iX7CKB50KDrGWCPyn9VESP2p2SB6x7SmCONF2rwZPIFlrjg+zjgcis6SjS05Fxk\n\tmiJK9651+VgZw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662601344;\n\tbh=XHI/YYMDnKXaWp7Try6x/5ydzAneF2irlbrDSiVsVL0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sZ9xvGncsKHVhJgW7XllurqbUAZNaarWZjRZXaADj9ttgM5N9ujWCOSDo9hBmy4lQ\n\tsEqE9FarL7058rtjp4zV6a4JaDDM7wJ0/zYDwmCk4IXaX0mgbTRNqdJeXgM1TJafvh\n\tVP208xq42Yi+oA3mPrpEWVdH+U/YNBiwF7bWL3MM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"sZ9xvGnc\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 8 Sep 2022 04:41:33 +0300","Message-Id":"<20220908014200.28728-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 05/32] ipa: libipa: Provide a common\n\tbase for frame contexts","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Kieran Bingham \n\nProvide a common FrameContext as a base for IPA modules to inherit from.\n\nThis will allow having a common set of parameters for every frame\ncontext managed by the FCQueue implementation.\n\nSigned-off-by: Kieran Bingham \n---\nChanges since v3:\n\n- Rename structure from IPAFrameContext to FrameContext\n- Move changes to IPA modules to separate patches\n- Make the FrameContext::frame member private\n---\n src/ipa/libipa/fc_queue.cpp | 18 ++++++++++++++++++\n src/ipa/libipa/fc_queue.h | 10 ++++++++++\n 2 files changed, 28 insertions(+)","diff":"diff --git a/src/ipa/libipa/fc_queue.cpp b/src/ipa/libipa/fc_queue.cpp\nindex b81d497e255a..8f61c85131c9 100644\n--- a/src/ipa/libipa/fc_queue.cpp\n+++ b/src/ipa/libipa/fc_queue.cpp\n@@ -20,6 +20,24 @@ namespace ipa {\n * \\brief Queue to access per-frame Context\n */\n \n+/**\n+ * \\struct FrameContext\n+ * \\brief Context for a frame\n+ *\n+ * The frame context stores data specific to a single frame processed by the\n+ * IPA. Each frame processed by the IPA has a context associated with it,\n+ * accessible through the Frame Context Queue.\n+ *\n+ * Fields in the frame context should reflect values and controls associated\n+ * with the specific frame as requested by the application, and as configured by\n+ * the hardware. Fields can be read by algorithms to determine if they should\n+ * update any specific action for this frame, and finally to update the metadata\n+ * control lists when the frame is fully completed.\n+ *\n+ * \\var FrameContext::frame\n+ * \\brief The frame number\n+ */\n+\n /**\n * \\class FCQueue\n * \\brief A support class for queueing FrameContext instances through the IPA\ndiff --git a/src/ipa/libipa/fc_queue.h b/src/ipa/libipa/fc_queue.h\nindex 0f3af0f3a189..d8a5b8297a70 100644\n--- a/src/ipa/libipa/fc_queue.h\n+++ b/src/ipa/libipa/fc_queue.h\n@@ -8,6 +8,7 @@\n #pragma once\n \n #include \n+#include \n #include \n \n #include \n@@ -18,6 +19,15 @@ LOG_DECLARE_CATEGORY(FCQueue)\n \n namespace ipa {\n \n+template\n+class FCQueue;\n+\n+struct FrameContext {\n+private:\n+\ttemplate friend class FCQueue;\n+\tuint32_t frame;\n+};\n+\n template\n class FCQueue\n {\n","prefixes":["libcamera-devel","v4","05/32"]}