{"id":1731,"url":"https://patchwork.libcamera.org/api/1.1/patches/1731/?format=json","web_url":"https://patchwork.libcamera.org/patch/1731/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190805155133.11335-5-niklas.soderlund@ragnatech.se>","date":"2019-08-05T15:51:33","name":"[libcamera-devel,4/4] tests: camera-sensor: Drop check on media bus format","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"81196937afebfea5cfc60c822d95e17fd5211355","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1731/mbox/","series":[{"id":445,"url":"https://patchwork.libcamera.org/api/1.1/series/445/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=445","date":"2019-08-05T15:51:29","name":"libcamera: Fix issues with vimc and Linux v5.2","version":1,"mbox":"https://patchwork.libcamera.org/series/445/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1731/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1731/checks/","tags":{},"headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76F5961616\n\tfor ;\n\tMon, 5 Aug 2019 17:51:41 +0200 (CEST)","from bismarck.berto.se (unknown [145.14.112.32])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid ea336584-b798-11e9-903a-005056917f90;\n\tMon, 05 Aug 2019 17:51:40 +0200 (CEST)"],"X-Halon-ID":"ea336584-b798-11e9-903a-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 5 Aug 2019 17:51:33 +0200","Message-Id":"<20190805155133.11335-5-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.22.0","In-Reply-To":"<20190805155133.11335-1-niklas.soderlund@ragnatech.se>","References":"<20190805155133.11335-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/4] tests: camera-sensor: Drop check on\n\tmedia bus format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 05 Aug 2019 15:51:41 -0000"},"content":"Linux commit b6c61a6c37317efd (\"media: vimc: propagate pixel format in\nthe stream\") changes the sensor in the vimc media graph to accept any\nmedia bus format set on it. This prevents the camera-sensor test case to\nverify that a supported media bus format is selected.\n\nIn lack of a better fix remove the check for media bus format.\n\nSigned-off-by: Niklas Söderlund \n---\n test/camera-sensor.cpp | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/test/camera-sensor.cpp b/test/camera-sensor.cpp\nindex 092cbdd8111ce70d..a04b7333daecd9dd 100644\n--- a/test/camera-sensor.cpp\n+++ b/test/camera-sensor.cpp\n@@ -87,10 +87,8 @@ protected:\n \t\t\t\t\t\t\t\t MEDIA_BUS_FMT_SBGGR10_1X10,\n \t\t\t\t\t\t\t\t MEDIA_BUS_FMT_BGR888_1X24 },\n \t\t\t\t\t\t\t\tSize(1024, 768));\n-\t\tif (format.mbus_code != MEDIA_BUS_FMT_SBGGR10_1X10 ||\n-\t\t format.size != Size(4096, 2160)) {\n-\t\t\tcerr << \"Failed to get a suitable format, expected 4096x2160-0x\"\n-\t\t\t << std::hex << MEDIA_BUS_FMT_SBGGR10_1X10\n+\t\tif (format.size != Size(4096, 2160)) {\n+\t\t\tcerr << \"Failed to get a suitable format, expected 4096x2160\"\n \t\t\t << \", got \" << format.toString() << endl;\n \t\t\treturn TestFail;\n \t\t}\n","prefixes":["libcamera-devel","4/4"]}