{"id":17293,"url":"https://patchwork.libcamera.org/api/1.1/patches/17293/?format=json","web_url":"https://patchwork.libcamera.org/patch/17293/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220903230643.19284-1-laurent.pinchart@ideasonboard.com>","date":"2022-09-03T23:06:43","name":"[libcamera-devel] libcamera: v4l2_device: Map YCbCrEncoding::None to V4L2","commit_ref":"a03ce60cf969b7b26b25c785f64cb5662635b702","pull_url":null,"state":"accepted","archived":false,"hash":"34b692234825230ac98ff795bdcdb0863ffbaf2f","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17293/mbox/","series":[{"id":3468,"url":"https://patchwork.libcamera.org/api/1.1/series/3468/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3468","date":"2022-09-03T23:06:43","name":"[libcamera-devel] libcamera: v4l2_device: Map YCbCrEncoding::None to V4L2","version":1,"mbox":"https://patchwork.libcamera.org/series/3468/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17293/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17293/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B9A1C3272\n\tfor ;\n\tSat, 3 Sep 2022 23:06:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1AB96203D;\n\tSun, 4 Sep 2022 01:06:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 01F12603DD\n\tfor ;\n\tSun, 4 Sep 2022 01:06:57 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 242A62E4;\n\tSun, 4 Sep 2022 01:06:57 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662246418;\n\tbh=9Z64mlT74qHO/5XwtLJVylIiUkcu4JB31Wu56NGXd6M=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=SuE4d7i8r9FMq2jQZ3p4Xr2ErDtPqzswuOMtaixgugiJxjETqdR0J2rndh/1JrLhm\n\tm9qzLP2sZZY6lNfhxLnV3+gVg0DdYc3/joYDzcp7IBBawJcXmutcueCjXWQsCrxGgd\n\tZ5NfkhemAwX21JzM0zfJxOKhS1emj3PhRc2zBlJG/ldW/88gIIU+yS0DlwwBs81Wtd\n\ta/Pgr51+JJRocfQO/I6XZqOLNDnt0EpyNs5CsGXhTuc4Qi4a6eomDB4EDzBmnyGJAE\n\tAvCqmg9KLVk/6SqmUfM+/BwufQsRv7lvRfBAoiGdt3Eb3VZIem2q8WmxFzhVr3Ztd1\n\t0Id4Ek93xFDoA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662246417;\n\tbh=9Z64mlT74qHO/5XwtLJVylIiUkcu4JB31Wu56NGXd6M=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=m1MtdSm03/NuF+WIIZdu6njQei/KuB8ykTPSchlIt/UYV36l+REqy62BRFN8T8mf0\n\tx7r94E2BMl5nWfdCdtt90CTnlOwX2ne6agxvuELam9I9pRGT3JlDN19VmxCXCeaLpc\n\t/6ZbpKsLRF2tk2VCqOGxPKH5ZE4IVdtWyU5sdjgI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"m1MtdSm0\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 4 Sep 2022 02:06:43 +0300","Message-Id":"<20220903230643.19284-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: v4l2_device: Map\n\tYCbCrEncoding::None to V4L2","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ycbcrEncodingToV4l2 map is missing the YCbCrEncoding::None encoding,\nwhich results in a failure of V4L2Device::fromColorSpace() to convert\ncolor spaces from libcamera to V4L2 for RGB formats. Fix it by adding\nthe missing encoding. As V4L2 has no such encoding, use\nV4L2_YCBCR_ENC_DEFAULT as the value doesn't matter.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/v4l2_device.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 1d899657bf7d..7f251bd820a0 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -796,6 +796,8 @@ static const std::map transferFunc\n };\n \n static const std::map ycbcrEncodingToV4l2 = {\n+\t/* V4L2 has no \"none\" encoding. */\n+\t{ ColorSpace::YcbcrEncoding::None, V4L2_YCBCR_ENC_DEFAULT },\n \t{ ColorSpace::YcbcrEncoding::Rec601, V4L2_YCBCR_ENC_601 },\n \t{ ColorSpace::YcbcrEncoding::Rec709, V4L2_YCBCR_ENC_709 },\n \t{ ColorSpace::YcbcrEncoding::Rec2020, V4L2_YCBCR_ENC_BT2020 },\n","prefixes":["libcamera-devel"]}