{"id":17286,"url":"https://patchwork.libcamera.org/api/1.1/patches/17286/?format=json","web_url":"https://patchwork.libcamera.org/patch/17286/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220903115042.954797-1-kieran.bingham@ideasonboard.com>","date":"2022-09-03T11:50:42","name":"[libcamera-devel] libcamera: v4l2_device: Report device node on failure","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"63cffe710b99c604fcfc2a138f04a3d3a9c6f162","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17286/mbox/","series":[{"id":3465,"url":"https://patchwork.libcamera.org/api/1.1/series/3465/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3465","date":"2022-09-03T11:50:42","name":"[libcamera-devel] libcamera: v4l2_device: Report device node on failure","version":1,"mbox":"https://patchwork.libcamera.org/series/3465/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17286/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17286/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9166FC3272\n\tfor ;\n\tSat, 3 Sep 2022 11:50:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 081E16202D;\n\tSat, 3 Sep 2022 13:50:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 416DF61FBB\n\tfor ;\n\tSat, 3 Sep 2022 13:50:46 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C32D4A8;\n\tSat, 3 Sep 2022 13:50:45 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662205848;\n\tbh=VZErR2aNTAD90t6ziUO2u6gIQWdseU3L2BYaHAXim2Q=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=Qm/GTy9OtGY2+KRnfN50vaYn1nRZe7rUNe9m4ZRUNse/1b1IMoEZhJmzaWG1RxWbs\n\tV9f3Xu0kZsDDUTquxYMW/3Fx44ditr7fjDBiPhfIVHS3vD7PSpibetZkehlyAY6XAf\n\tGoXHBG/P5UgxUx60LoV2Duo2iEFvo/zmjXhXot7h98NCzDsgitIYljDesNSk8r6K2H\n\ttQDKc/524820ONtbdWMgIqX7JZUcvFxsQ7MIzjwOrPnz8VvXCFoJMMZfzomOdJfQ3g\n\tYhzSaP2h1kQvonaCVmVwT1BNh2VlDO0dJEUT133HdstCmju+q7MEIWjxLm7oUQoW/Z\n\t67l9svmknpxkQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662205845;\n\tbh=VZErR2aNTAD90t6ziUO2u6gIQWdseU3L2BYaHAXim2Q=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=De3CciWWlfCn/2ttjbdIutJ7FLzag+zfa00CyDoXxefuX3vcP0ksr2QS55pICI6Rx\n\t3s79MATAujazn7Mj5k4F0usYFwaV1yIDP7QyZ1MPoUVEKPjdWvJFVMzIJzVhZs0sgh\n\toUfw7Fcaf0c8i4f6JXbjK/GBlmYIyIEi1ajMMl88="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"De3CciWW\"; dkim-atps=neutral","To":"libcamera devel ","Date":"Sat, 3 Sep 2022 12:50:42 +0100","Message-Id":"<20220903115042.954797-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: v4l2_device: Report device\n\tnode on failure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the V4L2Device fails to open, it is not clear what device\ncaused the failure. The Entity name is presented, but not the device\nnode.\n\nProvide it.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/v4l2_device.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 1d899657bf7d..29a800a5cee3 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -90,6 +90,7 @@ int V4L2Device::open(unsigned int flags)\n \tif (!fd.isValid()) {\n \t\tint ret = -errno;\n \t\tLOG(V4L2, Error) << \"Failed to open V4L2 device: \"\n+\t\t\t\t << deviceNode_ << \": \"\n \t\t\t\t << strerror(-ret);\n \t\treturn ret;\n \t}\n","prefixes":["libcamera-devel"]}