{"id":17243,"url":"https://patchwork.libcamera.org/api/1.1/patches/17243/?format=json","web_url":"https://patchwork.libcamera.org/patch/17243/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220829233017.2699444-4-paul.elder@ideasonboard.com>","date":"2022-08-29T23:30:13","name":"[libcamera-devel,v4,3/7] libcamera: ipa_data_serializer: Add serializer for Flags","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f3a433b64efc769944b2534c248f6411666e7c01","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17243/mbox/","series":[{"id":3450,"url":"https://patchwork.libcamera.org/api/1.1/series/3450/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3450","date":"2022-08-29T23:30:10","name":"utils: ipc: Add support for enums and Flags","version":4,"mbox":"https://patchwork.libcamera.org/series/3450/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17243/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17243/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0D91C327D\n\tfor ;\n\tMon, 29 Aug 2022 23:30:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EADAC61FC7;\n\tTue, 30 Aug 2022 01:30:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 413D561F9C\n\tfor ;\n\tTue, 30 Aug 2022 01:30:30 +0200 (CEST)","from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad8a:9000:1bf9:855b:22de:3645])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E4CF6F2;\n\tTue, 30 Aug 2022 01:30:29 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661815834;\n\tbh=F/6XAvTyZBjVFq/yAo/+7z/8mDpIfsJZ8h1zXWNbvVQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=BtQEY+zo+OrsdiZEbJxK4aSyctYLO049MxD16zPKsxlkc63h+IgWokyIZanoa9nip\n\tFpzmO+d4NdNpimza00OakGYQ4aG2kLKGG4D79ukqpgnhA2qPFUw/NfUzFsGwKy3TD1\n\tJmFOrYUP1wClZbK39xShkkNiEPmgBsQ/5gpHdIbggdFOsPNItQV/xsvJcD2W0rWWaR\n\tRxlU3on9XTPGDj2XvIp5FOQQ94o15+IzYbFd0ijgB8hJN9q7UX0DTj/1k/sSx/3aI0\n\ttD7A5Xf86TVwB3NAK8m/vKKRW2DflQ9zNLfN8lgDv1KdRtJfOtVnbt5Z5/0WEfCMBA\n\tXeUP/UFfa3y+g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661815830;\n\tbh=F/6XAvTyZBjVFq/yAo/+7z/8mDpIfsJZ8h1zXWNbvVQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Dbj5cvP7MBF4qiFKKf/LamjU+PTMtN7dT+8NQWgzS4rjaCL7Cj3DRSGbrfRdkjPSl\n\tgseO7JOdTxxC2VH55y0ihWykglnoVTPz7NNS4uIEMHkPZPg43S39pY4MPrhBeuiV7c\n\tYet3Kza/0TZ1byDyLdtDciYyhXmsJbEvnXiFG9fg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Dbj5cvP7\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 29 Aug 2022 18:30:13 -0500","Message-Id":"<20220829233017.2699444-4-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20220829233017.2699444-1-paul.elder@ideasonboard.com>","References":"<20220829233017.2699444-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 3/7] libcamera: ipa_data_serializer:\n\tAdd serializer for Flags","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Implement an IPADataSerializer for Flags.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nNo change in v4\n\nNo change in v3\n\nChanges in v2:\n- use Flags's Type cast to avoid friend class\n---\n .../libcamera/internal/ipa_data_serializer.h | 46 +++++++++++++++++++\n 1 file changed, 46 insertions(+)","diff":"diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\nindex 30bdaebc..981d2f5c 100644\n--- a/include/libcamera/internal/ipa_data_serializer.h\n+++ b/include/libcamera/internal/ipa_data_serializer.h\n@@ -14,6 +14,7 @@\n #include \n #include \n \n+#include \n #include \n \n #include \n@@ -301,6 +302,51 @@ public:\n \t}\n };\n \n+/* Serialization format for Flags is same as for PODs */\n+template\n+class IPADataSerializer>\n+{\n+public:\n+\tstatic std::tuple, std::vector>\n+\tserialize(const Flags &data, [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\tstd::vector dataVec;\n+\t\tdataVec.reserve(sizeof(Flags));\n+\t\tappendPOD(dataVec, static_cast::Type>(data));\n+\n+\t\treturn { dataVec, {} };\n+\t}\n+\n+\tstatic Flags deserialize(std::vector &data,\n+\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\treturn deserialize(data.cbegin(), data.end());\n+\t}\n+\n+\tstatic Flags deserialize(std::vector::const_iterator dataBegin,\n+\t\t\t\t std::vector::const_iterator dataEnd,\n+\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\treturn Flags{ static_cast(readPOD(dataBegin, 0, dataEnd)) };\n+\t}\n+\n+\tstatic Flags deserialize(std::vector &data,\n+\t\t\t\t [[maybe_unused]] std::vector &fds,\n+\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\treturn deserialize(data.cbegin(), data.end());\n+\t}\n+\n+\tstatic Flags deserialize(std::vector::const_iterator dataBegin,\n+\t\t\t\t std::vector::const_iterator dataEnd,\n+\t\t\t\t [[maybe_unused]] std::vector::const_iterator fdsBegin,\n+\t\t\t\t [[maybe_unused]] std::vector::const_iterator fdsEnd,\n+\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\treturn deserialize(dataBegin, dataEnd);\n+\t}\n+};\n+\n #endif /* __DOXYGEN__ */\n \n } /* namespace libcamera */\n","prefixes":["libcamera-devel","v4","3/7"]}