{"id":17169,"url":"https://patchwork.libcamera.org/api/1.1/patches/17169/?format=json","web_url":"https://patchwork.libcamera.org/patch/17169/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220818094410.1671-15-jacopo@jmondi.org>","date":"2022-08-18T09:44:07","name":"[libcamera-devel,v3,14/17] ipa: rkisp: Remove unused class member","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3ad68fc26d6f0b4a606ffd0998d55873f400da54","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17169/mbox/","series":[{"id":3426,"url":"https://patchwork.libcamera.org/api/1.1/series/3426/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3426","date":"2022-08-18T09:43:53","name":"libcamera: Align IPU3 and RKISP1 interfaces","version":3,"mbox":"https://patchwork.libcamera.org/series/3426/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17169/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17169/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36752C327D\n\tfor ;\n\tThu, 18 Aug 2022 09:44:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC91D61FD3;\n\tThu, 18 Aug 2022 11:44:40 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CD9061FCF\n\tfor ;\n\tThu, 18 Aug 2022 11:44:37 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 81E12FF802;\n\tThu, 18 Aug 2022 09:44:36 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660815880;\n\tbh=co8Qc+hvoPwP2wDDHIWRy2LYjtf34afcmi9IT2XaqTo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Qe/vusPJxvDRlUtDKKVf52xFwW15mobsIQwni1nebnHX7RX/CzAq5dFGi7U6UD+1/\n\tAUYYn4J9BwHKSDXOcB7sjhn77IZPTOfUbxUPcaYP/3K1O/sD+kLxJD96Zxw2R/KZvB\n\tKkClpF5EqAUyVXINq8a5nsykbuWjQcfFpOYwnUFlovsVVNmK1UJJwzb+Xx0fqOsVCp\n\tiKuIsnDEGavQu9sU7WxX8botpqPYcNt4qtcNZd/QeFliyJPe5MdBH/K2Ub7Xla+LJO\n\tEbal7JOJSxA+BLzmlCu5jEQ23L8eXZU7f0cYNL+/7FJUGGtEQgnv61wO4hspWMxjNj\n\tpjRAkIcnVrP6A==","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 18 Aug 2022 11:44:07 +0200","Message-Id":"<20220818094410.1671-15-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.37.2","In-Reply-To":"<20220818094410.1671-1-jacopo@jmondi.org>","References":"<20220818094410.1671-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 14/17] ipa: rkisp: Remove unused class\n\tmember","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The \"autoExposure\" class member is not used.\n\nRemove it.\n\nSigned-off-by: Jacopo Mondi \n---\n src/ipa/rkisp1/rkisp1.cpp | 5 -----\n 1 file changed, 5 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex da7374815c99..a1834034e617 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -74,9 +74,6 @@ private:\n \tControlInfoMap sensorCtrls_;\n \tstd::optional lensCtrls_;\n \n-\t/* Camera sensor controls. */\n-\tbool autoExposure_;\n-\n \t/* revision-specific data */\n \trkisp1_cif_isp_version hwRevision_;\n \tunsigned int hwHistBinNMax_;\n@@ -265,8 +262,6 @@ int IPARkISP1::configure(const IPAConfigInfo &configInfo)\n \tsensorCtrls_ = configInfo.sensorControls;\n \tlensCtrls_ = configInfo.lensControls;\n \n-\tautoExposure_ = true;\n-\n \tupdateSessionConfiguration(configInfo);\n \n \tfor (auto const &algo : algorithms()) {\n","prefixes":["libcamera-devel","v3","14/17"]}