{"id":17166,"url":"https://patchwork.libcamera.org/api/1.1/patches/17166/?format=json","web_url":"https://patchwork.libcamera.org/patch/17166/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220818094410.1671-12-jacopo@jmondi.org>","date":"2022-08-18T09:44:04","name":"[libcamera-devel,v3,11/17] ipa: rkisp1: Make cameraSensorInfo mandatory","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"062e68f5ac2b2b50e96988082dd5f437ee80a506","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17166/mbox/","series":[{"id":3426,"url":"https://patchwork.libcamera.org/api/1.1/series/3426/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3426","date":"2022-08-18T09:43:53","name":"libcamera: Align IPU3 and RKISP1 interfaces","version":3,"mbox":"https://patchwork.libcamera.org/series/3426/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17166/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17166/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31F40C3272\n\tfor ;\n\tThu, 18 Aug 2022 09:44:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE57261FDF;\n\tThu, 18 Aug 2022 11:44:38 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00BD161FC9\n\tfor ;\n\tThu, 18 Aug 2022 11:44:33 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id F2F5BFF808;\n\tThu, 18 Aug 2022 09:44:32 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660815878;\n\tbh=nAUb8Asw6OSl/SzxQBTVubUhqHDEbKyLYas21dGVrnI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xFWltJum8zHkusoecA4YomYwX3OnIPI7hG3Pv1BLHtt5oSEUgtdkEQCP7lhz1vurw\n\t12JFPY0P6Ds2tshE5eJSOBbf7YXnPejsyw78ijsMhbnHhNhSoywUhfTZ14paEa+U/4\n\tQcycmOj+oIqZg/hxJ4W/y/XScYtcfeemj0mi+UoAy7RYq0KKZbPZgNCKlQlu6j7fov\n\tnWxjgsqSY6wjX1MtLV382iJxB1ukn0XW4AGP7GVzaHB6PWDFgxC15TbhrAG6WCleAv\n\txLSBOL1esuNJwul87vXw7K11dnlqxCUfCCG0R3rvrqIw3R34UKIVKSj/aBs+t+VPKj\n\tuizOn25ZFgUng==","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 18 Aug 2022 11:44:04 +0200","Message-Id":"<20220818094410.1671-12-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.37.2","In-Reply-To":"<20220818094410.1671-1-jacopo@jmondi.org>","References":"<20220818094410.1671-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 11/17] ipa: rkisp1: Make\n\tcameraSensorInfo mandatory","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Resolve a long-standing todo item by making the cameraSensorInfo\nmandatory to operate the RkISP1 IPA module.\n\nSigned-off-by: Jacopo Mondi \n---\n src/ipa/rkisp1/rkisp1.cpp | 6 ------\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 6 ++----\n 2 files changed, 2 insertions(+), 10 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex f2075c893d29..9f97c776016e 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -256,12 +256,6 @@ bool IPARkISP1::validateSensorControls(const ControlInfoMap &sensorControls)\n \n }\n \n-/**\n- * \\todo The RkISP1 pipeline currently provides an empty IPACameraSensorInfo\n- * if the connected sensor does not provide enough information to properly\n- * assemble one. Make sure the reported sensor information are relevant\n- * before accessing them.\n- */\n int IPARkISP1::configure(const IPAConfigInfo &configInfo)\n {\n \tif (!validateSensorControls(configInfo.sensorControls)) {\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 3b250b0ae346..f9a3722e4084 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -681,10 +681,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \tIPACameraSensorInfo sensorInfo = {};\n \tret = data->sensor_->sensorInfo(&sensorInfo);\n \tif (ret) {\n-\t\t/* \\todo Turn this into a hard failure. */\n-\t\tLOG(RkISP1, Warning) << \"Camera sensor information not available\";\n-\t\tsensorInfo = {};\n-\t\tret = 0;\n+\t\tLOG(RkISP1, Error) << \"Camera sensor information not available\";\n+\t\treturn ret;\n \t}\n \n \tconfigInfo.sensorInfo = sensorInfo;\n","prefixes":["libcamera-devel","v3","11/17"]}