{"id":17149,"url":"https://patchwork.libcamera.org/api/1.1/patches/17149/?format=json","web_url":"https://patchwork.libcamera.org/patch/17149/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220818064923.2573060-4-paul.elder@ideasonboard.com>","date":"2022-08-18T06:49:18","name":"[libcamera-devel,v2,3/7] libcamera: ipa_data_serializer: Add serializer for Flags","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f3a433b64efc769944b2534c248f6411666e7c01","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17149/mbox/","series":[{"id":3424,"url":"https://patchwork.libcamera.org/api/1.1/series/3424/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3424","date":"2022-08-18T06:49:15","name":"utils: ipc: Add support for enums and Flags","version":2,"mbox":"https://patchwork.libcamera.org/series/3424/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17149/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17149/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40072C3272\n\tfor ;\n\tThu, 18 Aug 2022 06:49:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1FB761FC9;\n\tThu, 18 Aug 2022 08:49:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FF6961FA3\n\tfor ;\n\tThu, 18 Aug 2022 08:49:42 +0200 (CEST)","from pyrite.rasen.tech (KD027085204050.au-net.ne.jp [27.85.204.50])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A8B2D4A8;\n\tThu, 18 Aug 2022 08:49:40 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660805384;\n\tbh=pxIiDs65YU5IvNRL26MqLAg/N5wkumWmK36N6xO+SYA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=GSReYMq5BEtTmFG9AcrR7QyfL0wIMEbQo+m7x3OihiDysFaR8hXA4IaxtbGTHVaIa\n\tMG01GFiX3AoCsf0wPqQP0k6U0P+G7SOBY5L8CPSnhin+LtyasQI3rs5czxl+eGTMdP\n\tM9oXN5rlrurQpK8qb+A23FqKO17DLCTY/mY9zFu8EFQIk5BHlznx5EhACbMVt1mLHV\n\tkiVNaUV3eKbuJzMzhhM884NsMbkGM1vkg7PEz9+cDEmJnQEE7WKrLdmq6BF8SWxwbh\n\tBDBoBrV9stc7YGMnk5mp31NzkQusVM7w2pEZdMjgNBmGWa2mFUvom87WxLV/qWSuki\n\tJCWmmWzyJblgw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660805382;\n\tbh=pxIiDs65YU5IvNRL26MqLAg/N5wkumWmK36N6xO+SYA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=F47Hp9OYlbJ+Nm4+40BTQY/l0FkoIGchJ5W9c9Sl9XYl2HXlQyCcwm9nyOYmIIQcz\n\tNssH7aEDRDyHVMTlnAC4uHMuBuz5tjaeaLbBLnYt1tz9VvnS5fO8gnOUwlXdKZNTcU\n\to3j5pF0NMiqGv4CJMxrNld6IxN59oF3FpMDiL1pY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"F47Hp9OY\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 18 Aug 2022 15:49:18 +0900","Message-Id":"<20220818064923.2573060-4-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20220818064923.2573060-1-paul.elder@ideasonboard.com>","References":"<20220818064923.2573060-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 3/7] libcamera: ipa_data_serializer:\n\tAdd serializer for Flags","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Implement an IPADataSerializer for Flags.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nChanges in v2:\n- use Flags's Type cast to avoid friend class\n---\n .../libcamera/internal/ipa_data_serializer.h | 46 +++++++++++++++++++\n 1 file changed, 46 insertions(+)","diff":"diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\nindex 30bdaebc..981d2f5c 100644\n--- a/include/libcamera/internal/ipa_data_serializer.h\n+++ b/include/libcamera/internal/ipa_data_serializer.h\n@@ -14,6 +14,7 @@\n #include \n #include \n \n+#include \n #include \n \n #include \n@@ -301,6 +302,51 @@ public:\n \t}\n };\n \n+/* Serialization format for Flags is same as for PODs */\n+template\n+class IPADataSerializer>\n+{\n+public:\n+\tstatic std::tuple, std::vector>\n+\tserialize(const Flags &data, [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\tstd::vector dataVec;\n+\t\tdataVec.reserve(sizeof(Flags));\n+\t\tappendPOD(dataVec, static_cast::Type>(data));\n+\n+\t\treturn { dataVec, {} };\n+\t}\n+\n+\tstatic Flags deserialize(std::vector &data,\n+\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\treturn deserialize(data.cbegin(), data.end());\n+\t}\n+\n+\tstatic Flags deserialize(std::vector::const_iterator dataBegin,\n+\t\t\t\t std::vector::const_iterator dataEnd,\n+\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\treturn Flags{ static_cast(readPOD(dataBegin, 0, dataEnd)) };\n+\t}\n+\n+\tstatic Flags deserialize(std::vector &data,\n+\t\t\t\t [[maybe_unused]] std::vector &fds,\n+\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\treturn deserialize(data.cbegin(), data.end());\n+\t}\n+\n+\tstatic Flags deserialize(std::vector::const_iterator dataBegin,\n+\t\t\t\t std::vector::const_iterator dataEnd,\n+\t\t\t\t [[maybe_unused]] std::vector::const_iterator fdsBegin,\n+\t\t\t\t [[maybe_unused]] std::vector::const_iterator fdsEnd,\n+\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\treturn deserialize(dataBegin, dataEnd);\n+\t}\n+};\n+\n #endif /* __DOXYGEN__ */\n \n } /* namespace libcamera */\n","prefixes":["libcamera-devel","v2","3/7"]}