{"id":17120,"url":"https://patchwork.libcamera.org/api/1.1/patches/17120/?format=json","web_url":"https://patchwork.libcamera.org/patch/17120/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220814160747.52093-5-kunalagarwal1072002@gmail.com>","date":"2022-08-14T16:07:46","name":"[libcamera-devel,v3,5/6,HACK] pipeline: simple: simple.cpp: Hack to test the GL converter","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f9038190e37b86f890a6ddaee7eee3328a392a58","submitter":{"id":116,"url":"https://patchwork.libcamera.org/api/1.1/people/116/?format=json","name":"Kunal Agarwal","email":"kunalagarwal1072002@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17120/mbox/","series":[{"id":3414,"url":"https://patchwork.libcamera.org/api/1.1/series/3414/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3414","date":"2022-08-14T16:07:42","name":"[libcamera-devel,v3,1/6] pipeline: simple: shader: Shaders for debayering","version":3,"mbox":"https://patchwork.libcamera.org/series/3414/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17120/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17120/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3AE02C3272\n\tfor ;\n\tSun, 14 Aug 2022 16:09:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC89D61FC3;\n\tSun, 14 Aug 2022 18:09:19 +0200 (CEST)","from mail-pl1-x631.google.com (mail-pl1-x631.google.com\n\t[IPv6:2607:f8b0:4864:20::631])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B794461FBA\n\tfor ;\n\tSun, 14 Aug 2022 18:09:18 +0200 (CEST)","by mail-pl1-x631.google.com with SMTP id x23so4589491pll.7\n\tfor ;\n\tSun, 14 Aug 2022 09:09:18 -0700 (PDT)","from pop-os.localdomain ([115.96.217.20])\n\tby smtp.googlemail.com with ESMTPSA id\n\tj6-20020a170902da8600b001709aea1516sm5576653plx.276.2022.08.14.09.09.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 14 Aug 2022 09:09:16 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660493359;\n\tbh=XXyEynVdu4y+F579v801F4ppNzP39vH+kn2cB1i9Yis=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=KzgqQ1oHi6/7IqiY6XXgVQXYuECZs47ZQDWiVe5oM1SOPpMaFGMuUa6RrzPBVlCjM\n\tZhWyVT8YV+FJhJHRa2Nsue/GV6LONo96XexwgJ7vYQCeo+aT0ndcXnsKUPiaj+YBSl\n\tOVJX2B05lYCJwTPnb7wkj6LU+/PExXmvrvIzKTYmYnlntEeF3K3N01MrpUidkw8mQk\n\t98Yq6/hB2pA1l4FdxBn6Cc8Dhd1NLvmU3ULQVn7SPH8nq2iUr+iRLu+2DzXtBaphDj\n\tWFxqmU31cvMYeAT6isAJnVVMwuazgcIm5a4AqntVu+JM03htrVs6fjhG6aGsdEgujf\n\t6sRy3UcPw+Kww==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc;\n\tbh=FkuiYHjnNT30yQpCOMkDwgtN3xIa8EcKcOneXpSZ+38=;\n\tb=MTzFAGB6dFfmEKL4aMJ1IfvgG2bY58d4iifPZ1DrRZddw4gcgtYb8nw+0waALmg4e1\n\tPmZlhWjKbg3uss4xvTkZi3Qa/H5dNYP3TvwTRy847GEqjeDao7X9a8LY9RaULDaPqneJ\n\t5x3uygbP14oH8flw4VyiEc8fAht1eW+p3WiD20k/QEcKq5HxRWFCffiG9N3XrXLW/3KO\n\tSm6xH5U1KbLqjNNjXM1lijoodyeJ/LpPvtPOlhA3jriwJay0KgNRUpGAA1d15Y27a5H3\n\tPgryKwQvfeanLKEKCkCv5oHMAN5s30cnVilEnpolvcrQkO7Q0mPZ2m5A/0jp9KbE4TBQ\n\tWa3A=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MTzFAGB6\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc;\n\tbh=FkuiYHjnNT30yQpCOMkDwgtN3xIa8EcKcOneXpSZ+38=;\n\tb=BNfWaCN8irCWVHN9WD89+7eDkNwfMOKOsWidMWo8bNu3gxZITVvZO15It6elo9ReSw\n\tTNR73eyuEODcrW0Xz9zjEMdoUeGNmqUY9dTfT1cRp3RT+mm/v6e5g97fhoEgutLfBRbE\n\tx/jqwQGxHlA3Kl8d8lfX9wFRePVYFJJjzlxCbT89V8C/SLf84SW1QNLN2c09qUWOT++v\n\tLGCRlX2f/c2JKBkmdI0i+zl6yzgZwNKxb+6SOqnuh0jD9WodE8VXcLf9HjN4cIJn+KbR\n\txBfOIeywXB++LGd7Dc3M0zxZkHeZdWlGZeUss8dCxyMHmniQbuz0POO9/LgwODau/rkb\n\tYx1Q==","X-Gm-Message-State":"ACgBeo2o2+sH58zQhUfjxaESyGrebl7IRytjGJMRi9HBslyyY7JMuPre\n\tSZLWzsOBcns4ePc2V/HrBFNy8Q0hTtM=","X-Google-Smtp-Source":"AA6agR4w4ukh/d2obgSkZympMGAuP/SNM0AixE9YZBkYQ+SW/hOxGSQPp4ZRb39DZvji2a98tWv6mQ==","X-Received":"by 2002:a17:90b:4b89:b0:1f5:68b:b14e with SMTP id\n\tlr9-20020a17090b4b8900b001f5068bb14emr24544244pjb.30.1660493357121; \n\tSun, 14 Aug 2022 09:09:17 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 14 Aug 2022 21:37:46 +0530","Message-Id":"<20220814160747.52093-5-kunalagarwal1072002@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220814160747.52093-1-kunalagarwal1072002@gmail.com>","References":"<20220814160747.52093-1-kunalagarwal1072002@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 5/6] [HACK]pipeline: simple:\n\tsimple.cpp: Hack to test the GL converter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kunal Agarwal via libcamera-devel ","Reply-To":"Kunal Agarwal ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Includes converter_gl header file and add unicam to list of\nsupported devices to run on RaspberryPi\n\nRemoves parameterized constructor call for SimpleConverter,\nwhich passed Mediadevice converter\n\nSets Number of streams to 1 when converter is in use\n\nSigned-off-by: Kunal Agarwal \n---\n src/libcamera/pipeline/simple/simple.cpp | 27 ++++++++++++------------\n 1 file changed, 13 insertions(+), 14 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex bc0cb1a0..485282fb 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -36,7 +36,7 @@\n #include \"libcamera/internal/v4l2_subdevice.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n-#include \"converter.h\"\n+#include \"converter_gl.h\"\n \n namespace libcamera {\n \n@@ -187,6 +187,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n \t{ \"imx7-csi\", { { \"pxp\", 1 } } },\n \t{ \"qcom-camss\", {} },\n \t{ \"sun6i-csi\", {} },\n+\t{ \"unicam\", {} },\n };\n \n } /* namespace */\n@@ -452,18 +453,16 @@ int SimpleCameraData::init()\n \tSimplePipelineHandler *pipe = SimpleCameraData::pipe();\n \tint ret;\n \n-\t/* Open the converter, if any. */\n-\tMediaDevice *converter = pipe->converter();\n-\tif (converter) {\n-\t\tconverter_ = std::make_unique(converter);\n-\t\tif (!converter_->isValid()) {\n-\t\t\tLOG(SimplePipeline, Warning)\n-\t\t\t\t<< \"Failed to create converter, disabling format conversion\";\n-\t\t\tconverter_.reset();\n-\t\t} else {\n-\t\t\tconverter_->inputBufferReady.connect(this, &SimpleCameraData::converterInputDone);\n-\t\t\tconverter_->outputBufferReady.connect(this, &SimpleCameraData::converterOutputDone);\n-\t\t}\n+\t/* Open the converter. */\n+\n+\tconverter_ = std::make_unique();\n+\tif (!converter_->isValid()) {\n+\t\tLOG(SimplePipeline, Warning)\n+\t\t\t<< \"Failed to create converter, disabling format conversion\";\n+\t\tconverter_.reset();\n+\t} else {\n+\t\tconverter_->inputBufferReady.connect(this, &SimpleCameraData::converterInputDone);\n+\t\tconverter_->outputBufferReady.connect(this, &SimpleCameraData::converterOutputDone);\n \t}\n \n \tvideo_ = pipe->video(entities_.back().entity);\n@@ -1281,7 +1280,7 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n \t\tDeviceMatch converterMatch(name);\n \t\tconverter_ = acquireMediaDevice(enumerator, converterMatch);\n \t\tif (converter_) {\n-\t\t\tnumStreams = streams;\n+\t\t\tnumStreams = 1;\n \t\t\tbreak;\n \t\t}\n \t}\n","prefixes":["libcamera-devel","v3","5/6","HACK"]}