{"id":17105,"url":"https://patchwork.libcamera.org/api/1.1/patches/17105/?format=json","web_url":"https://patchwork.libcamera.org/patch/17105/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220812124651.27496-10-utkarsh02t@gmail.com>","date":"2022-08-12T12:46:49","name":"[libcamera-devel,v2,09/11] qcam: ControlFrame: Add GUI interaction to float controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d6b31acc19bf92f4e8f11d96090fd10cc98cccd7","submitter":{"id":114,"url":"https://patchwork.libcamera.org/api/1.1/people/114/?format=json","name":"Utkarsh Tiwari","email":"utkarsh02t@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17105/mbox/","series":[{"id":3410,"url":"https://patchwork.libcamera.org/api/1.1/series/3410/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3410","date":"2022-08-12T12:46:40","name":"Introduce control interaction to qcam","version":2,"mbox":"https://patchwork.libcamera.org/series/3410/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17105/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17105/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FF8EBE173\n\tfor ;\n\tFri, 12 Aug 2022 12:47:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B08D6333F;\n\tFri, 12 Aug 2022 14:47:25 +0200 (CEST)","from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com\n\t[IPv6:2607:f8b0:4864:20::62d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BE096333D\n\tfor ;\n\tFri, 12 Aug 2022 14:47:22 +0200 (CEST)","by mail-pl1-x62d.google.com with SMTP id 13so651094plo.12\n\tfor ;\n\tFri, 12 Aug 2022 05:47:22 -0700 (PDT)","from localhost.localdomain ([2404:bd00:3:dc0d:d8e:96a2:2dbe:5a83])\n\tby smtp.gmail.com with ESMTPSA id\n\te6-20020a17090a728600b001f069352d73sm1431785pjg.25.2022.08.12.05.47.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 12 Aug 2022 05:47:20 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660308445;\n\tbh=abgtq4SzMVTr1jphCwKu42DVfkAB0i6XzfK3w8OsDFQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=OUMOdxkRmuv6PiRJibRY2GcQ/dx2N34tmjiS4MJth5EOeBpGnNZlNglGfaKl3sDXE\n\tF5xivx/oZV7fvs/Iob7A6ZT8c9AYVdXIF0nIVbx5D+/nexaQrj0g2NdiyTBbJ9/j9r\n\tRqOq1EJYaA8Agv35HMYHEWEhBGsGmHyx6VSB4BgrKj8/CiBqr8ndJJMiQJFJq94+a0\n\tZWbLJVpnGH3ZU0riCTdMoYuO04o7RiYC3ROtWmKMlWF06ZtoxTisPO9LN/PV2DWFmR\n\thIuc4LQ5w3dX6LJsoPj4CM/qIzumh8kUTpUuAYoEEPn72KlrWjjE9X9fZjm0CcqfVr\n\torRCJDpKinWxw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc;\n\tbh=sBE+9kgB4qhutisBVU2YWJFcr8eavp0AgoqYuHqJ5/k=;\n\tb=E/bo7xDGFyfq+WO/p/UyQyJET1HC+pW5dx7EFGTiVO16FG/FnS4h7mgaHA/QWh8bQp\n\tDWUm2usbzUDtxQAQCBoeWEXT1wahQdcGcK/PnwwhpOAPd7jkf/drY93ABuzitepqujBj\n\t6eEZDR2doCtYU0/YhSVPI9L/XG5G4w3OEsXhAEc+8bwn6bWST53q0Y6Mm+9YP25He5Mv\n\tqkgMPXeKTXRdTEsblaY6I22e6VnhprqajNkOFYWAvil0qS3HqHzecyCXVVWpIOvN97vj\n\tZEBorXy12AdyutnssNa1Y72byqhgUexMIPheizG2+idqaV2NceKGNTa+OGsmS3q1gurS\n\t91cw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E/bo7xDG\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc;\n\tbh=sBE+9kgB4qhutisBVU2YWJFcr8eavp0AgoqYuHqJ5/k=;\n\tb=4zMzpA6pkzZ75s4/nkfp+BISSGFWsFYIuew7qooUBRUjnDyDGgcvObqLWok7MUHxSk\n\tZg9oyET+gOX7V2OYZXfAfF3ux7viAezdfuX5nA0Lg3gUj3f1grKoOjRGbOB/kwccEKug\n\t4uIlvVzyk6pRdLQZp1Vz5oDgn7Tvnbh0E7h8sT4K9siI20liB7oLgtFSs2DYw9TiAwPA\n\tZ5q+FcmfWm9G+r7GG1xnXQ/PBWmOuglOHpC1FIVCDRDlV/SJskj3PKwnfR5Odngp4HGU\n\th6tZbcTtWp8/HDI3dpS2rr4hW5aKJw+W6MsoHWSPkmVUIYGRkI+lm5PbL6Ebbi0lewZW\n\tHASA==","X-Gm-Message-State":"ACgBeo3eE2BrCLGu0LkoIAeviSaSTUtDbB3FU4Uja+KXLiCap+PWwxcD\n\tLgqg3TD6CHT02DMpoVZI3jmrOEBWx6g=","X-Google-Smtp-Source":"AA6agR4NQxW40rJJbD9Qj/ktdwVN7mRwsT2psT6Aw1EyvqOSzDZ4/yXdQ18mXQ3hta4s0f9I0dswqQ==","X-Received":"by 2002:a17:903:2410:b0:171:4bbc:2526 with SMTP id\n\te16-20020a170903241000b001714bbc2526mr3827330plo.62.1660308440934; \n\tFri, 12 Aug 2022 05:47:20 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 12 Aug 2022 18:16:49 +0530","Message-Id":"<20220812124651.27496-10-utkarsh02t@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220812124651.27496-1-utkarsh02t@gmail.com>","References":"<20220812124651.27496-1-utkarsh02t@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 09/11] qcam: ControlFrame: Add GUI\n\tinteraction to float controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Utkarsh Tiwari via libcamera-devel\n\t","Reply-To":"Utkarsh Tiwari ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add the float slider for the float controls to be able to control its\nvalue. Also display the current values for the float controls.\n\nSigned-off-by: Utkarsh Tiwari \n---\n src/qcam/settings/control_frame.cpp | 21 +++++++++++++++++++++\n src/qcam/settings/control_frame.h | 3 +++\n 2 files changed, 24 insertions(+)","diff":"diff --git a/src/qcam/settings/control_frame.cpp b/src/qcam/settings/control_frame.cpp\nindex 2554f70d..9e38da37 100644\n--- a/src/qcam/settings/control_frame.cpp\n+++ b/src/qcam/settings/control_frame.cpp\n@@ -16,6 +16,8 @@\n #include \n #include \n \n+#include \"slider.h\"\n+\n using namespace libcamera;\n \n ControlFrame::ControlFrame(const ControlId *control,\n@@ -78,6 +80,19 @@ QWidget *ControlFrame::controlInteraction(QWidget *parent)\n \t\tHCheckBoxLayout->setMargin(0);\n \t\treturn containerWidget;\n \t}\n+\tcase ControlTypeFloat: {\n+\t\tfloatSlider_ = new FloatSlider;\n+\t\tfloatSlider_->setRange(controlInfo_.min().get(),\n+\t\t\t\t controlInfo_.max().get());\n+\t\tfloatSlider_->setValue(controlInfo_.def().get());\n+\t\tfloatSlider_->setOrientation(Qt::Orientation::Horizontal);\n+\n+\t\tconnect(floatSlider_, &FloatSlider::valueChanged,\n+\t\t\tthis, &ControlFrame::notifyControlChange);\n+\n+\t\tSliderLayout *fSliderLayout = new SliderLayout(floatSlider_, this);\n+\t\treturn fSliderLayout;\n+\t}\n \tdefault:\n \t\treturn (new QLabel(\"Currently Unavailable\"));\n \t}\n@@ -113,6 +128,9 @@ void ControlFrame::setCurrentValue(const libcamera::ControlValue controlValue)\n \t\telse\n \t\t\tcurrentValue_->setText(\"False\");\n \t\tbreak;\n+\tcase ControlTypeFloat:\n+\t\tcurrentValue_->setText(QString::number(controlValue.get()));\n+\t\tbreak;\n \tdefault:\n \t\tbreak;\n \t}\n@@ -140,6 +158,9 @@ void ControlFrame::notifyControlChange()\n \t\telse\n \t\t\tcontrolValue.set(false);\n \n+\t\tbreak;\n+\tcase ControlTypeFloat:\n+\t\tcontrolValue.set(floatSlider_->value());\n \t\tbreak;\n \tdefault:\n \t\t/* Nothing to emit so return */\ndiff --git a/src/qcam/settings/control_frame.h b/src/qcam/settings/control_frame.h\nindex 9c3b059b..e9e256aa 100644\n--- a/src/qcam/settings/control_frame.h\n+++ b/src/qcam/settings/control_frame.h\n@@ -15,6 +15,8 @@\n #include \n #include \n \n+#include \"slider.h\"\n+\n class ControlFrame : public QFrame\n {\n \tQ_OBJECT\n@@ -44,6 +46,7 @@ private:\n \n \tQCheckBox *controlCheckBox_;\n \tQLabel *currentValue_;\n+\tFloatSlider *floatSlider_;\n \n \t/* Helper Hunctions */\n \tQString getDefaultValueQStr();\n","prefixes":["libcamera-devel","v2","09/11"]}