{"id":17100,"url":"https://patchwork.libcamera.org/api/1.1/patches/17100/?format=json","web_url":"https://patchwork.libcamera.org/patch/17100/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220812124651.27496-5-utkarsh02t@gmail.com>","date":"2022-08-12T12:46:44","name":"[libcamera-devel,v2,04/11] qcam: ControlsTab: Implement QScrollArea","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bacd3147107eaf8cc3b4ff33cd57d46899e81bf6","submitter":{"id":114,"url":"https://patchwork.libcamera.org/api/1.1/people/114/?format=json","name":"Utkarsh Tiwari","email":"utkarsh02t@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17100/mbox/","series":[{"id":3410,"url":"https://patchwork.libcamera.org/api/1.1/series/3410/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3410","date":"2022-08-12T12:46:40","name":"Introduce control interaction to qcam","version":2,"mbox":"https://patchwork.libcamera.org/series/3410/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17100/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17100/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73393BE173\n\tfor ;\n\tFri, 12 Aug 2022 12:47:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29FA86332C;\n\tFri, 12 Aug 2022 14:47:14 +0200 (CEST)","from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com\n\t[IPv6:2607:f8b0:4864:20::1029])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93FDF63328\n\tfor ;\n\tFri, 12 Aug 2022 14:47:12 +0200 (CEST)","by mail-pj1-x1029.google.com with SMTP id ha11so921810pjb.2\n\tfor ;\n\tFri, 12 Aug 2022 05:47:12 -0700 (PDT)","from localhost.localdomain ([2404:bd00:3:dc0d:d8e:96a2:2dbe:5a83])\n\tby smtp.gmail.com with ESMTPSA id\n\te6-20020a17090a728600b001f069352d73sm1431785pjg.25.2022.08.12.05.47.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 12 Aug 2022 05:47:10 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660308434;\n\tbh=3mc+syPrI82F4rhVHk8MS62FrCry/Q0jomW8Ex+wT7c=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=oVQo44/ZPjtX0RHG4C+T19FMelzhp7x80xUW4N8OBEAJDjB29Q7GDzD8NGBLfM0Hd\n\tfAHxYAIi/46hRUgjrpH2fz4Q67DFleIWvKO8/Mv2twseHMhfZmxGyS5+OO3RbNPL1k\n\tihLPW2LGNqTpPF+pj0saNh8hLqgSHpuWczqogfH6X991AMO1jk2O85NSI9j8AJRqSq\n\tFfskvJuXEcOi3Uq46ZrRSEFsJ5nRMSNX2eofuj6R1VKQuuIl6/cTLJv8N3XZ2ZS0X8\n\tyxfWzoaNiI+JNtOam6cOtty/g6D3tNtS8W41nENAYxL1kZ2arIygF5PiKvppuvhPbr\n\tw81ex0A0CH0jQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc;\n\tbh=CcoTbYUj3cSt0YMH+9NqHU45gZLE6JusliHQMFRScRI=;\n\tb=lJ/DKbTPbFjd17l3JGM6dJPQO9W613j1FcUVpzfV3uuqVVd0tb8rybCj7upu8hfGGr\n\tzZJOaYRNiaex1JHTXbA3m6xPXW80CdeK294cjhfLaZ4bVE8EE6wh3/aoyUr/vY+1TSk9\n\ttw9ujrXXkTI9QDcdDJL41TSYrlbyTShlkUSUe17g6vHO03CamGMvJbHhmqqsCzEf1wSx\n\t6PM5+/Su1t/2HOfTn2wWpJh3PhMPZe745Sm0SMUmiuwGCgP5F7UzIzCj6v6Fqxa5BzF/\n\tbq9mmY0F2kQ2FMM2kjzm/DH0kj3zPeKY5TabTIhlHmGcU25YULL7yoCrvwuHNfMoM0k7\n\tZkuw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lJ/DKbTP\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc;\n\tbh=CcoTbYUj3cSt0YMH+9NqHU45gZLE6JusliHQMFRScRI=;\n\tb=1zXgsPAYiCnxFRwUhgT07IHEqHSn2KIDAyLH8DCHcDeUSaJ+x5hfIlp75l1vw20B9P\n\tOxjhdf6uSU36oiT0pxTWvnCo/qkVYRIueRNseWJR49Nlkdwaqxu96WYp4gIgIkS//KEA\n\tM1WyQ8Ok6gp4IVg6rYU4LXUVIDAJqkLb8ZYmuA7D5fTDUPhXPREOIggd9HFz0GhK+ozD\n\tR7vmy1l6E80vikYvYPinkVa3EHwIyCO4JBnETfzqD7MY4Z8X/Um9CRqpb1ibnERgA+vC\n\tOwHe8mGhCIkflAZ74rgtVANANfXgnO0hoqDZgQXK2YAYqaDb/kjNUdUvYJ1Rr0pQULKn\n\tI4wA==","X-Gm-Message-State":"ACgBeo2SKo3sRU1X0P2+7erLB2sFEECIRIQIkpHN1rpOwMDYx24nMItm\n\tOCqHesH1rWOJQdFnJ7DKUtn7FtHPx/Q=","X-Google-Smtp-Source":"AA6agR525tLOb329TyGMh1K2yBfZ8CJKc4XTKUmn3+msOTkr2walvgcpWrc+rKRd4aeL53OhfvMrAg==","X-Received":"by 2002:a17:90a:1912:b0:1f7:8c6c:4fde with SMTP id\n\t18-20020a17090a191200b001f78c6c4fdemr4067484pjg.8.1660308430794; \n\tFri, 12 Aug 2022 05:47:10 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 12 Aug 2022 18:16:44 +0530","Message-Id":"<20220812124651.27496-5-utkarsh02t@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220812124651.27496-1-utkarsh02t@gmail.com>","References":"<20220812124651.27496-1-utkarsh02t@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 04/11] qcam: ControlsTab: Implement\n\tQScrollArea","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Utkarsh Tiwari via libcamera-devel\n\t","Reply-To":"Utkarsh Tiwari ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If the camera has lots of controls it can overrun the screen.\nFix this by using a QScrollArea.\n\nSigned-off-by: Utkarsh Tiwari \n---\n src/qcam/settings/controls_tab.cpp | 9 +++++++--\n src/qcam/settings/controls_tab.h | 3 ++-\n 2 files changed, 9 insertions(+), 3 deletions(-)","diff":"diff --git a/src/qcam/settings/controls_tab.cpp b/src/qcam/settings/controls_tab.cpp\nindex 0777d708..30899783 100644\n--- a/src/qcam/settings/controls_tab.cpp\n+++ b/src/qcam/settings/controls_tab.cpp\n@@ -13,6 +13,7 @@\n \n #include \n #include \n+#include \n #include \n \n #include \"control_frame.h\"\n@@ -21,10 +22,11 @@ using namespace libcamera;\n \n ControlsTab::ControlsTab(std::shared_ptr camera_,\n \t\t\t QWidget *parent)\n-\t: QWidget(parent), controlList_(std::make_shared())\n+\t: QScrollArea(parent), controlList_(std::make_shared())\n {\n+\tQWidget *containerWidget = new QWidget(this);\n \t/* Main Layout for the tab */\n-\tQGridLayout *controlGLayout = new QGridLayout(this);\n+\tQGridLayout *controlGLayout = new QGridLayout(containerWidget);\n \n \tint controlCount = 0;\n \tfor (auto &[control, info] : camera_->controls()) {\n@@ -39,6 +41,9 @@ ControlsTab::ControlsTab(std::shared_ptr camera_,\n \n \tif (controlCount == 0)\n \t\tcontrolGLayout->addWidget(new QLabel(\"No controls available\"));\n+\n+\t/* Set widget and policies for the scrollarea */\n+\tsetWidget(containerWidget);\n }\n \n /* -----------------------------------------------------------------------------\ndiff --git a/src/qcam/settings/controls_tab.h b/src/qcam/settings/controls_tab.h\nindex 5bac7d48..28efd35e 100644\n--- a/src/qcam/settings/controls_tab.h\n+++ b/src/qcam/settings/controls_tab.h\n@@ -11,10 +11,11 @@\n \n #include \n \n+#include \n #include \n #include \n \n-class ControlsTab : public QWidget\n+class ControlsTab : public QScrollArea\n {\n \tQ_OBJECT\n \n","prefixes":["libcamera-devel","v2","04/11"]}