{"id":17040,"url":"https://patchwork.libcamera.org/api/1.1/patches/17040/?format=json","web_url":"https://patchwork.libcamera.org/patch/17040/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220809143531.7473-2-rishikeshdonadkar@gmail.com>","date":"2022-08-09T14:35:30","name":"[libcamera-devel,v2,1/2] gstreamer: Provide ColorSpace => colorimetry mappings","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f3e2a50d37d7ad7db1ca80fa981b9184b1b2fd4f","submitter":{"id":118,"url":"https://patchwork.libcamera.org/api/1.1/people/118/?format=json","name":"Rishikesh Donadkar","email":"rishikeshdonadkar@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17040/mbox/","series":[{"id":3396,"url":"https://patchwork.libcamera.org/api/1.1/series/3396/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3396","date":"2022-08-09T14:35:29","name":"Multiple colorimetry support for libcamerasrc.","version":2,"mbox":"https://patchwork.libcamera.org/series/3396/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17040/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17040/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73611C3272\n\tfor ;\n\tTue, 9 Aug 2022 14:36:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17A176332F;\n\tTue, 9 Aug 2022 16:36:02 +0200 (CEST)","from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com\n\t[IPv6:2607:f8b0:4864:20::102e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB71A61FAA\n\tfor ;\n\tTue, 9 Aug 2022 16:36:00 +0200 (CEST)","by mail-pj1-x102e.google.com with SMTP id\n\tp14-20020a17090a74ce00b001f4d04492faso12359394pjl.4\n\tfor ;\n\tTue, 09 Aug 2022 07:36:00 -0700 (PDT)","from localhost.localdomain ([49.36.99.220])\n\tby smtp.googlemail.com with ESMTPSA id\n\th12-20020a17090ac38c00b001f4fb21c11asm10269264pjt.21.2022.08.09.07.35.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Aug 2022 07:35:58 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660055762;\n\tbh=awl4xklTtuUU5Mb59OEOY17zUCdX1Th1MBNR3eCSro8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=GmAdukRs3IqVWyG0RcWHiv0Ji1sTKPtJLoPa3/1dfJdNJeKvb+xhH9dnDbjg6DEls\n\tVPP9AaSNlfsLBNlvxP5ZI0Ks8mrRg3aVI0LtkWGJAM45+/ric0TA2N5h4IMg4GoHRB\n\t8AtWKm2M179GajwQuY4DAzpY0eprGPnXBLj2mrUlq3+Z3Dr1nrgeM20uy3/lpPBaK8\n\tMOIQUV3qd8qUNynXJQE8kVs9ueaprReIak1vvBWB0Z0dNW++oDR2XdGNOSRVIEKDGN\n\tscUl2G0puIbXBA2XkDg/Tqt1USCW3kmXRyOiZuUyLMBkwOGvl3ZTYSd65ajzPeMafa\n\tYO5h0zqonbTow==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc;\n\tbh=pPvN2mIa4PubgtmGzgfN7j7/BdvXVBboFMCswkgpSAQ=;\n\tb=WlL/bmKF0yH4CzBCmqR+mKG52M43X2O9nLLOVvkZkPVvQ+sFh8nyoU4wl5Xjljn2tH\n\tXqkFMAaDe9N2rk9+le2KiYBRgpKuIGQ6uA0/1usS2+KFI0BVH7yFQtAEBixilN8reExo\n\t5eVTQm9wqSk3bFi5zjuHBPXlEjndYgkgotNHPnOF9UjwQDL8tndIuA6MedV11oOp7Jj8\n\tZybNtuYmWNhVrf3t/lXpkOiF3xEPwOl/iNKRkDMUV25WZreKx8dKKyHju5sH0klUs/FR\n\t+vnDaXOBvWTkAPG9bFqjyOVZXCsioqWOFUIjDT0KB4d1VHuqlWrB2Ylf3Xn2QZuyxxlt\n\tRidg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"WlL/bmKF\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc;\n\tbh=pPvN2mIa4PubgtmGzgfN7j7/BdvXVBboFMCswkgpSAQ=;\n\tb=eRMDLxvsQQ+oLMdi2dfPt977ZRwlxx7vJwCj8KQbNQ16DsPdiXPw4h5uA9omC9tV7n\n\tOmnaM7XS4hebV7hKBh0wkU3oEAcAcou1uZm7s6Tx8ZWZ+bcwxXjV4Ho3F+Wbt7sHcIyQ\n\t4t09HDPGHdG5xwlwzCSjzVFW5wlgxQClsbsRa0fMpQp8c/3UbWKYR3a8P2F3O+qPjx2h\n\tuK//aDlvQNv+iyCnkweSsGF3kaejoqLuy/06VCx3F9lRQEBJNC+Y3KfoLasLOLg4Z2Z3\n\tvBk2rY+Yk12qwBBd71MeZ+uB2g5YtZvO8uahajSIzYq2x8FrBJAwsB+Z9f5ZDPnkZ2X1\n\tV2aQ==","X-Gm-Message-State":"ACgBeo1DOoz/qY57LbI6C0cWiGAafJXAFH/cwUjTq1rDF2Py5xyy6R5o\n\tB9qf397gvmSCbdZDrVE8/eUCHzKgVRF8NChV","X-Google-Smtp-Source":"AA6agR4sNxXlJhl+4iE/anhRbe9OrSOMS1Se/+OfeMFMlIbpuEWyWjjAv1y7fFtq3EpCDRysf2VB8A==","X-Received":"by 2002:a17:903:24e:b0:16b:a02d:41fc with SMTP id\n\tj14-20020a170903024e00b0016ba02d41fcmr23933162plh.121.1660055759104; \n\tTue, 09 Aug 2022 07:35:59 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 9 Aug 2022 20:05:30 +0530","Message-Id":"<20220809143531.7473-2-rishikeshdonadkar@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220809143531.7473-1-rishikeshdonadkar@gmail.com>","References":"<20220809143531.7473-1-rishikeshdonadkar@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/2] gstreamer: Provide ColorSpace =>\n\tcolorimetry mappings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Rishikesh Donadkar via libcamera-devel\n\t","Reply-To":"Rishikesh Donadkar ","Cc":"Rishikesh Donadkar ,\n\tnicolas.dufresne@collabora.com, vedantparanjape160201@gmail.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide libcamera::ColorSpace => colorimetry mappings via:\n- GstVideoColorimetry colorimetry_from_colorspace(colorspace);\n\nRead the ColorSpace from the StreamConfiguration, convert it to\ncolorimetry and update the colorimetry into the caps.\n\nThis patch handles colorimetry in libcamera->GStreamer direction.\nColorimetry support form GStreamer->libcamera direction is provided\nthe next patch.\n\nSigned-off-by: Rishikesh Donadkar \nSigned-off-by: Umang Jain \n---\n src/gstreamer/gstlibcamera-utils.cpp | 71 ++++++++++++++++++++++++++++\n 1 file changed, 71 insertions(+)","diff":"diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex c97c0d43..dbb47c5a 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -45,6 +45,65 @@ static struct {\n \t/* \\todo NV42 is used in libcamera but is not mapped in GStreamer yet. */\n };\n \n+static GstVideoColorimetry\n+colorimetry_from_colorspace(const ColorSpace &colorSpace)\n+{\n+\tGstVideoColorimetry colorimetry;\n+\n+\tswitch (colorSpace.primaries) {\n+\tcase ColorSpace::Primaries::Raw:\n+\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_UNKNOWN;\n+\t\tbreak;\n+\tcase ColorSpace::Primaries::Smpte170m:\n+\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_SMPTE170M;\n+\t\tbreak;\n+\tcase ColorSpace::Primaries::Rec709:\n+\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_BT709;\n+\t\tbreak;\n+\tcase ColorSpace::Primaries::Rec2020:\n+\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_BT2020;\n+\t\tbreak;\n+\t}\n+\n+\tswitch (colorSpace.transferFunction) {\n+\tcase ColorSpace::TransferFunction::Linear:\n+\t\tcolorimetry.transfer = GST_VIDEO_TRANSFER_GAMMA10;\n+\t\tbreak;\n+\tcase ColorSpace::TransferFunction::Srgb:\n+\t\tcolorimetry.transfer = GST_VIDEO_TRANSFER_SRGB;\n+\t\tbreak;\n+\tcase ColorSpace::TransferFunction::Rec709:\n+\t\tcolorimetry.transfer = GST_VIDEO_TRANSFER_BT709;\n+\t\tbreak;\n+\t}\n+\n+\tswitch (colorSpace.ycbcrEncoding) {\n+\tcase ColorSpace::YcbcrEncoding::None:\n+\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_RGB;\n+\t\tbreak;\n+\tcase ColorSpace::YcbcrEncoding::Rec601:\n+\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT601;\n+\t\tbreak;\n+\tcase ColorSpace::YcbcrEncoding::Rec709:\n+\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT709;\n+\t\tbreak;\n+\tcase ColorSpace::YcbcrEncoding::Rec2020:\n+\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT2020;\n+\t\tbreak;\n+\t}\n+\n+\tswitch (colorSpace.range) {\n+\tcase ColorSpace::Range::Full:\n+\t\tcolorimetry.range = GST_VIDEO_COLOR_RANGE_0_255;\n+\t\tbreak;\n+\tcase ColorSpace::Range::Limited:\n+\t\tcolorimetry.range = GST_VIDEO_COLOR_RANGE_16_235;\n+\t\tbreak;\n+\t}\n+\n+\treturn colorimetry;\n+}\n+\n static GstVideoFormat\n pixel_format_to_gst_format(const PixelFormat &format)\n {\n@@ -139,6 +198,18 @@ gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg\n \t\t\t \"width\", G_TYPE_INT, stream_cfg.size.width,\n \t\t\t \"height\", G_TYPE_INT, stream_cfg.size.height,\n \t\t\t nullptr);\n+\n+\tif (stream_cfg.colorSpace) {\n+\t\tGstVideoColorimetry colorimetry = colorimetry_from_colorspace(stream_cfg.colorSpace.value());\n+\t\tgchar *colorimetry_str = gst_video_colorimetry_to_string(&colorimetry);\n+\n+\t\tif (colorimetry_str)\n+\t\t\tgst_structure_set(s, \"colorimetry\", G_TYPE_STRING, colorimetry_str, nullptr);\n+\t\telse\n+\t\t\tg_error(\"Got invalid colorimetry from ColorSpace: %s\",\n+\t\t\t\tColorSpace::toString(stream_cfg.colorSpace).c_str());\n+\t}\n+\n \tgst_caps_append_structure(caps, s);\n \n \treturn caps;\n","prefixes":["libcamera-devel","v2","1/2"]}