{"id":17033,"url":"https://patchwork.libcamera.org/api/1.1/patches/17033/?format=json","web_url":"https://patchwork.libcamera.org/patch/17033/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220808230833.16275-3-laurent.pinchart@ideasonboard.com>","date":"2022-08-08T23:08:31","name":"[libcamera-devel,v2,2/4] libcamera: pub_key: Gracefully handle failures to load public key","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7300d5656ebc5edb8d8f6370814cd8413e4a17f2","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17033/mbox/","series":[{"id":3392,"url":"https://patchwork.libcamera.org/api/1.1/series/3392/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3392","date":"2022-08-08T23:08:29","name":"libcamera: Support openssl as an alternative to gnutls","version":2,"mbox":"https://patchwork.libcamera.org/series/3392/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17033/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17033/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42B1BC3272\n\tfor ;\n\tMon, 8 Aug 2022 23:08:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0751A63333;\n\tTue, 9 Aug 2022 01:08:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD9C06332E\n\tfor ;\n\tTue, 9 Aug 2022 01:08:46 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5846F56D;\n\tTue, 9 Aug 2022 01:08:46 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660000129;\n\tbh=VieJwiGRICkhDuun+18JfNtghQfNkU4dOuNkXashPhM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=CnDXfk9OEt+GxgnfVFoSUYmoDFq7GEgYC54V1boVx+qAr1beIkYiCermJ+QpVq+MZ\n\tS8jaap4q1nF1JCLpqv3tlLW/47o7vFEgHvqkjq4I8NMT1bb6bynqMtG1wYtLWekBb0\n\tq5hqCOyVum4I74Cdq9Up6BA4X+18bKfGDNfuXbswXdEPhNJfetjwfdHufJwYtcZzbk\n\tOlEyh0Y46QqunXCFPxuH4pPdJaVV7BgKCL1tH/6dVKDoeSrwXeYnAjA9yNmd1JrYCR\n\tUPL7XRTE0OBsiws/53TgaM48jfmgTuBNJ5VSOs++V0oNAVPNEe2RtE9ZrhnBZyd2w0\n\tuKD7UMfg9b2tQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660000126;\n\tbh=VieJwiGRICkhDuun+18JfNtghQfNkU4dOuNkXashPhM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TfV9WuSzfhUTJyMEO8RYA7JB5F3S1fOOMQXSMVkcV64kye/us42Fj8Bi6j00CKdKA\n\tdJN9zz/K+16/SF/1itT+hl8t2vqmfSoQl8R80YnJVDXiaL3zXDbQ1FKsBRaJllwYoE\n\thgyt1B+UuPdWhmBlE4GJCzz+xCL/hm7/pk0qjk+0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TfV9WuSz\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 9 Aug 2022 02:08:31 +0300","Message-Id":"<20220808230833.16275-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220808230833.16275-1-laurent.pinchart@ideasonboard.com>","References":"<20220808230833.16275-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 2/4] libcamera: pub_key: Gracefully\n\thandle failures to load public key","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If the public key fails to load, PubKey::isValid() function returns\nfalse. The only user of the PubKey class, the IPAManager class, doesn't\ncheck that condition, and still calls the PubKey::verify() function,\nwhich leads to a crash.\n\nFix this by returning false from PubKey::verify() if the key isn't\nvalid, and log a warning in the IPAManager constructor to report the\nissue.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/ipa_manager.cpp | 3 +++\n src/libcamera/pub_key.cpp | 3 +++\n 2 files changed, 6 insertions(+)","diff":"diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex ec9660456960..2f96a2072fd6 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -109,6 +109,9 @@ IPAManager::IPAManager()\n \t\tLOG(IPAManager, Fatal)\n \t\t\t<< \"Multiple IPAManager objects are not allowed\";\n \n+\tif (!pubKey_.isValid())\n+\t\tLOG(IPAManager, Warning) << \"Public key not valid\";\n+\n \tunsigned int ipaCount = 0;\n \n \t/* User-specified paths take precedence. */\ndiff --git a/src/libcamera/pub_key.cpp b/src/libcamera/pub_key.cpp\nindex 9bb08fda34af..b2045a103bc0 100644\n--- a/src/libcamera/pub_key.cpp\n+++ b/src/libcamera/pub_key.cpp\n@@ -76,6 +76,9 @@ PubKey::~PubKey()\n bool PubKey::verify([[maybe_unused]] Span data,\n \t\t [[maybe_unused]] Span sig) const\n {\n+\tif (!valid_)\n+\t\treturn false;\n+\n #if HAVE_GNUTLS\n \tconst gnutls_datum_t gnuTlsData{\n \t\tconst_cast(data.data()),\n","prefixes":["libcamera-devel","v2","2/4"]}