{"id":17005,"url":"https://patchwork.libcamera.org/api/1.1/patches/17005/?format=json","web_url":"https://patchwork.libcamera.org/patch/17005/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220807021718.9789-2-laurent.pinchart@ideasonboard.com>","date":"2022-08-07T02:17:15","name":"[libcamera-devel,1/4] cam: sdl_texture_yuyv: Make line stride configurable","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ddeb321e2f7a224a36682710a681d4fd3224d30f","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17005/mbox/","series":[{"id":3381,"url":"https://patchwork.libcamera.org/api/1.1/series/3381/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3381","date":"2022-08-07T02:17:14","name":"cam: Add support for NV12 in the SDL sink","version":1,"mbox":"https://patchwork.libcamera.org/series/3381/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17005/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17005/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D95AEBE173\n\tfor ;\n\tSun, 7 Aug 2022 02:17:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 514DB6332F;\n\tSun, 7 Aug 2022 04:17:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86E2263325\n\tfor ;\n\tSun, 7 Aug 2022 04:17:28 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E60E749;\n\tSun, 7 Aug 2022 04:17:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659838650;\n\tbh=fMcU8iv+QcFfB6PnVplcf+n6XKNjTQQd6jhd4MaRAXI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=WEH/uVeQL+EjgKuAadPLNpIw4jaqUCOX52QhDD0J22CfxjH8qHn8zBPlT9MEGQuHV\n\ttB8o9qL2JNFh2xCKrLGWgyLWo/weenHJsYlQ0sNL1AZ9/1AFX4nnFoB30zv3eE2WDw\n\tI6Q5ML+WFXoLZwqUQSacdrdnS3hPGm72TfOYHziX3lIkMzX0O4Cu9OfBLBO3eQS0mE\n\tQUjLTcu3tcg3+WGXKaHWt+nn6iru1R9qafs6xDO57t9D8xWe8Cbeqh5kQAPX8enGEZ\n\txqiibrRrks8V7ghRFeE2RfpKaw9RKxzO32PP31Ft51LzLb6UDOoItA0pbiOlJoarUT\n\tHgQkdMjs0qgCA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659838648;\n\tbh=fMcU8iv+QcFfB6PnVplcf+n6XKNjTQQd6jhd4MaRAXI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BPdF4Y+stEQuFV0TjyBP5dpjS3DuvniBE8APHGOhXHijBsFIzESuPOxtdk7MWovzs\n\t2MjZ/r42sLuRCq1qZrzSfAwCjsWgxsa5P5yJcgQyr1rIKL+gW+b4JOZjG/2d/gbbIZ\n\tBPwDTF0ppefpl8a8LbR614cQyMrBYiOIKpSB35XY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BPdF4Y+s\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 7 Aug 2022 05:17:15 +0300","Message-Id":"<20220807021718.9789-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220807021718.9789-1-laurent.pinchart@ideasonboard.com>","References":"<20220807021718.9789-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/4] cam: sdl_texture_yuyv: Make line\n\tstride configurable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The line stride of the texture is currently hardcoded based on the image\nwidth, which may not match the real stride. Use the stride value from\nthe stream configuration instead.\n\nSigned-off-by: Laurent Pinchart \n---\n src/cam/sdl_sink.cpp | 2 +-\n src/cam/sdl_texture_yuyv.cpp | 4 ++--\n src/cam/sdl_texture_yuyv.h | 2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/cam/sdl_sink.cpp b/src/cam/sdl_sink.cpp\nindex 19fdfd6dced5..a59d07519e1f 100644\n--- a/src/cam/sdl_sink.cpp\n+++ b/src/cam/sdl_sink.cpp\n@@ -68,7 +68,7 @@ int SDLSink::configure(const libcamera::CameraConfiguration &config)\n \t\tbreak;\n #endif\n \tcase libcamera::formats::YUYV:\n-\t\ttexture_ = std::make_unique(rect_);\n+\t\ttexture_ = std::make_unique(rect_, cfg.stride);\n \t\tbreak;\n \tdefault:\n \t\tstd::cerr << \"Unsupported pixel format \"\ndiff --git a/src/cam/sdl_texture_yuyv.cpp b/src/cam/sdl_texture_yuyv.cpp\nindex 637c0900edff..cb51fb0ef478 100644\n--- a/src/cam/sdl_texture_yuyv.cpp\n+++ b/src/cam/sdl_texture_yuyv.cpp\n@@ -9,8 +9,8 @@\n \n using namespace libcamera;\n \n-SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect)\n-\t: SDLTexture(rect, SDL_PIXELFORMAT_YUY2, 4 * ((rect.w + 1) / 2))\n+SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n+\t: SDLTexture(rect, SDL_PIXELFORMAT_YUY2, stride)\n {\n }\n \ndiff --git a/src/cam/sdl_texture_yuyv.h b/src/cam/sdl_texture_yuyv.h\nindex 529a72d6a40e..81e51381ec62 100644\n--- a/src/cam/sdl_texture_yuyv.h\n+++ b/src/cam/sdl_texture_yuyv.h\n@@ -12,6 +12,6 @@\n class SDLTextureYUYV : public SDLTexture\n {\n public:\n-\tSDLTextureYUYV(const SDL_Rect &rect);\n+\tSDLTextureYUYV(const SDL_Rect &rect, unsigned int stride);\n \tvoid update(libcamera::Span data) override;\n };\n","prefixes":["libcamera-devel","1/4"]}