{"id":16978,"url":"https://patchwork.libcamera.org/api/1.1/patches/16978/?format=json","web_url":"https://patchwork.libcamera.org/patch/16978/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220805135312.47497-4-jacopo@jmondi.org>","date":"2022-08-05T13:53:05","name":"[libcamera-devel,v2,03/10] libcamera: request: Add PFCError flag","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"2ac977ef90c09673d0721ce3e987268f5ef0bb72","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16978/mbox/","series":[{"id":3376,"url":"https://patchwork.libcamera.org/api/1.1/series/3376/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3376","date":"2022-08-05T13:53:02","name":"libcamera: Align IPU3 and RKISP1 interfaces","version":2,"mbox":"https://patchwork.libcamera.org/series/3376/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16978/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16978/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9998C3275\n\tfor ;\n\tFri, 5 Aug 2022 13:53:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4B3E6332F;\n\tFri, 5 Aug 2022 15:53:26 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30F89603E4\n\tfor ;\n\tFri, 5 Aug 2022 15:53:24 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 848F71C0012;\n\tFri, 5 Aug 2022 13:53:23 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659707606;\n\tbh=2AuALeaWK3ekNcY6FS53UwHJn0pgH0MB7qqVKxmO7eo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xj1NWFy4xp14oZylMD1XaaYcgdI+vFfB7DGvKiZinfQ83jWIvFV07S/wuhKnwFeGe\n\tRh8ZsAp+Y3GU6WLd1Ef8zUuW+kH3KNYDf6BGAp7fG1rcQrwm4LWvZGyZNrk/8H437W\n\tGsnaKFq5rfG0KDewz6yQ16sroyogznHpawMUB2PkZ7+Ewqb7uZiCU8//5dWMvTGxgH\n\tJnVPiOGaV/T9eSCwMtby1xm51cgoNBzQzAKW6yzaNMZO1ZJ1gWXCUNgxpV1Ceh8LcV\n\ti4LEW44xSUnIpr6BH1BlM5Yiu4cylSzcRCS6PP9EV5nXB/+dG20aFFQsHnB7EE44Sw\n\tscdqkck1Bd2UA==","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 5 Aug 2022 15:53:05 +0200","Message-Id":"<20220805135312.47497-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.37.1","In-Reply-To":"<20220805135312.47497-1-jacopo@jmondi.org>","References":"<20220805135312.47497-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 03/10] libcamera: request: Add PFCError\n\tflag","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Kieran Bingham via libcamera-devel \n\nProvide a new flag for the Request error state to indicate that a\nper-frame control error has occurred. One or more controls set for this\nrequest could not be guaranteed on this frame.\n\nSigned-off-by: Kieran Bingham \nReviewed-by: Jacopo Mondi \nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/request.h | 1 +\n src/libcamera/request.cpp | 4 ++++\n 2 files changed, 5 insertions(+)","diff":"diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 3304da31200d..9aee81922c91 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -47,6 +47,7 @@ public:\n \tenum ErrorFlag {\n \t\tNoError = 0,\n \t\tControlError = (1 << 0),\n+\t\tPFCError = (1 << 1),\n \t};\n \n \tusing Errors = Flags;\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 9a808f19fc03..b93eaac75880 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -346,6 +346,10 @@ void Request::Private::timeout()\n * Control Error. At least one control was not applied correctly to the camera.\n * The application should compare the metadata to the requested control values\n * to check which controls weren't applied.\n+ *\n+ * \\var Request::PFCError\n+ * A per-frame-control error has occured. Controls that were expected to be set\n+ * during the processing of this request were not processed in time.\n */\n \n /**\n","prefixes":["libcamera-devel","v2","03/10"]}