{"id":16897,"url":"https://patchwork.libcamera.org/api/1.1/patches/16897/?format=json","web_url":"https://patchwork.libcamera.org/patch/16897/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220802100955.1546-4-laurent.pinchart@ideasonboard.com>","date":"2022-08-02T10:09:54","name":"[libcamera-devel,RFC,3/4] ipa: ipu3: Register algorithms","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"402b05a5a0df91a63812c0d4baa93e8e9f1db0de","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16897/mbox/","series":[{"id":3356,"url":"https://patchwork.libcamera.org/api/1.1/series/3356/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3356","date":"2022-08-02T10:09:51","name":"Add tuning data file support to the IPU3 IPA module","version":1,"mbox":"https://patchwork.libcamera.org/series/3356/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16897/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16897/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12DECC3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  2 Aug 2022 10:10:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36D8263315;\n\tTue,  2 Aug 2022 12:10:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FED2603E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  2 Aug 2022 12:10:04 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CDC1C25B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  2 Aug 2022 12:10:03 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659435005;\n\tbh=AmB1e30hGxPfzVY3M6vh363cczc+bdNJ2fvani0M8Y4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=tBGrgrnrDuO2IofvgK+UA1s587Hm6TYr4a7e+OVupRmbCMl9chhcmnqPRHg7lABDp\n\tJF+SU+1QAFed7m8NWDsZIUchw/r4Vz5/wrGnQvrU5bT/P+1V4Nxo40mLJkDUdEs/n/\n\t9rYpiLt0Rsne7IINk/jzJKbCaQMLRMJXsTWMdp++6iT4Vn7ORVDa4su3qto4lVh9VW\n\to3KaMsbWRIVO0vpybGayGscTDPpchRgr27vtwoalYA0Yx2lsMDikK/HW3MkQvApbZg\n\tG+KQP1qi7gAq3YN8umErjqMpEA0/ZnVmuVorW5dCdlYG66TG2cLYN2k/7rm4Zh428k\n\tU2azBmxkqdeWA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659435004;\n\tbh=AmB1e30hGxPfzVY3M6vh363cczc+bdNJ2fvani0M8Y4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=I9lPqiVx+WjcbKd07sH6k+/8hvJ3zI0O5ihFhBS476GU1At51yzIEDmxONIG0PCPO\n\t1aRqe+gV/ApTlF/m6jPPegOoPVBJtWKls2yI0XAKzAgkelq3A2XJpzZ7t5YphZhi10\n\tUEOmk+W3VL288hNpMUL1P0I22qh0Ut/CQWJYPHsY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"I9lPqiVx\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue,  2 Aug 2022 13:09:54 +0300","Message-Id":"<20220802100955.1546-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220802100955.1546-1-laurent.pinchart@ideasonboard.com>","References":"<20220802100955.1546-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 3/4] ipa: ipu3: Register algorithms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"To prepare for dynamic instantiation of algorithms from the tuning file,\nregister the algorithms with the Module class.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/af.cpp           | 2 ++\n src/ipa/ipu3/algorithms/agc.cpp          | 2 ++\n src/ipa/ipu3/algorithms/awb.cpp          | 2 ++\n src/ipa/ipu3/algorithms/blc.cpp          | 2 ++\n src/ipa/ipu3/algorithms/tone_mapping.cpp | 2 ++\n 5 files changed, 10 insertions(+)","diff":"diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\nindex d07521a090ac..4835a0345931 100644\n--- a/src/ipa/ipu3/algorithms/af.cpp\n+++ b/src/ipa/ipu3/algorithms/af.cpp\n@@ -450,6 +450,8 @@ void Af::process(IPAContext &context, [[maybe_unused]] IPAFrameContext *frameCon\n \t}\n }\n \n+REGISTER_IPA_ALGORITHM(Af, \"Af\")\n+\n } /* namespace ipa::ipu3::algorithms */\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 5bc64ae52214..ed4809d98007 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -363,6 +363,8 @@ void Agc::process(IPAContext &context, [[maybe_unused]] IPAFrameContext *frameCo\n \tframeCount_++;\n }\n \n+REGISTER_IPA_ALGORITHM(Agc, \"Agc\")\n+\n } /* namespace ipa::ipu3::algorithms */\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 704267222a31..b658ee546b87 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -483,6 +483,8 @@ void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n \tparams->use.acc_ccm = 1;\n }\n \n+REGISTER_IPA_ALGORITHM(Awb, \"Awb\")\n+\n } /* namespace ipa::ipu3::algorithms */\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/ipu3/algorithms/blc.cpp b/src/ipa/ipu3/algorithms/blc.cpp\nindex 78ab7bff549f..c561aa858b96 100644\n--- a/src/ipa/ipu3/algorithms/blc.cpp\n+++ b/src/ipa/ipu3/algorithms/blc.cpp\n@@ -62,6 +62,8 @@ void BlackLevelCorrection::prepare([[maybe_unused]] IPAContext &context,\n \tparams->use.obgrid_param = 1;\n }\n \n+REGISTER_IPA_ALGORITHM(BlackLevelCorrection, \"BlackLevelCorrection\")\n+\n } /* namespace ipa::ipu3::algorithms */\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/ipu3/algorithms/tone_mapping.cpp b/src/ipa/ipu3/algorithms/tone_mapping.cpp\nindex f86e79b24a67..49a5558b6faa 100644\n--- a/src/ipa/ipu3/algorithms/tone_mapping.cpp\n+++ b/src/ipa/ipu3/algorithms/tone_mapping.cpp\n@@ -105,6 +105,8 @@ void ToneMapping::process(IPAContext &context, [[maybe_unused]] IPAFrameContext\n \tcontext.activeState.toneMapping.gamma = gamma_;\n }\n \n+REGISTER_IPA_ALGORITHM(ToneMapping, \"ToneMapping\")\n+\n } /* namespace ipa::ipu3::algorithms */\n \n } /* namespace libcamera */\n","prefixes":["libcamera-devel","RFC","3/4"]}