{"id":16893,"url":"https://patchwork.libcamera.org/api/1.1/patches/16893/?format=json","web_url":"https://patchwork.libcamera.org/patch/16893/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220802084526.4786-1-david.plowman@raspberrypi.com>","date":"2022-08-02T08:45:26","name":"[libcamera-devel] ipa: raspberrypi: Reset embedded data parser on configure","commit_ref":"91cf84fd4e6d2b416b4545686fa06661e7b945d5","pull_url":null,"state":"accepted","archived":false,"hash":"913eb45bc522024a77d7ea154c59827e2e665b19","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16893/mbox/","series":[{"id":3355,"url":"https://patchwork.libcamera.org/api/1.1/series/3355/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3355","date":"2022-08-02T08:45:26","name":"[libcamera-devel] ipa: raspberrypi: Reset embedded data parser on configure","version":1,"mbox":"https://patchwork.libcamera.org/series/3355/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16893/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16893/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AFDFBE173\n\tfor ;\n\tTue, 2 Aug 2022 08:45:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6FBF63312;\n\tTue, 2 Aug 2022 10:45:45 +0200 (CEST)","from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E73C26330D\n\tfor ;\n\tTue, 2 Aug 2022 10:45:44 +0200 (CEST)","by mail-wr1-x42a.google.com with SMTP id j15so8874983wrr.2\n\tfor ;\n\tTue, 02 Aug 2022 01:45:44 -0700 (PDT)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tk18-20020a5d6d52000000b0021f0c05859esm14101339wri.71.2022.08.02.01.45.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Aug 2022 01:45:43 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659429945;\n\tbh=qViJt9ElRzZ12HFh8sq4bND0DH6WA8prgASElFgc2v4=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=tF59QDZIkecHqHIkdcgX2R91f1EAfRzSZ6zMf0VtqbKzKkZcRD2zD96X1BjFRPslX\n\tCP7WImdSpolHNhC+Yz+sMdlc3cpKpmt89p615FBfgcB5jTe8aB270ROa0QtNrOZ+1+\n\tAd+PRrcmfmrgnQ5JalrTUaMbO82H3pHlBFAowjguzPZ0eRgF2DMzheeTH6zcWCx4AD\n\trzvf1Cr6/PDQR9rqa4yp7vyW3/ViHWgjpoGMJbAEgLD/Jq6XPLQiG9V6s194PCcS+n\n\tXQ8GLDHARMs+WaGAjEgmN8q91ewI0Zjw8cK0xPLcK18G+lJtItu1KXxCVbAx8LBsE8\n\ttkEtnxCRZRwTQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=E1krntqBcBJwd4+qPKQeBz5OU+FqK9ZkyZ44a48mf8g=;\n\tb=Gfsy/ZhF9IUjhv+yLF6NDKYTArbaXDZIIHmp6HvXeAVwlMo7+l4G1eYWhjoFZ9YxR7\n\thMAleG/5B/p3VhBIY2Y6iJd57NY7rkcMm9Xpx4fHGl9YJoPXLrrbugtMEI8ddSL7bnQG\n\tId/B0/WhaiRqXgDs+u+qDIe8xU+cPL3av6d5qkYTnsEtTRiHBC+vEtK19Y1TE0g1q7J8\n\tNlDzGMa0fG1KB1dZtUY5xZkhW/KW7RU/3MCmBy625AHPG625s8Eso+tcjci0UeY7DSTW\n\tE6Hi8bWrh9MK53d9PVaW5r7ZpDwPdWDEvcu47Tp6QFT3en9rKT0C3mZWWmt6xFaey0uU\n\tnkgw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Gfsy/ZhF\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=E1krntqBcBJwd4+qPKQeBz5OU+FqK9ZkyZ44a48mf8g=;\n\tb=xBgDvN+UPDe8pIJyP3ZoPhS0dBR0OXnP2F+cx4rGVnmarCIk8vHhWzMvliXShcADDT\n\tPpkoO0A9L5sqUfb/OWOTmfDE7G6fjOoYPcMQi6Q7vb89NwCjeF4HMk+qnOHsO05qeR8K\n\t/q7vInz+/F1V6j4OsMFYISGRc0KlgSz5Dwk8HtO2e2HGOiyP8NSyl2IDwgpdsLDogqbQ\n\tBvziWgy9n07FM6rfhkWqMMkRU1xJufOvqprMn9DRxmxfEuMrbgkPe0kt5uZL5wBExytt\n\t2be49XZFxpOjdkg5Wpr4Gk+NW3TmVETtVcro+3ZLVkkr+zxqOUM812QlHdgruEPGyQTN\n\tQzSg==","X-Gm-Message-State":"ACgBeo1hJl2BHeEbWlTJawcYMtGlsEi5PGbl2O08e0/+D3qBweyhtXSk\n\tufUz28Y52bUOiNSwD79iqzOjriQxRUuAD/SS","X-Google-Smtp-Source":"AA6agR5Wxqb2sOyuxZ/gh0pINSHhN5MIl7/64B4IfY8QtmxPH/chRtnc7nLeHxU6qeoh007OuBXnAQ==","X-Received":"by 2002:a05:6000:1b83:b0:21e:5254:e014 with SMTP id\n\tr3-20020a0560001b8300b0021e5254e014mr12458624wru.277.1659429944225; \n\tTue, 02 Aug 2022 01:45:44 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 2 Aug 2022 09:45:26 +0100","Message-Id":"<20220802084526.4786-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: raspberrypi: Reset embedded data\n\tparser on configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When we switch camera mode following a pipeline reconfiguration, the\nembedded data parser should be \"reset\" to discard any data that it may\nhave cached and that might now be invalid.\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/cam_helper.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/ipa/raspberrypi/cam_helper.cpp b/src/ipa/raspberrypi/cam_helper.cpp\nindex 37b66198..cac8f39e 100644\n--- a/src/ipa/raspberrypi/cam_helper.cpp\n+++ b/src/ipa/raspberrypi/cam_helper.cpp\n@@ -106,6 +106,7 @@ void CamHelper::setCameraMode(const CameraMode &mode)\n {\n \tmode_ = mode;\n \tif (parser_) {\n+\t\tparser_->reset();\n \t\tparser_->setBitsPerPixel(mode.bitdepth);\n \t\tparser_->setLineLengthBytes(0); /* We use SetBufferSize. */\n \t}\n","prefixes":["libcamera-devel"]}