{"id":16862,"url":"https://patchwork.libcamera.org/api/1.1/patches/16862/?format=json","web_url":"https://patchwork.libcamera.org/patch/16862/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220728120530.4381-1-naush@raspberrypi.com>","date":"2022-07-28T12:05:30","name":"[libcamera-devel] ipa: raspberrypi: Remove unused Controller constructor","commit_ref":"c19150ea94ac095de63fe878282caf3b23dd461f","pull_url":null,"state":"accepted","archived":false,"hash":"ff2d8b1452db46686c5e434cb9e2082ed1251b2f","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16862/mbox/","series":[{"id":3343,"url":"https://patchwork.libcamera.org/api/1.1/series/3343/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3343","date":"2022-07-28T12:05:30","name":"[libcamera-devel] ipa: raspberrypi: Remove unused Controller constructor","version":1,"mbox":"https://patchwork.libcamera.org/series/3343/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16862/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16862/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58E13BE173\n\tfor ;\n\tThu, 28 Jul 2022 12:05:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 253DD63312;\n\tThu, 28 Jul 2022 14:05:37 +0200 (CEST)","from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D24D6330D\n\tfor ;\n\tThu, 28 Jul 2022 14:05:36 +0200 (CEST)","by mail-wr1-x432.google.com with SMTP id u5so1923463wrm.4\n\tfor ;\n\tThu, 28 Jul 2022 05:05:36 -0700 (PDT)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\te15-20020adfe7cf000000b0021e8d205705sm752995wrn.51.2022.07.28.05.05.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 28 Jul 2022 05:05:35 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659009937;\n\tbh=uWPJLtQyZJd4Yz+5VvhrXNnqC7k7NykfEWwUdvRkid0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=YhI24gaq67PbB90Cr7xnouqJtmDVwu2L44WnefKBFbf1fXs3mAZSngwo7zx0l9gwj\n\t/i3iyQMaTnXg7VTT/xo95xOnQH26WTizc0ZpgRiLW9Hy/0PFh7bfSuX61fW3UWX2C8\n\tKcUCKmsX2DM1KoCdVsDjyiEBIs18xOzyq/5xWo4TQk0uQGQsRFHtQ39tv31yjDGqxS\n\td0fxr+dwAX4fl2ddol313tYI+cJs1kbPhYj+IjJDgFblHOqqxhIABOSUKN8mk0iULb\n\tXhwEdQvdGX8mOP617ewMZzyfiBcsHgixcLT1FuYTk3ApOXh7YF67W64rPa/aMwTME8\n\tqC62wWUD/Roow==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=J3GjYIYwifSay6HDg+VFEcdCVrSEjynp26pTorRquDM=;\n\tb=TCT4u0T2oazX5YOfz44o7gcwkcB8leOAxA1PofSMPYE2KNzqILciopLwqJBhgT80Ov\n\tf8bdr2vrIDrzxhXXy1H+lfwip+E29ce0VezS4EWLYF74Brgcy7xTleW1XabycOtkgdTO\n\tkYl3XDgpnktoBkoYMc1XA8pgc2SJJvwl763mt6hFU039h3zbPWwZsSYYTpl7es8D/SlR\n\tER8rBgwCrdEX9h1q2XgoRtWc+Ecf+Z+wcU6yOl1XTY8CvQDRham1/EebaL3U2mUziyoD\n\tBdh3VqpZohiS/D6IkAZ00CPim3ZnBhoM1DJ+UaHPye72/tpHB+qXSsMjjcXkAhF4LeIa\n\t8qPQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"TCT4u0T2\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=J3GjYIYwifSay6HDg+VFEcdCVrSEjynp26pTorRquDM=;\n\tb=EwRZj5dO8JAETV0P+BeawV8JBUco0Zm4rLnuU9/P0UQdWVp2jI4MX9ka3rbXCzlRla\n\tmkLRO1vANxT2bAWseA/BKT9uRGuXHsqN35Cgbqirnwl05oIK7MS2Hlk96lx+QQJF4SvN\n\tX+9xgUyfgItiXc2hfnWtRQs3yn7UEnmeReBTxCnzmtdnxelhy4Z9V2UyvJfBr33AXCRs\n\thMDCsmw9W4OLNdutGZ4A3q2JiBjRbP+vsTJgO+TrPobN4Zs7IHUVVcvEaX2AZC/ULZsr\n\tfZWwhkQImGn0DWuEBgC96METKl8QGStTYPtZ2gBTbvty87t5PtTBigbU7hEN3uz4wQDY\n\txZ7A==","X-Gm-Message-State":"AJIora/bYyQr/EZjsa3Jbo61fU4jtRUhHEkR+ivVJ7tO/f5L8FUr6Wr4\n\t2XaHE9c6RCO4WYT56frG1fb5arAI5CcQRw==","X-Google-Smtp-Source":"AGRyM1vJXfES8bwXpeQ5n3qKSUyf8sTtKItNUz3XosMj0IGEhhTYKGjLt3ySw4mpqE+8AuG/u/SKWQ==","X-Received":"by 2002:a05:6000:1a85:b0:21e:88f9:848d with SMTP id\n\tf5-20020a0560001a8500b0021e88f9848dmr12734495wry.82.1659009935662; \n\tThu, 28 Jul 2022 05:05:35 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 28 Jul 2022 13:05:30 +0100","Message-Id":"<20220728120530.4381-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220728120439.4109-1-naush@raspberrypi.com>","References":"<20220728120439.4109-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused\n\tController constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Controller(char const *jsonFilename) is not valid anymore since\nController::read() can now return an error on a failure. Additionally, this\nconstructor is not actually used, so remove it.\n\nSigned-off-by: Naushir Patuck \n---\n src/ipa/raspberrypi/controller/controller.cpp | 7 -------\n src/ipa/raspberrypi/controller/controller.h | 1 -\n 2 files changed, 8 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/controller.cpp b/src/ipa/raspberrypi/controller/controller.cpp\nindex bbd382bce3ab..f489278668ef 100644\n--- a/src/ipa/raspberrypi/controller/controller.cpp\n+++ b/src/ipa/raspberrypi/controller/controller.cpp\n@@ -25,13 +25,6 @@ Controller::Controller()\n {\n }\n \n-Controller::Controller(char const *jsonFilename)\n-\t: switchModeCalled_(false)\n-{\n-\tread(jsonFilename);\n-\tinitialise();\n-}\n-\n Controller::~Controller() {}\n \n int Controller::read(char const *filename)\ndiff --git a/src/ipa/raspberrypi/controller/controller.h b/src/ipa/raspberrypi/controller/controller.h\nindex 6be1e3cfa156..3e1e051703b3 100644\n--- a/src/ipa/raspberrypi/controller/controller.h\n+++ b/src/ipa/raspberrypi/controller/controller.h\n@@ -40,7 +40,6 @@ class Controller\n {\n public:\n \tController();\n-\tController(char const *jsonFilename);\n \t~Controller();\n \tint read(char const *filename);\n \tvoid initialise();\n","prefixes":["libcamera-devel"]}