{"id":16748,"url":"https://patchwork.libcamera.org/api/1.1/patches/16748/?format=json","web_url":"https://patchwork.libcamera.org/patch/16748/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220723102426.47529-1-jacopo@jmondi.org>","date":"2022-07-23T10:24:26","name":"[libcamera-devel,fixup:,v2,4/8] fixup! libcamera: v4l2_videodevice: Reintroduce toV4L2PixelFormat()","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"b43dfcfd512369677b8a7fc534d7893b45fd7b36","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16748/mbox/","series":[{"id":3321,"url":"https://patchwork.libcamera.org/api/1.1/series/3321/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3321","date":"2022-07-23T10:24:26","name":null,"version":2,"mbox":"https://patchwork.libcamera.org/series/3321/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16748/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16748/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC961BE173\n\tfor ;\n\tSat, 23 Jul 2022 10:24:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41B7E63312;\n\tSat, 23 Jul 2022 12:24:53 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF8ED603F8\n\tfor ;\n\tSat, 23 Jul 2022 12:24:51 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 6F40960005;\n\tSat, 23 Jul 2022 10:24:47 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658571893;\n\tbh=NXI/JUt+g9rGYoGmyo3pAfd+lyDNXAuF3M144cd2eEY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vtP/2CzU1AfhY0PNZBxD0JZzOiCwplVliqaiG/AQ8WvHG0UBQbRDa9dfkx8lPvVdm\n\tk4ZUrp7dBU3HoEJ0IwnG8dn8A9830fIVHrpyh8N4VuHY1lr7bcy/5BspGlwv2doJ9o\n\tTYj12QRSeQSLp92VTT+gP3zEdOuZ0oOcb52k5xcTH8oU6M4SPrgrJDF5kzBaljrqdF\n\trjk8mbA/YOBdecvmZCrdBH/1rZG5cysU2gtr2HNECsY/8Uc9kK2sQ2lEYXUgBUXJ+a\n\tx2cbV3Azt9pahXGPh6WDDdtcJAebdMdDCWyJJvqJIm0phhU4P/9Hf3BMHqF+5aRjYn\n\tWTlsdez2E9tEw==","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 23 Jul 2022 12:24:26 +0200","Message-Id":"<20220723102426.47529-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.37.1","In-Reply-To":"<20220723095330.43542-5-jacopo@jmondi.org>","References":"<20220723095330.43542-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [fixup: v2 4/8] fixup! libcamera:\n\tv4l2_videodevice: Reintroduce toV4L2PixelFormat()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"jozef@mlich.cz, Pavel Machek ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add two missing conversions.\nTo be fixed up in the next iteration.\n\n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\n--\n2.37.1","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 65a483c14379..05ae7d392603 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1028,7 +1028,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn ret;\n\n \t/* Configure the video node. */\n-\tV4L2PixelFormat videoFormat = V4L2PixelFormat::fromPixelFormat(pipeConfig->captureFormat)[0];\n+\tV4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig->captureFormat);\n\n \tV4L2DeviceFormat captureFormat;\n \tcaptureFormat.fourcc = videoFormat;\ndiff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex cf870d26e3c3..fbe02cdcd520 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -213,7 +213,7 @@ int PipelineHandlerUVC::configure(Camera *camera, CameraConfiguration *config)\n \t\treturn ret;\n\n \tif (format.size != cfg.size ||\n-\t format.fourcc != V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat)[0])\n+\t format.fourcc != data->video_->toV4L2PixelFormat(cfg.pixelFormat))\n \t\treturn -EINVAL;\n\n \tcfg.setStream(&data->stream_);\n","prefixes":["libcamera-devel","fixup:","v2","4/8"]}