{"id":16725,"url":"https://patchwork.libcamera.org/api/1.1/patches/16725/?format=json","web_url":"https://patchwork.libcamera.org/patch/16725/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220721134531.1091104-1-umang.jain@ideasonboard.com>","date":"2022-07-21T13:45:30","name":"[libcamera-devel,1/2] test: gstreamer: Drop internal header from base class","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ae2c921bc84c893363be1ff38da04d9f164586d2","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16725/mbox/","series":[{"id":3314,"url":"https://patchwork.libcamera.org/api/1.1/series/3314/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3314","date":"2022-07-21T13:45:30","name":"[libcamera-devel,1/2] test: gstreamer: Drop internal header from base class","version":1,"mbox":"https://patchwork.libcamera.org/series/3314/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16725/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16725/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9F2FBE173\n\tfor ;\n\tThu, 21 Jul 2022 13:45:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EEB606330F;\n\tThu, 21 Jul 2022 15:45:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7EAA1601B8\n\tfor ;\n\tThu, 21 Jul 2022 15:45:39 +0200 (CEST)","from perceval.ideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:a2d:c6dd:7a7c:3d3c:dbb9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A7AA496;\n\tThu, 21 Jul 2022 15:45:38 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658411142;\n\tbh=i+L6j3AdDpIeoMdta1mI0bprcF2kgfzQXMD0Z/TH1+c=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=P4IRP+6XHZIUIF6DAOVpjPGVwo9zQKLTcLsLz6bEzvPr8AQ++voo7tq8tEeqOrTaz\n\tDYbV818U5D8+nS+/cqPmSGazqu9urJWdLkgxQPFdZ6paSqpeqfThuIOx22duGSSnqz\n\t+0sLdl5wUiD4iBLhDBZPiFVAuvfcwbD0vqVBZLdKEIJj171gp8KeZ/GkzDteKk9AKZ\n\t7rap5EOPwtnshXdBwMuE7siJb+XbCKiygTEqPV/z/SFVDCD4IvqPz6CP8SPO79iYiy\n\tEzDIMElZ0OtH4TS4me+SqcRnxNrqYialILI2qS4fBh/amEyw9rQCiMJQQaP6caupS9\n\tydq08Ab2w9rXQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658411139;\n\tbh=i+L6j3AdDpIeoMdta1mI0bprcF2kgfzQXMD0Z/TH1+c=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=i8gz+92s8QNf3IWC/rNDDM7CDtXShOELABPXErhs/5SkW+aOyR70WEEszhUJBPkLU\n\t++b9eK1OO8Zud2J7CvBVnZSCriyYJRbvoLN75bA+rhVq2eSzgt9TPXa2ZbIfDs8d+H\n\tySCDYI4XOaNr6k4smcdCXUrW15xDyYFInGYsuQOo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"i8gz+92s\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 21 Jul 2022 19:15:30 +0530","Message-Id":"<20220721134531.1091104-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] test: gstreamer: Drop internal header\n\tfrom base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The internal header isn't needed. The needed function\nlibcameraBuildPath() is exposed by libcamera/base/utils.h header.\nAt the same time, move the utils header to .cpp instead of including\nit in the base class header itself.\n\nSigned-off-by: Umang Jain \n---\n test/gstreamer/gstreamer_test.cpp | 2 ++\n test/gstreamer/gstreamer_test.h | 4 ----\n 2 files changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/test/gstreamer/gstreamer_test.cpp b/test/gstreamer/gstreamer_test.cpp\nindex 227a5c37..cfb8afc6 100644\n--- a/test/gstreamer/gstreamer_test.cpp\n+++ b/test/gstreamer/gstreamer_test.cpp\n@@ -5,6 +5,8 @@\n * libcamera Gstreamer element API tests\n */\n \n+#include \n+\n #include \"gstreamer_test.h\"\n \n #include \"test.h\"\ndiff --git a/test/gstreamer/gstreamer_test.h b/test/gstreamer/gstreamer_test.h\nindex 9869d252..35adab0e 100644\n--- a/test/gstreamer/gstreamer_test.h\n+++ b/test/gstreamer/gstreamer_test.h\n@@ -10,10 +10,6 @@\n #include \n #include \n \n-#include \n-\n-#include \"libcamera/internal/source_paths.h\"\n-\n #include \n \n class GstreamerTest\n","prefixes":["libcamera-devel","1/2"]}