{"id":16692,"url":"https://patchwork.libcamera.org/api/1.1/patches/16692/?format=json","web_url":"https://patchwork.libcamera.org/patch/16692/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220719210148.4588-1-laurent.pinchart@ideasonboard.com>","date":"2022-07-19T21:01:48","name":"[libcamera-devel] libcamera: Remove extra ':' after '\\todo'","commit_ref":"9caee4c662e9721db2a06d1a0db24f1a677d479d","pull_url":null,"state":"accepted","archived":false,"hash":"110f092c4329a823580507fe04a6232f438b7d80","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16692/mbox/","series":[{"id":3303,"url":"https://patchwork.libcamera.org/api/1.1/series/3303/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3303","date":"2022-07-19T21:01:48","name":"[libcamera-devel] libcamera: Remove extra ':' after '\\todo'","version":1,"mbox":"https://patchwork.libcamera.org/series/3303/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16692/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16692/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 629FEBD1F1\n\tfor ;\n\tTue, 19 Jul 2022 21:02:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9BA7563312;\n\tTue, 19 Jul 2022 23:02:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47688603F4\n\tfor ;\n\tTue, 19 Jul 2022 23:02:25 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C00836EE\n\tfor ;\n\tTue, 19 Jul 2022 23:02:24 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658264546;\n\tbh=GIG/53qLLQ1J+ZkYGomi9mZ9uGs3z03uwzigHj4YWU4=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=kotrAr/YiyPhj4+8Be9HD0PrBK3+u0qAlS8DUM5Rw85grQkTeZltetCa2qA+lK1q6\n\tEwZTFIZWlu6894oQ8z0BW4Vf07AhhdC/3CxKBs5V8vjsvrj5kTm0n5NuFZIJwTu6Z2\n\tvOe11MNZc+dIIPOR+8lS3rb9exwbUkYIObkDGpO6FkexaTW6Mkvrn5TrZ3aI+CTBHN\n\txLfLtn2YHoKmRRStVGOlUGhWJIyNB7Nyafti4/OtrkidK1pLsJb1vqja6iXwqEtOsQ\n\tBevMjGa6+o5APSsyrYFi9QtuvkXFnomHOgq8u4IV0/3xqMdAmC3dqUgabTdQBRMPqN\n\tXx2EjnIyQAf9A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658264544;\n\tbh=GIG/53qLLQ1J+ZkYGomi9mZ9uGs3z03uwzigHj4YWU4=;\n\th=From:To:Subject:Date:From;\n\tb=umnuLi/tj21c+1czLoyh6KVXGj+p1VT59rpwji0HqNkuK045f/q7vCGJgGBJF4MRs\n\tfigSs+AGWWmOgywSV5XIRbKYOZOotKcaGWYcj4asWzhdX7nxOwjsswXblwpxHLcmC5\n\t6SnSFDhKjtypSVm77WGaxDPZyG/Tiui6pJfGMmrM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"umnuLi/t\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 20 Jul 2022 00:01:48 +0300","Message-Id":"<20220719210148.4588-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: Remove extra ':' after '\\todo'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The doxygen '\\todo' directory doesn't need to be followed by a colon,\nyet a few strayed occurrences have made their way in. Fix them.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/delayed_controls.h | 2 +-\n src/ipa/ipu3/algorithms/agc.cpp | 2 +-\n src/libcamera/camera.cpp | 4 ++--\n src/libcamera/controls.cpp | 2 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n src/libcamera/request.cpp | 2 +-\n 6 files changed, 7 insertions(+), 7 deletions(-)\n\n\nbase-commit: 62e32042aee4042b6a931bc27a6ad11384b521f5","diff":"diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h\nindex f560c823d4e9..cd3ca8070278 100644\n--- a/include/libcamera/internal/delayed_controls.h\n+++ b/include/libcamera/internal/delayed_controls.h\n@@ -51,7 +51,7 @@ private:\n \t\tbool updated;\n \t};\n \n-\t/* \\todo: Make the listSize configurable at instance creation time. */\n+\t/* \\todo Make the listSize configurable at instance creation time. */\n \tstatic constexpr int listSize = 16;\n \tclass ControlRingBuffer : public std::array\n \t{\ndiff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex f16be534dd71..5bc64ae52214 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -229,7 +229,7 @@ void Agc::computeExposure(IPAContext &context, IPAFrameContext *frameContext,\n \n \t/*\n \t * Filter the exposure.\n-\t * \\todo: estimate if we need to desaturate\n+\t * \\todo estimate if we need to desaturate\n \t */\n \texposureValue = filterExposure(exposureValue);\n \ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex f8150dcdc788..2a8ef60e3862 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -184,12 +184,12 @@ void CameraConfiguration::addConfiguration(const StreamConfiguration &cfg)\n * This function adjusts the camera configuration to the closest valid\n * configuration and returns the validation status.\n *\n- * \\todo: Define exactly when to return each status code. Should stream\n+ * \\todo Define exactly when to return each status code. Should stream\n * parameters set to 0 by the caller be adjusted without returning Adjusted ?\n * This would potentially be useful for applications but would get in the way\n * in Camera::configure(). Do we need an extra status code to signal this ?\n *\n- * \\todo: Handle validation of buffers count when refactoring the buffers API.\n+ * \\todo Handle validation of buffers count when refactoring the buffers API.\n *\n * \\return A CameraConfiguration::Status value that describes the validation\n * status.\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 03ac6345247c..840bea4b92b8 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -908,7 +908,7 @@ ControlList::ControlList(const ControlInfoMap &infoMap,\n void ControlList::merge(const ControlList &source)\n {\n \t/**\n-\t * \\todo: ASSERT that the current and source ControlList are derived\n+\t * \\todo ASSERT that the current and source ControlList are derived\n \t * from a compatible ControlIdMap, to prevent undefined behaviour due to\n \t * id collisions.\n \t *\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex d60f20b08e27..4fe52f74a68c 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -552,7 +552,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn ret;\n \n \t/*\n-\t * \\todo: Enable links selectively based on the requested streams.\n+\t * \\todo Enable links selectively based on the requested streams.\n \t * As of now, enable all links unconditionally.\n \t * \\todo Don't configure the ImgU at all if we only have a single\n \t * stream which is for raw capture, in which case no buffers will\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 07613cb33709..d2af1d2212ad 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -349,7 +349,7 @@ Request::Request(Camera *camera, uint64_t cookie)\n \t\t\t\t camera->_d()->validator());\n \n \t/**\n-\t * \\todo: Add a validator for metadata controls.\n+\t * \\todo Add a validator for metadata controls.\n \t */\n \tmetadata_ = new ControlList(controls::controls);\n \n","prefixes":["libcamera-devel"]}