{"id":16602,"url":"https://patchwork.libcamera.org/api/1.1/patches/16602/?format=json","web_url":"https://patchwork.libcamera.org/patch/16602/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220713084317.24268-5-dse@thaumatec.com>","date":"2022-07-13T08:43:10","name":"[libcamera-devel,v2,04/11] pipeline: rkisp1: Add basic AF controls to the supported controls list","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a51a231d2a02cea54ff0932b94e9339bfd74a9df","submitter":{"id":126,"url":"https://patchwork.libcamera.org/api/1.1/people/126/?format=json","name":"Daniel Semkowicz","email":"dse@thaumatec.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16602/mbox/","series":[{"id":3276,"url":"https://patchwork.libcamera.org/api/1.1/series/3276/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3276","date":"2022-07-13T08:43:06","name":"ipa: rkisp1: Add autofocus algorithm","version":2,"mbox":"https://patchwork.libcamera.org/series/3276/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16602/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16602/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE0C2BD1F1\n\tfor ;\n\tWed, 13 Jul 2022 08:43:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE0706331E;\n\tWed, 13 Jul 2022 10:43:40 +0200 (CEST)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 238BA63317\n\tfor ;\n\tWed, 13 Jul 2022 10:43:39 +0200 (CEST)","by mail-wm1-x32b.google.com with SMTP id l68so6081686wml.3\n\tfor ;\n\tWed, 13 Jul 2022 01:43:39 -0700 (PDT)","from localhost.localdomain (ip092042140082.rev.nessus.at.\n\t[92.42.140.82]) by smtp.gmail.com with ESMTPSA id\n\tbg32-20020a05600c3ca000b003a04d19dab3sm5667468wmb.3.2022.07.13.01.43.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Jul 2022 01:43:38 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657701820;\n\tbh=a02j7m+LCJXnGBRYohDsOE13qJPexul5dyO/pjASgNs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=t94rEw0NGvvR/6ww987EXnunRV7v0jg1qUtagsuymKsF63FZr5fq4YHzWDDMPyO+S\n\tdo8h2P0urrgNJriUKIBNggt70MPOCCzBUXSUmK0XdhzD9wp02H3C/z3egZtAcFLO2v\n\tQlndYbnUUAt7kZEyyHfuQIa6D5aqhtd3Zmiz2Bqs1FvjZJpNgAxHlXNvMqK02VvXzR\n\ttj83RpN/eOvUK6KWIRvELpylYzxftscM0xx2tLNAogplE5PjIUGZcT/RAq078YVgeP\n\tdhMOMgOIiaHKKfO0m+/QTJkyLWgeZ2ODqbqjWoAnB16ZVCxFMIV6IDRDDfiHxXAd7n\n\tri7TODKXMJA7A==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=JpO4KM67IDVW3tNGmALv7h4/iatJGTjwtytTMopFnkA=;\n\tb=vvt82O+Ldbf4Rubme4VYFzEDhrwdoywIilbXCVjttqW7l3bFOG9Vm7UGfgTkaW+Imi\n\tGgUyPpe5cSyLtMQXbxUkwnm1+wNXN4x9+tEBWbMi8LMt3JP/H6QkKfe9zmTDp5VsBN6/\n\tIO3MZ0TAZNWFoYpKQyeIMRb3Ev+kz+FuqG07iLjsOv3dPgS5alViXr98LrKeD+531cbh\n\twLNsBnSUcOkJ6HkBtAGHmkiWsmCJ9rhJ2L/Pu1CiQhTUXhoJPQTtI5MI0IBNyPsnClem\n\t2ALBor2G2bPE91TkiJK9ry+7EYlJsCHJMBMnOWvBrKpXgU9Sv+vfTs+dQNKjeeGFwBgx\n\t23ug=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"vvt82O+L\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=JpO4KM67IDVW3tNGmALv7h4/iatJGTjwtytTMopFnkA=;\n\tb=Vg45KvbnmZD/vUShwA2/LsU59lv5KV1vsUPMq06jTiIno3lR5irotd0DPOebhJZugl\n\tHbqC7Z8O0+XJfH0Y4JJGRZhIQ633VaCLqYR6NkBORSHRJJkSmp0ktLWmardCkvAxkL3F\n\tILtqzkS2XTOxuCYzpLu7w/gY+iVI8ORAvRku6xBscBS0iaiqOt+SschREvnYpULEUVLt\n\tn6IcVMIDN0nZ2w8hrPZH9Q0EPPWSnerJ+TdTUTgiyziYssXIQm8c+/cBDYIGDcoYYFO1\n\t+cc1qFeMq5mGF1W6ka9a2tjfQWXvqAXcN+JaYuPgcJhOqb6QM8E6vft9MJ6+xuZkWn5R\n\tZciA==","X-Gm-Message-State":"AJIora975i6QSBrAJG7sAwHA/oj0dTC+SEVUTqVQhLgEnhip80WTJksa\n\toB7zM1a5nk9GYuUyXGkw/MUKGlv4cDYBCw==","X-Google-Smtp-Source":"AGRyM1s2kY5DTXOfYCst0RNoNZheBB6qwmiqItVrSoSYbIx+eBQmExVwfhhTEqRUhOpJ5qGuvisyYg==","X-Received":"by 2002:a05:600c:3d95:b0:3a2:e97b:f3ae with SMTP id\n\tbi21-20020a05600c3d9500b003a2e97bf3aemr8151749wmb.188.1657701818873; \n\tWed, 13 Jul 2022 01:43:38 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 13 Jul 2022 10:43:10 +0200","Message-Id":"<20220713084317.24268-5-dse@thaumatec.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220713084317.24268-1-dse@thaumatec.com>","References":"<20220713084317.24268-1-dse@thaumatec.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 04/11] pipeline: rkisp1: Add basic AF\n\tcontrols to the supported controls list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Daniel Semkowicz via libcamera-devel\n\t","Reply-To":"Daniel Semkowicz ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This will expose the AF controls and will allow controlling them using\nthe top level API.\n\nSigned-off-by: Daniel Semkowicz \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 7ee80192..99d66b1d 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -958,10 +958,12 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n \tstd::unique_ptr data =\n \t\tstd::make_unique(this, &mainPath_, &selfPath_);\n \n-\tControlInfoMap::Map ctrls;\n-\tctrls.emplace(std::piecewise_construct,\n-\t\t std::forward_as_tuple(&controls::AeEnable),\n-\t\t std::forward_as_tuple(false, true));\n+\tControlInfoMap::Map ctrls({\n+\t\t{ &controls::AeEnable, ControlInfo(false, true) },\n+\t\t{ &controls::AfMode, ControlInfo(controls::AfModeValues) },\n+\t\t{ &controls::AfTrigger, ControlInfo(controls::AfTriggerValues) },\n+\t\t{ &controls::AfPause, ControlInfo(controls::AfPauseValues) }\n+\t});\n \n \tdata->controlInfo_ = ControlInfoMap(std::move(ctrls),\n \t\t\t\t\t controls::controls);\n","prefixes":["libcamera-devel","v2","04/11"]}