{"id":16558,"url":"https://patchwork.libcamera.org/api/1.1/patches/16558/?format=json","web_url":"https://patchwork.libcamera.org/patch/16558/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220706090642.2750987-4-kieran.bingham@ideasonboard.com>","date":"2022-07-06T09:06:42","name":"[libcamera-devel,v2,3/3] qcam: viewfinder_qt: Support X RGB variants","commit_ref":"ef77e2637985b61dc99669b4396647ad13acb204","pull_url":null,"state":"accepted","archived":false,"hash":"a842b46425a63f417cd6ad4c124bbed1d03d6543","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16558/mbox/","series":[{"id":3258,"url":"https://patchwork.libcamera.org/api/1.1/series/3258/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3258","date":"2022-07-06T09:06:39","name":"qcam: Support 'X'RGB formats","version":2,"mbox":"https://patchwork.libcamera.org/series/3258/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16558/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16558/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 509BABE173\n\tfor ;\n\tWed, 6 Jul 2022 09:06:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9888063313;\n\tWed, 6 Jul 2022 11:06:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 143436330F\n\tfor ;\n\tWed, 6 Jul 2022 11:06:48 +0200 (CEST)","from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AEB7F30A;\n\tWed, 6 Jul 2022 11:06:47 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657098411;\n\tbh=4H8szj5unF3MaQfrSbvXU2ognH+Z8Cb679dH4RcLzwc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=MGR1xS4zY/WJWzkGo3LgdLnMrzJOva8WF87G4Mhm3HYpWpnIvrELE3Ej8vbCAD68N\n\tCjRDuAnUWGEZYRF0Q6zZRinBLqqZg4XJU1SbYjr+k7L7s3SUv0nnBZKh5UcS6/CCA3\n\t2sSSAL3l8HzwpLPUBq4aAIwisHLdM+JJfotWns7xjKHch91a7BOddNfh7ai794Zl/4\n\trcFM60gr6sdWhZIU4bOtDCQ9bNR6Dw5uckXS5uaHhhYwNi41jxB5bkPQ6/7ocaZVSs\n\tuCpv2b7on4e9M/6GWyhPHp+J7AieVE0D/7frM1qjxU0nqd3MVyXcOdh4HhwyYp2TMh\n\tcc2hrlo8iS+mQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657098407;\n\tbh=4H8szj5unF3MaQfrSbvXU2ognH+Z8Cb679dH4RcLzwc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aDjeajMFgX+PlK5l+1qdWBdOmkTpdBAkcdMAnrcOgzvUo9NkzZkwxtT6ve42N/DEx\n\tKAqNskO4tQvlRVyNP1EP9Uk3DAg64uUfHU6eAcpKIZWd+ynSHviyEpAL4+iam//tId\n\tsy+b80UbyNMh+E4NXY8PoNGG6lzxFaNfaLkEkW/o="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"aDjeajMF\"; dkim-atps=neutral","To":"libcamera devel ","Date":"Wed, 6 Jul 2022 10:06:42 +0100","Message-Id":"<20220706090642.2750987-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220706090642.2750987-1-kieran.bingham@ideasonboard.com>","References":"<20220706090642.2750987-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 3/3] qcam: viewfinder_qt: Support X RGB\n\tvariants","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Support the X variants of the RGB pixel formats\nalong side the equivalent Alpha component based versions.\n\nThe Alpha channel is ignored by both QImage::Format_RGB32, and\nQImage::Format_RGBX8888.\n\nThe existing use of QImage::Format_RGBA8888 is updated to use the\nQImage::Format_RGBX8888 variant to ensure that the image data is\nvisible.\n\nSigned-off-by: Kieran Bingham \n---\n\nv2:\n - Update to use QImage::Format_RGBX8888 over QImage::Format_RGBA8888\n\n src/qcam/viewfinder_qt.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/qcam/viewfinder_qt.cpp b/src/qcam/viewfinder_qt.cpp\nindex 27955e3f9593..7a6a60c96393 100644\n--- a/src/qcam/viewfinder_qt.cpp\n+++ b/src/qcam/viewfinder_qt.cpp\n@@ -27,9 +27,11 @@\n static const QMap nativeFormats\n {\n #if QT_VERSION >= QT_VERSION_CHECK(5, 2, 0)\n-\t{ libcamera::formats::ABGR8888, QImage::Format_RGBA8888 },\n+\t{ libcamera::formats::ABGR8888, QImage::Format_RGBX8888 },\n+\t{ libcamera::formats::XBGR8888, QImage::Format_RGBX8888 },\n #endif\n \t{ libcamera::formats::ARGB8888, QImage::Format_RGB32 },\n+\t{ libcamera::formats::XRGB8888, QImage::Format_RGB32 },\n #if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)\n \t{ libcamera::formats::RGB888, QImage::Format_BGR888 },\n #endif\n","prefixes":["libcamera-devel","v2","3/3"]}