{"id":16516,"url":"https://patchwork.libcamera.org/api/1.1/patches/16516/?format=json","web_url":"https://patchwork.libcamera.org/patch/16516/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220701154701.354052-6-jacopo@jmondi.org>","date":"2022-07-01T15:46:58","name":"[libcamera-devel,6/9] fixup: Reword ExposureTimeMode","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"4d484883d7a47bd3fffbd1bbdeef8eb9accd57eb","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16516/mbox/","series":[{"id":3243,"url":"https://patchwork.libcamera.org/api/1.1/series/3243/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3243","date":"2022-07-01T15:46:53","name":"[libcamera-devel,1/9] controls: Reorganize the AE-related controls","version":1,"mbox":"https://patchwork.libcamera.org/series/3243/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16516/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16516/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00141BD808\n\tfor ;\n\tFri, 1 Jul 2022 15:47:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB8DE6565C;\n\tFri, 1 Jul 2022 17:47:15 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85F0065655\n\tfor ;\n\tFri, 1 Jul 2022 17:47:11 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id E59C0E0006;\n\tFri, 1 Jul 2022 15:47:10 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656690435;\n\tbh=cOryWfdVASI7VdmRVSGK8PW3OalV4m+56k8h8v5fo2g=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=TyVlD3c4JAWLO56DH+PGYd6AQIfGMv3GezZnabemys9kcgI7s9akTp9HxijOqRSAG\n\tV06bPoKV83fPT5qtvJ4N8Enmeg7w5U6EAkd12m8UeHdElBCW7LOpEbvSRL8HYYaksg\n\tIXFlvImBjJ264PfSgHExh4XX3W7+OoUHgoEqGaykHn9Ju2YT29Fwbe5qzSDbYJxj6w\n\tcT5UG7IrYQVi5b61BQOd1KUq6qFQIn1sjjy9Hce2hCx0LaQzk/Vl74FqDPLmmwh4kB\n\tdEeAfkrdJFsjHVyTUyXK/M8DLfFH1fu2l3ZJHHtyTwiu9JbkeK0RoU3JhBfl+bN//h\n\t7lOFFbKZQdsyw==","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 1 Jul 2022 17:46:58 +0200","Message-Id":"<20220701154701.354052-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.36.1","In-Reply-To":"<20220701154701.354052-1-jacopo@jmondi.org>","References":"<20220518134728.777709-2-paul.elder@ideasonboard.com>\n\t<20220701154701.354052-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 6/9] fixup: Reword ExposureTimeMode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Slightly reword the first part of the control definition.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/control_ids.yaml | 16 +++++-----------\n 1 file changed, 5 insertions(+), 11 deletions(-)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex b062b7e234a6..e6676a149795 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -203,21 +203,15 @@ controls:\n Controls the source of the exposure time that is applied to the image\n sensor. When set to Auto, the AE algorithm computes the exposure time\n and configures the image sensor accordingly. When set to Manual,\n- exposure time specified in ExposureTime is applied to the image sensor.\n- If ExposureTime is not set, then the value last computed by the AE\n- algorithm when the mode was Auto will be used.\n+ the value of the ExposureTime control is used.\n \n- If ExposureTime is not set and the mode is ExposureTimeModeManual and\n- AE was never Auto (either because the camera started in Manual mode,\n+ When transitioning from Auto to Manual mode and no ExposureTime control\n+ is provided by the application, the last value computed by the AE\n+ algorithm when the mode was Auto will be used. If the ExposureTimeMode\n+ was never set to Auto (either because the camera started in Manual mode,\n or Auto is not supported by the camera), the camera should use a\n best-effort default value.\n \n- When ExposureTimeMode is set Auto, the value set in ExposureTime is\n- ignored and is not retained. This means that if ExposureTimeMode is set\n- to Manual and ExposureTime is not also set, the exposure time that\n- was last computed by the AE algorithm while the mode was Auto will be\n- applied to the sensor.\n-\n If ExposureTimeModeManual is supported, the ExposureTime control must\n also be supported.\n \n","prefixes":["libcamera-devel","6/9"]}