{"id":16428,"url":"https://patchwork.libcamera.org/api/1.1/patches/16428/?format=json","web_url":"https://patchwork.libcamera.org/patch/16428/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220629103018.4025635-3-chenghaoyang@google.com>","date":"2022-06-29T10:30:11","name":"[libcamera-devel,v3,2/9] ipu3: Allow only one camera being started","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e1463f6c510223438abaf29af07d433c49b1a626","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/16428/mbox/","series":[{"id":3232,"url":"https://patchwork.libcamera.org/api/1.1/series/3232/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3232","date":"2022-06-29T10:30:09","name":"Use two imgus in ipu3 pipeline handler","version":3,"mbox":"https://patchwork.libcamera.org/series/3232/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16428/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16428/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BFDFBE173\n\tfor ;\n\tWed, 29 Jun 2022 10:30:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2972B6563F;\n\tWed, 29 Jun 2022 12:30:29 +0200 (CEST)","from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com\n\t[IPv6:2607:f8b0:4864:20::62b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A46DC60412\n\tfor ;\n\tWed, 29 Jun 2022 12:30:26 +0200 (CEST)","by mail-pl1-x62b.google.com with SMTP id k14so13707881plh.4\n\tfor ;\n\tWed, 29 Jun 2022 03:30:26 -0700 (PDT)","from chenghaoyang-low.c.googlers.com.com\n\t(208.158.221.35.bc.googleusercontent.com. [35.221.158.208])\n\tby smtp.gmail.com with ESMTPSA id\n\tjb4-20020a170903258400b00169071538a0sm10946059plb.267.2022.06.29.03.30.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 29 Jun 2022 03:30:24 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656498629;\n\tbh=cnT2I2kXHoViJJi+mchR8wLp6h1hHGjuDpJyjvEiPGw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wtWRWRcfSR16jTrXnfutsmtgeUDle4UDxmlcF4QI1Hyg3NuERPqRlLmzFmBgPNDYT\n\tcJKbnFCxWy3KOnrJ6Ylm0zgokA3qb+8IjYj4o9cpDSgWThyKEgsRIze4gFJD5oCH8k\n\tH9HkNYk8RreRrfQXcSl2BLx9DDrKD5vHneE477PMDHmJIYFkMr8I7ktimVOmnz7wmY\n\tEPOvlSqz0NX/wi4gdORfgmVD/TqGOOkm2f5+ucTFLdxiF4GW3e7fWm/tWrGsrQlaM0\n\tRCXALvjZ4ObXxRiU3iC8ffdZqdE/nhOPpNf280mr620OafoCPlFtzb6nPYKi0WL7GJ\n\tdmz+wuCjLTqpg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=SIwkgrFVZoMpv3fQMHYD/oCCOcCeDkunHhcLDNTInRI=;\n\tb=gdxmm1yZd8xdinJxTIzL6gpVEwejYIkBJE3TxScuriWB6H3MQtmtwy5vzfgmZW8UJo\n\tU7hGFoh72hk6jfIVE14FEtGGHqtk5e0uNir46nYZ/tLcF5FIzYkdmmj46gt4wJoo/Bd1\n\tHptice/40ig9C14a/LoG8FN0VADhAGpVNm5cw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"gdxmm1yZ\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=SIwkgrFVZoMpv3fQMHYD/oCCOcCeDkunHhcLDNTInRI=;\n\tb=qY6iodzFdNwFH/rEu5F6ueePr2Wu2eKh8hirkr1aLf0PIBRtHoeTbAYz+dhO8LNgzG\n\tZFV8/0DSS/SSe9ngO+x7xNu1B2RxsdIMfKeFI7ketgh/Mz9pB371vne8AthA7nxVrPgR\n\tEQjX0tw+f3dVZVIyWUR9VY9GOzJjfYodX6pDJtzsxXZYtyqQ5RjXYSuksWOglYRg8TVk\n\t19JhP3KPWn2xgT6SbhfPk+PTi2p7cylCAcd2dSMw0+bDO1kSG/bhnJNdn7S9f4XcvJzy\n\tUSLyUlClBdUDGP1SdZ2eyzIx9wU7IXSF0+1Z25Rn86O7hW0yQ0etlbt3ek1AvemyGtN7\n\to3lA==","X-Gm-Message-State":"AJIora+8aJiBtCo/cON24qB7sjC1VGZRfVhIICGarpFKeonmGl1deEtl\n\tFOwx+10kEOWT1GQw1ooczKwQfZgjVJ9UCJSX","X-Google-Smtp-Source":"AGRyM1u7uyuYXadKQiykiZbedaA4/5Q8iLXlgcdAJ0o22OfSPY3yXtSYQCScJV4tp6ZXOum1Tqt0nQ==","X-Received":"by 2002:a17:902:bb8d:b0:168:e48d:86bc with SMTP id\n\tm13-20020a170902bb8d00b00168e48d86bcmr9881545pls.93.1656498624645; \n\tWed, 29 Jun 2022 03:30:24 -0700 (PDT)","X-Google-Original-From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 29 Jun 2022 10:30:11 +0000","Message-Id":"<20220629103018.4025635-3-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.37.0.rc0.161.g10f37bed90-goog","In-Reply-To":"<20220629103018.4025635-1-chenghaoyang@google.com>","References":"<20220629103018.4025635-1-chenghaoyang@google.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 2/9] ipu3: Allow only one camera being\n\tstarted","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Harvey Yang via libcamera-devel ","Reply-To":"Harvey Yang ","Cc":"Harvey Yang ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Harvey Yang \n\nAs we hardly have use cases/applications that need both cameras at the\nsame time, this patch adds a rule that only one camera can be started\none time. This also allows the following patches that use both imgus to\nprocess frames from one single camera.\n\nSigned-off-by: Harvey Yang \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex fd989e61..c943ee6a 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -166,6 +166,8 @@ private:\n \tMediaDevice *cio2MediaDev_;\n \tMediaDevice *imguMediaDev_;\n \n+\tCamera *inUseCamera_ = nullptr;\n+\n \tstd::vector ipaBuffers_;\n };\n \n@@ -765,6 +767,14 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera)\n \n int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlList *controls)\n {\n+\t/*\n+\t * Enforce that only a single camera can be used at a time to use both\n+\t * ImgUs on the camera, so that StillCapture stream can adopt another\n+\t * set of configuration.\n+\t */\n+\tif (inUseCamera_ && inUseCamera_ != camera)\n+\t\treturn -EBUSY;\n+\n \tIPU3CameraData *data = cameraData(camera);\n \tCIO2Device *cio2 = &data->cio2_;\n \tImgUDevice *imgu = data->imgu_;\n@@ -781,6 +791,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n \tif (ret)\n \t\treturn ret;\n \n+\tinUseCamera_ = camera;\n+\n \tret = data->ipa_->start();\n \tif (ret)\n \t\tgoto error;\n@@ -808,6 +820,8 @@ error:\n \tfreeBuffers(camera);\n \tLOG(IPU3, Error) << \"Failed to start camera \" << camera->id();\n \n+\tinUseCamera_ = nullptr;\n+\n \treturn ret;\n }\n \n@@ -826,6 +840,8 @@ void PipelineHandlerIPU3::stopDevice(Camera *camera)\n \t\tLOG(IPU3, Warning) << \"Failed to stop camera \" << camera->id();\n \n \tfreeBuffers(camera);\n+\n+\tinUseCamera_ = nullptr;\n }\n \n void IPU3CameraData::cancelPendingRequests()\n","prefixes":["libcamera-devel","v3","2/9"]}