{"id":16345,"url":"https://patchwork.libcamera.org/api/1.1/patches/16345/?format=json","web_url":"https://patchwork.libcamera.org/patch/16345/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220623144736.78537-8-tomi.valkeinen@ideasonboard.com>","date":"2022-06-23T14:47:36","name":"[libcamera-devel,RFC,v1,7/7] py: cam.py: Use new events support","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f7b89e33c3133facb896b0f703574bfa7d916bc0","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/1.1/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16345/mbox/","series":[{"id":3213,"url":"https://patchwork.libcamera.org/api/1.1/series/3213/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3213","date":"2022-06-23T14:47:29","name":"Python bindings event handling","version":1,"mbox":"https://patchwork.libcamera.org/series/3213/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16345/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16345/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8126BD808\n\tfor ;\n\tThu, 23 Jun 2022 14:48:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71F3665637;\n\tThu, 23 Jun 2022 16:48:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21E886563D\n\tfor ;\n\tThu, 23 Jun 2022 16:48:01 +0200 (CEST)","from deskari.lan (91-158-154-79.elisa-laajakaista.fi\n\t[91.158.154.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AC2DDD;\n\tThu, 23 Jun 2022 16:48:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655995688;\n\tbh=kIO3WgRrLWjCEOq4w3LCDR5Kbdy/9I5vKkQ+ah1/vwA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=iikUDItzd5xTmucTFvJYdpqnppmBvwFEUReHMReEB/msjS8n0qWpMuM1MAf4d99Bb\n\tcqYeSMEnBASQ0jU3J/lxfsqG9LtIVbnbOwJc0zvhPNPEJNlyuRxsj2xvrvnFq+C0r+\n\tEpCRU6T7ubRPjT+q+WMuLbSDslnt3UQoaD+wLvmKrfYb95wvaytKwKgxJ09B97dWTi\n\tc3+ry6BSRmgJGdM6Bpl3T+HfAqNNRgdwd5mUx5eDwtMFJczsr6NmG2b0eHf4unbTmG\n\tGLQeVPm9O0SoRgNhQoGLNq+yuC4hXVgZKbwqHsCamerc5V5QDgh+qnIu39tjYL4JlY\n\tuw23j2swCYnFA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655995680;\n\tbh=kIO3WgRrLWjCEOq4w3LCDR5Kbdy/9I5vKkQ+ah1/vwA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=h9Ms2c4+E88kZ+1Dy1VIsq14Q+GUhfhg5+959GFcWxa3Wtu49nDlMDB8lgne0utUY\n\tEGfDqysGq2tAWleR5U2qNxOq78uSFdZ8nFtiAGbDrnusKH5W58ru8xGFwva28ris1d\n\tcm4qhWXw3nAaAg7xyrCk5MI0ynwU/UaeseL/siRU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"h9Ms2c4+\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Thu, 23 Jun 2022 17:47:36 +0300","Message-Id":"<20220623144736.78537-8-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220623144736.78537-1-tomi.valkeinen@ideasonboard.com>","References":"<20220623144736.78537-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC v1 7/7] py: cam.py: Use new events support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Signed-off-by: Tomi Valkeinen \n---\n src/py/cam/cam.py | 31 +++++++++++++++++++++++++------\n 1 file changed, 25 insertions(+), 6 deletions(-)","diff":"diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\nindex 733e9ae5..538f0c1d 100755\n--- a/src/py/cam/cam.py\n+++ b/src/py/cam/cam.py\n@@ -243,11 +243,7 @@ class CaptureState:\n # Called from renderer when there is a libcamera event\n def event_handler(self):\n try:\n- reqs = self.cm.get_ready_requests()\n-\n- for req in reqs:\n- ctx = next(ctx for ctx in self.contexts if ctx.idx == req.cookie)\n- self.__request_handler(ctx, req)\n+ self.cm.dispatch_events()\n \n running = any(ctx.reqs_completed < ctx.opt_capture for ctx in self.contexts)\n return running\n@@ -255,7 +251,9 @@ class CaptureState:\n traceback.print_exc()\n return False\n \n- def __request_handler(self, ctx, req):\n+ def __request_handler(self, cam, req):\n+ ctx = next(ctx for ctx in self.contexts if ctx.camera == cam)\n+\n if req.status != libcam.Request.Status.Complete:\n raise Exception('{}: Request failed: {}'.format(ctx.id, req.status))\n \n@@ -310,6 +308,9 @@ class CaptureState:\n ctx.camera.queue_request(req)\n ctx.reqs_queued += 1\n \n+ def __disconnect_handler(self, cam):\n+ print('Camera', cam, 'disconnected')\n+\n def __capture_init(self):\n for ctx in self.contexts:\n ctx.acquire()\n@@ -323,6 +324,15 @@ class CaptureState:\n for ctx in self.contexts:\n ctx.create_requests()\n \n+ for ctx in self.contexts:\n+ # These cause circular dependencies:\n+ # The callback in the camera points to CaptureState.\n+ # The CaptureState points to the camera.\n+ # This can be solved by setting the callbacks to None after stopping\n+ # or using lambdas here and weakref.WeakMethod.\n+ ctx.camera.request_completed = self.__request_handler\n+ ctx.camera.disconnected = self.__disconnect_handler\n+\n def __capture_start(self):\n for ctx in self.contexts:\n ctx.start()\n@@ -334,6 +344,10 @@ class CaptureState:\n for ctx in self.contexts:\n ctx.stop()\n \n+ for ctx in self.contexts:\n+ ctx.camera.request_completed = None\n+ ctx.camera.disconnected = None\n+\n for ctx in self.contexts:\n ctx.release()\n \n@@ -402,6 +416,9 @@ def main():\n \n cm = libcam.CameraManager.singleton()\n \n+ cm.camera_added = lambda c: print(\"Camera added:\", c)\n+ cm.camera_removed = lambda c: print(\"Camera removed:\", c)\n+\n if args.list:\n do_cmd_list(cm)\n \n@@ -459,6 +476,8 @@ def main():\n \n state.do_cmd_capture()\n \n+ cm.discard_events()\n+\n return 0\n \n \n","prefixes":["libcamera-devel","RFC","v1","7/7"]}