{"id":16283,"url":"https://patchwork.libcamera.org/api/1.1/patches/16283/?format=json","web_url":"https://patchwork.libcamera.org/patch/16283/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220620051150.361575-1-umang.jain@ideasonboard.com>","date":"2022-06-20T05:11:50","name":"[libcamera-devel] libcamera: base: thread: Protect exitCode by mutex in exit()","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"fda30d85419fd2e96daf5ff08eeeeb206d44818a","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/16283/mbox/","series":[{"id":3192,"url":"https://patchwork.libcamera.org/api/1.1/series/3192/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3192","date":"2022-06-20T05:11:50","name":"[libcamera-devel] libcamera: base: thread: Protect exitCode by mutex in exit()","version":1,"mbox":"https://patchwork.libcamera.org/series/3192/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16283/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16283/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAB6CBD808\n\tfor ;\n\tMon, 20 Jun 2022 05:12:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D290665633;\n\tMon, 20 Jun 2022 07:12:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3FDC6048F\n\tfor ;\n\tMon, 20 Jun 2022 07:11:59 +0200 (CEST)","from perceval.ideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:e389:cb58:4104:f66:a571])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 04CDD892;\n\tMon, 20 Jun 2022 07:11:57 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655701921;\n\tbh=9/hFVqkt/YUAhJphnv1ZcydS9lVQQoFh/Sbp5l0JE08=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=ZPKIx+3dIb20JAUV0jxaJXz2F8ICRriFy0TtKsQ/9x+7FIsOBp1rG/kVlj6m+NrAl\n\tHvfrrgtmrC974GXGgqB7yAsPqbPzc6WCMNQO3fym4R5FeC554hkVbphB5C0cr1aPZX\n\tO/Ttq1hq5HUyj0obQbo1m4kkroFCYoEGAhUkJohxmcFi30NueXlCTMUcLmx57HUsS5\n\tT12O1xBFJAvjMyZeq16l/+0arq+7rov08BJUQScn8kO3eyYjjGQY4FdDFozjluVtMD\n\tZ5+YRLwUJHfM41wsd/lo2f1IdONFinqW7NzQTzTtQjYFKL1btfU2QafHuN+IEEub/X\n\tj/xy8lOmdYmwA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655701919;\n\tbh=9/hFVqkt/YUAhJphnv1ZcydS9lVQQoFh/Sbp5l0JE08=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=r58JbEd7XZTTE+u7svfdDV3lXLLHui+CryzeyUi28Eioo3pcVGWURirnWkvkRFYXg\n\tioF+COhSjW4XfwgFG17VY4JsHK9bRC7LG9q9H09M/tw0JLIDntBZqRKtbLf4bDwzFc\n\tGj158CQUukhIQ5MOUl0XA3EogvqGUsKbZIKyQ3Pk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"r58JbEd7\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 20 Jun 2022 10:41:50 +0530","Message-Id":"<20220620051150.361575-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: base: thread: Protect exitCode\n\tby mutex in exit()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Hirokazu Honda \n\nThread::exit() accesses data_->exitCode without acquiring a lock.\nFix it.\n\nSigned-off-by: Hirokazu Honda \nSigned-off-by: Umang Jain \n---\n src/libcamera/base/thread.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\nindex 6bda9d14..ff65641e 100644\n--- a/src/libcamera/base/thread.cpp\n+++ b/src/libcamera/base/thread.cpp\n@@ -392,7 +392,10 @@ void Thread::finishThread()\n */\n void Thread::exit(int code)\n {\n+\tdata_->mutex_.lock();\n \tdata_->exitCode_ = code;\n+\tdata_->mutex_.unlock();\n+\n \tdata_->exit_.store(true, std::memory_order_release);\n \n \tEventDispatcher *dispatcher = data_->dispatcher_.load(std::memory_order_relaxed);\n","prefixes":["libcamera-devel"]}