{"id":16256,"url":"https://patchwork.libcamera.org/api/1.1/patches/16256/?format=json","web_url":"https://patchwork.libcamera.org/patch/16256/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220617083211.28407-1-jeanmichel.hautbois@ideasonboard.com>","date":"2022-06-17T08:32:11","name":"[libcamera-devel] ipa: ipu3: awb: Correct the coefficient factor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8325a363444b40f49dc5c506f667014dc159c957","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16256/mbox/","series":[{"id":3185,"url":"https://patchwork.libcamera.org/api/1.1/series/3185/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3185","date":"2022-06-17T08:32:11","name":"[libcamera-devel] ipa: ipu3: awb: Correct the coefficient factor","version":1,"mbox":"https://patchwork.libcamera.org/series/3185/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16256/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16256/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7EA9BD161\n\tfor ;\n\tFri, 17 Jun 2022 08:32:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1637765635;\n\tFri, 17 Jun 2022 10:32:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAE2460471\n\tfor ;\n\tFri, 17 Jun 2022 10:32:15 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:28e5:dce:57ec:634e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62EF22A5;\n\tFri, 17 Jun 2022 10:32:15 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655454737;\n\tbh=u2KZRO1PCj4w/rZ+feY0qJJxmZl8esw7GAavvN9Q4Yw=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=tXUHW+ToGn0dPj3hcUkQI+D4wIYtmAODAFGODcPRzrWecwwdJIaJK9py0xGs3DA/l\n\tFSiuaTSYx9I0lrZSxujq4DCnUvovqQ7/hNrOptLL7K/sh66KozMQYV++vGDfGVuQse\n\tha+1lhKKJ3VySWm0pJaCFPU+GQ1hTfinD+J2/E6okNOE0b91ECD6tb/ciCSf6wn/3y\n\t/Wv282qN7ZuYo3pp5NyeoSF58QsAgEau2b32RTja3a4T60/t6m34N9+uUGJFpBPg0x\n\tyMlAhtGUlPqydI4MhaKqWntbFCDgRaADyvHTcY3dO8sR8hv32TuffKp8g2xgDN7TiS\n\tfZ/tD2EQxFpSA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655454735;\n\tbh=u2KZRO1PCj4w/rZ+feY0qJJxmZl8esw7GAavvN9Q4Yw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=PJeRUYxbhg4p+r8eZDS1WxXnlYiKaWubuLMIfmAbmplzMgq5YLarU7a6NGVNSHjG2\n\tJRTh6ZVKA5Z9mlDUQeQb1KV7clJDt6vcmE4vzCraMv57FDghc4qy8DAaSlyZ4e5R1b\n\toHQq705IknKsF2V20lBf5WN06tY2ZVjKHgSu/Ki4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PJeRUYxb\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 17 Jun 2022 10:32:11 +0200","Message-Id":"<20220617083211.28407-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: ipu3: awb: Correct the coefficient\n\tfactor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The factor used right now in the IPU3 is 8192, as a multiplier of the\nestimated gain. This is wrong, as the isp is adding 1.0 to the gain\napplied, ie Pout = { Pin * (1 + Gx) }.\n\nFix it, and to ease the reading, introduce a small helper function.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/algorithms/awb.cpp | 21 +++++++++++++++++----\n src/ipa/ipu3/algorithms/awb.h | 1 +\n 2 files changed, 18 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 5c232d92..6abaf75f 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -409,6 +409,19 @@ constexpr uint16_t Awb::threshold(float value)\n \treturn value * 8191;\n }\n \n+constexpr uint16_t Awb::fixedGain(double gain)\n+{\n+\t/*\n+\t * For BNR parameters WB gain factor for the three channels\n+\t * [Ggr, Ggb, Gb, Gr]. Their precision is U3.13 and the range is (0, 8)\n+\t * and the actual gain is Gx + 1, it is typically Gx = 1.\n+\t *\n+\t * Pout = {Pin * (1 + Gx)}.\n+\t */\n+\tgain = std::clamp((gain - 1.0), 0.0, 8.0);\n+\treturn gain * 8192;\n+}\n+\n /**\n * \\copydoc libcamera::ipa::Algorithm::prepare\n */\n@@ -451,10 +464,10 @@ void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n \tparams->acc_param.bnr.opt_center_sqr.y_sqr_reset = params->acc_param.bnr.opt_center.y_reset\n \t\t\t\t\t\t\t* params->acc_param.bnr.opt_center.y_reset;\n \t/* Convert to u3.13 fixed point values */\n-\tparams->acc_param.bnr.wb_gains.gr = 8192 * context.activeState.awb.gains.green;\n-\tparams->acc_param.bnr.wb_gains.r = 8192 * context.activeState.awb.gains.red;\n-\tparams->acc_param.bnr.wb_gains.b = 8192 * context.activeState.awb.gains.blue;\n-\tparams->acc_param.bnr.wb_gains.gb = 8192 * context.activeState.awb.gains.green;\n+\tparams->acc_param.bnr.wb_gains.gr = fixedGain(context.activeState.awb.gains.green);\n+\tparams->acc_param.bnr.wb_gains.r = fixedGain(context.activeState.awb.gains.red);\n+\tparams->acc_param.bnr.wb_gains.b = fixedGain(context.activeState.awb.gains.blue);\n+\tparams->acc_param.bnr.wb_gains.gb = fixedGain(context.activeState.awb.gains.green);\n \n \tLOG(IPU3Awb, Debug) << \"Color temperature estimated: \" << asyncResults_.temperatureK;\n \ndiff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex 9a50a985..3154541d 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -73,6 +73,7 @@ private:\n \tvoid awbGreyWorld();\n \tuint32_t estimateCCT(double red, double green, double blue);\n \tstatic constexpr uint16_t threshold(float value);\n+\tstatic constexpr uint16_t fixedGain(double gain);\n \n \tstd::vector zones_;\n \tAccumulator awbStats_[kAwbStatsSizeX * kAwbStatsSizeY];\n","prefixes":["libcamera-devel"]}