{"id":16235,"url":"https://patchwork.libcamera.org/api/1.1/patches/16235/?format=json","web_url":"https://patchwork.libcamera.org/patch/16235/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220616091148.67870-2-jeanmichel.hautbois@ideasonboard.com>","date":"2022-06-16T09:11:49","name":"[libcamera-devel,RFC,1/1] ipa: ipu3: awb: Correct the coefficient factor","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"141acc21d9358bf01bdf5cdb34a7cd3d5dd10d53","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16235/mbox/","series":[{"id":3180,"url":"https://patchwork.libcamera.org/api/1.1/series/3180/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3180","date":"2022-06-16T09:11:48","name":"IPU3 AWB gains correction","version":1,"mbox":"https://patchwork.libcamera.org/series/3180/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16235/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16235/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3ABE8C3273\n\tfor ;\n\tThu, 16 Jun 2022 09:12:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 105B165635;\n\tThu, 16 Jun 2022 11:12:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AB30601F1\n\tfor ;\n\tThu, 16 Jun 2022 11:12:27 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:64d1:a349:8ac7:1dd0])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 95F97415;\n\tThu, 16 Jun 2022 11:12:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655370749;\n\tbh=MZTMnj9SaFWfbmCn2c4lmh2X8QpSS7ZsBTcLHr1FAa4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=U9oRFdm0T3iWlWv+khTV56t2yZHGM9k8YffxjVRiL5cdq4KgC8FcyxaDcII0X7AK5\n\tWf6NnxuDzVFq+xoMXNfJY5Fn0MLtz3zHfm6gjLNspOmc8E8NO/TrOUscnElIIk8Wds\n\tTWqi1mzLI0ozSAzB14Z17giFpOsTDz1nHyEEpvgRT0a/mwXMtuB2nZPgXkBdR2jKS4\n\tDFLQ2OCsO0BHqGMAhSedoY6h2osZYSygv/gLzNlJ7LWAc9XwGqb0Vg56lt2n8fM9QO\n\tbC5PyE3TItwYw4SJ10aJL+ADdp+v7t0LiS7ulf3UmhP1f1p8Rd8Ss9zPyKsVV6xqGN\n\tW2cMaWC6wypAA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655370746;\n\tbh=MZTMnj9SaFWfbmCn2c4lmh2X8QpSS7ZsBTcLHr1FAa4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rcGsGWi+bSQJJVTSzHhTmMHAD+HPPpzrmnJLsUNK7akjcz4IhHUTKp1AqpYv+uSNh\n\tKF6hZyAJT3D5gSAv9xla5tUtLUbK2qT3qBQpFaeoETf6QEMQpcNReHzSXPi77VjkcO\n\tM2FYzxD9vwS0IsNqCR6qWiWrHRXpj3FHLlzdcMqI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rcGsGWi+\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 16 Jun 2022 11:11:49 +0200","Message-Id":"<20220616091148.67870-2-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 1/1] ipa: ipu3: awb: Correct the\n\tcoefficient factor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Cc":"bingbu.cao@intel.com, sakari.ailus@linux.intel.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The factor used right now in the IPU3 is 8192, as stated in the\ndocumentation : \"Precision u3.13, range [0, 8)\".\n\nTesting it in more depth made this assumption debatable, as it seems\nthat the gain is 1.0 when the value is 4096.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/algorithms/awb.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 5c232d92..2a7d30ab 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -451,10 +451,10 @@ void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n \tparams->acc_param.bnr.opt_center_sqr.y_sqr_reset = params->acc_param.bnr.opt_center.y_reset\n \t\t\t\t\t\t\t* params->acc_param.bnr.opt_center.y_reset;\n \t/* Convert to u3.13 fixed point values */\n-\tparams->acc_param.bnr.wb_gains.gr = 8192 * context.activeState.awb.gains.green;\n-\tparams->acc_param.bnr.wb_gains.r = 8192 * context.activeState.awb.gains.red;\n-\tparams->acc_param.bnr.wb_gains.b = 8192 * context.activeState.awb.gains.blue;\n-\tparams->acc_param.bnr.wb_gains.gb = 8192 * context.activeState.awb.gains.green;\n+\tparams->acc_param.bnr.wb_gains.gr = 0 * context.activeState.awb.gains.green;\n+\tparams->acc_param.bnr.wb_gains.r = 4096 * context.activeState.awb.gains.red;\n+\tparams->acc_param.bnr.wb_gains.b = 4096 * context.activeState.awb.gains.blue;\n+\tparams->acc_param.bnr.wb_gains.gb = 0 * context.activeState.awb.gains.green;\n \n \tLOG(IPU3Awb, Debug) << \"Color temperature estimated: \" << asyncResults_.temperatureK;\n \n","prefixes":["libcamera-devel","RFC","1/1"]}