{"id":16233,"url":"https://patchwork.libcamera.org/api/1.1/patches/16233/?format=json","web_url":"https://patchwork.libcamera.org/patch/16233/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220616084940.63177-1-jeanmichel.hautbois@ideasonboard.com>","date":"2022-06-16T08:49:41","name":"[libcamera-devel,v1.1] qcam: dng: Make TIFFTAG_CFAPATTERN variable count","commit_ref":"ae7809307e798ae32f4c978882aca94249ce7fd7","pull_url":null,"state":"accepted","archived":false,"hash":"93a05321afdcc177f9b93a098a9a91395c1e8491","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16233/mbox/","series":[{"id":3179,"url":"https://patchwork.libcamera.org/api/1.1/series/3179/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3179","date":"2022-06-16T08:49:41","name":"[libcamera-devel,v1.1] qcam: dng: Make TIFFTAG_CFAPATTERN variable count","version":1,"mbox":"https://patchwork.libcamera.org/series/3179/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16233/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16233/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79557BD161\n\tfor ;\n\tThu, 16 Jun 2022 08:51:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C38E465631;\n\tThu, 16 Jun 2022 10:51:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78A92601F1\n\tfor ;\n\tThu, 16 Jun 2022 10:51:18 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:64d1:a349:8ac7:1dd0])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 25D8E415;\n\tThu, 16 Jun 2022 10:51:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655369480;\n\tbh=cpEFNr1BTzt0R+ZrRsQfMIYz/nJtXxZJYfR/uEiG9rI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=IoKaAPDziU0wdynsr/MYZTRfv8BuooWTJLY5s0WMDDf6ahL8XhirMBs6pypmL4cXY\n\tffpEsY9yLhyBiMwYtWAprFxs5NyZXmivI2HTMP8+0F/0ufLRvUN183gqOg1NF3Ig+Z\n\txn3mejdQ/+jBoYPrpee9jmkfK/IfacUwAL/8frb23ebgUsdB7qII38/MQOYV3ciV02\n\tncdcl7NB6B2sQbSJCkG/mB3WD61naMT7ATfSZWoeUzbmsTcQ/w+N5Yzd6+hZwrR7s5\n\t97Ci5pTTzruU2dt/uzQ9Oj4u421Dpsr3xgTyG6X19X+cNUZIBCOGcIKbkTWZgH0i8I\n\tM/OI0FxYg+v5g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655369478;\n\tbh=cpEFNr1BTzt0R+ZrRsQfMIYz/nJtXxZJYfR/uEiG9rI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=X1xXK7+baB0usCXf893P6vybLztIDBdj+7nRBIniBDyaKg1cS6rXi/QILaED16XkO\n\tsytfZDiq+jPRRcE2J76lFLv++0JwRi3KveUTcrhX8zi1YYPyil7tgih0PaqWT7/5W1\n\trmEEEXbfcxYMmk+Q4LV5ipqXKopwVsMTm2JLi1CY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"X1xXK7+b\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 16 Jun 2022 10:49:41 +0200","Message-Id":"<20220616084940.63177-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220616084642.59823-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20220616084642.59823-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1.1] qcam: dng: Make TIFFTAG_CFAPATTERN\n\tvariable count","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since libtiff version 20201219, the CFAPATTERN tag is using a variable\ncount and not the fixed 4 values size.\nFor reference, the commit introducing this is:\n\n\tcommit 2eb5a954cb7b7ad61559da00743c4b0e2fce34d0\n\tAuthor: Sam Hasinoff \n\tDate: Sun Mar 8 21:23:16 2020 +0100\n\tMake TIFFTAG_CFAPATTERN variable count\n\nAdd a version check in the DNGWriter::write function when this tag is\nwritten as this breaks the raw capture in qcam.\n\nSigned-off-by: Jean-Michel Hautbois \n---\nv1.1: Corrects a typo in the if\n -> /me should really always compile before sending -_-\n---\n src/qcam/dng_writer.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\nindex 34c8df5a..06491b92 100644\n--- a/src/qcam/dng_writer.cpp\n+++ b/src/qcam/dng_writer.cpp\n@@ -506,7 +506,10 @@ int DNGWriter::write(const char *filename, const Camera *camera,\n \tTIFFSetField(tif, TIFFTAG_PLANARCONFIG, PLANARCONFIG_CONTIG);\n \tTIFFSetField(tif, TIFFTAG_SAMPLEFORMAT, SAMPLEFORMAT_UINT);\n \tTIFFSetField(tif, TIFFTAG_CFAREPEATPATTERNDIM, cfaRepeatPatternDim);\n-\tTIFFSetField(tif, TIFFTAG_CFAPATTERN, info->pattern);\n+\tif (TIFFLIB_VERSION < 20201219)\n+\t\tTIFFSetField(tif, TIFFTAG_CFAPATTERN, info->pattern);\n+\telse\n+\t\tTIFFSetField(tif, TIFFTAG_CFAPATTERN, 4, info->pattern);\n \tTIFFSetField(tif, TIFFTAG_CFAPLANECOLOR, 3, cfaPlaneColor);\n \tTIFFSetField(tif, TIFFTAG_CFALAYOUT, 1);\n \n","prefixes":["libcamera-devel","v1.1"]}