{"id":16185,"url":"https://patchwork.libcamera.org/api/1.1/patches/16185/?format=json","web_url":"https://patchwork.libcamera.org/patch/16185/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220609060306.57953-3-jeanmichel.hautbois@ideasonboard.com>","date":"2022-06-09T06:03:04","name":"[libcamera-devel,RFC,2/4] libcamera: lens: Grab the static properties at init time","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1e220fa0f5a78cd3d2ede637c145282cca480ad5","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16185/mbox/","series":[{"id":3166,"url":"https://patchwork.libcamera.org/api/1.1/series/3166/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3166","date":"2022-06-09T06:03:02","name":"Introduce camera lens properties","version":1,"mbox":"https://patchwork.libcamera.org/series/3166/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16185/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16185/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D72DC3273\n\tfor ;\n\tThu, 9 Jun 2022 06:03:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB89665633;\n\tThu, 9 Jun 2022 08:03:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8979465634\n\tfor ;\n\tThu, 9 Jun 2022 08:03:13 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:ae94:9dc3:50ea:aee6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 39A2580A;\n\tThu, 9 Jun 2022 08:03:13 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654754596;\n\tbh=bcIxAAPp7QmJAWe6+zbVDqLDqlh/ZUg0ciwkrLulElo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=jc0F4bHFzjtvuIOy3xZK8w90Lqjf1oYkCMbanIS5kqHML+8tOuFzwNlQ35EP47u9o\n\tT6e/AKVWTW4812M3mDgy3QOygg2UBlOf0C5l12Q9+PpBFOeYtTJmL+j2UYje3EefPb\n\tyleMNuh1n/L7N2V2kBS5BvYUlSz3nbwnRZla925/zZWMNx7TbRZJqxwyjMcbl8fB63\n\t/4qRkVP7+xBkO5MijAffRNIOWC/ffcaWUmUOZSmyll2srW0f3rBlPmvDuYEuyaRwPK\n\ttBE01WPbCg2BOmHhNjQZKGntdX4k8NFWjLjYX+nlezndhl27nAmiiQ8MBxS6AItNY6\n\tFWi1yt4NfTORA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1654754593;\n\tbh=bcIxAAPp7QmJAWe6+zbVDqLDqlh/ZUg0ciwkrLulElo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uex5CD1VLy3hAB+O9EiBO+FU/lf4PVBqT5QgSJBxUR5C41wfYchQty3JjKlHV+9hE\n\t2Ts+RWjytGrt1kGg2ZpvMlZxoKSQ4hZazUHQz4nyrkELHj0o0E4eiNTOpqPP6Re9e6\n\teJLqzQmJlNaYAvkNy9tpcqHl/Oai+Epf1ccqV+d0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uex5CD1V\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Jun 2022 08:03:04 +0200","Message-Id":"<20220609060306.57953-3-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220609060306.57953-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20220609060306.57953-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 2/4] libcamera: lens: Grab the static\n\tproperties at init time","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the CameraLens is created in the pipeline handler, it will offer\nvarious functions to access the lens properties. Add a call to get the\nstatic properties at init time.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n include/libcamera/internal/camera_lens.h | 4 ++++\n src/libcamera/camera_lens.cpp | 5 ++++-\n 2 files changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h\nindex 277417da..523a1481 100644\n--- a/include/libcamera/internal/camera_lens.h\n+++ b/include/libcamera/internal/camera_lens.h\n@@ -19,6 +19,8 @@ namespace libcamera {\n class MediaEntity;\n class V4L2Subdevice;\n \n+struct CameraLensProperties;\n+\n class CameraLens : protected Loggable\n {\n public:\n@@ -44,6 +46,8 @@ private:\n \tstd::unique_ptr subdev_;\n \n \tstd::string model_;\n+\n+\tconst CameraLensProperties *staticProps_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/camera_lens.cpp b/src/libcamera/camera_lens.cpp\nindex b3d48199..d4d44bc7 100644\n--- a/src/libcamera/camera_lens.cpp\n+++ b/src/libcamera/camera_lens.cpp\n@@ -9,6 +9,7 @@\n \n #include \n \n+#include \"libcamera/internal/camera_lens_properties.h\"\n #include \"libcamera/internal/v4l2_subdevice.h\"\n \n /**\n@@ -36,7 +37,7 @@ LOG_DEFINE_CATEGORY(CameraLens)\n * Once constructed the instance must be initialized with init().\n */\n CameraLens::CameraLens(const MediaEntity *entity)\n-\t: entity_(entity)\n+\t: entity_(entity), staticProps_(nullptr)\n {\n }\n \n@@ -73,6 +74,8 @@ int CameraLens::init()\n \t\treturn ret;\n \n \tmodel_ = subdev_->model();\n+\tstaticProps_ = CameraLensProperties::get(model_);\n+\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","RFC","2/4"]}